[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [14] RFR JDK-8234398: Replace ID2D1Factory::GetDesktopDpi with GetDeviceCaps
From:       Phil Race <philip.race () oracle ! com>
Date:       2019-12-09 18:20:53
Message-ID: d66ce055-06d0-d62d-3330-7c6888dd536b () oracle ! com
[Download RAW message or body]

+1

-phil

On 12/3/19 3:52 AM, Alexey Ivanov wrote:
> On 28/11/2019 18:13, Alexey Ivanov wrote:
>> Hello,
>>
>> Please review the following fix which removes the use of 
>> ID2D1Factory::GetDesktopDpi API which is deprecated in VS2019.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234398
>> Webrev: http://cr.openjdk.java.net/~aivanov/8234398/webrev.00/
>>
>> I have tested the new code on Windows 7 and 8.0, GetDeviceCaps 
>> returns the same value as ID2D1Factory::GetDesktopDpi. Java app UI 
>> scales up as expected.
>>
>> On Windows 8.1 and 10, ID2D1Factory::GetDesktopDpi is used; no changes.
>
> Copy-Paste issue: On Windows 8.1 and 10, GetDpiForMonitor function is 
> used. No change for these operating systems.
>
>>
>>
>> This fix completely removes dependency on Direct2D.
>>

[prev in list] [next in list] [prev in thread] [next in thread]