[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on m
From: Phil Race <philip.race () oracle ! com>
Date: 2019-11-25 16:57:40
Message-ID: d990b473-69de-7dc7-9165-8271e1e1408c () oracle ! com
[Download RAW message or body]
I expect we could as it would help with backports but how much longer
can we support 10.12 SDK to build ? Project Lanai is already finding it
hard to keep to the 10.13 SDK ... and 10.12 as an O/S is already EOSL.
So it should just be a stop gap measure.
-phil.
On 11/25/19 4:48 AM, Baesken, Matthias wrote:
>
> Hello, any comments on the issue ?
>
> Could we maybe switch from using
>
> NSTextInputSourceIdentifier
>
> to
>
> String (NSString* ?) , because
> https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier
>
> says NSTextInputSourceIdentifier is a typealias for String ?
>
> Best regards ,Matthias
>
> Hello, I noticed that since today our jdk/jdk build fails on macOS
> . We run it on macOS 10.12 .
>
> It seems
>
> https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33
>
> 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java
> ignores system settings
>
> Brought a dependency on 10.13. Was that intended ? Could we keep
> 10.12 compatibility ?
>
> At least the doc of NSTextInputSourceIdentifier :
> https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier
>
> mentions macOS 10.13+ .
>
> Build errors are :
>
> ----------------------------
>
> /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5:
> error: unknown type name 'NSTextInputSourceIdentifier'
>
> NSTextInputSourceIdentifier kbdLayout;
>
> ^
>
> /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23:
> error: assignment to readonly property
>
> self.cglLayer = windowLayer;
>
> ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
>
> /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19:
> error: assignment to readonly property
>
> self.cglLayer = nil;
>
> ~~~~~~~~~~~~~ ^ ~~~
>
> 3 errors generated.
>
> …
>
> /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18:
> error: incompatible pointer to integer conversion initializing 'BOOL'
> (aka 'signed char') with an expression of type 'id'
> [-Werror,-Wint-conversion]
>
> BOOL mouseIsOver = [[window contentView] mouseIsOver];
>
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> 2 errors generated.
>
> Best regards, Matthias
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
I expect we could as it would help with backports but how much
longer<br>
can we support 10.12 SDK to build ? Project Lanai is already finding
it<br>
hard to keep to the 10.13 SDK ... and 10.12 as an O/S is already
EOSL.<br>
<br>
So it should just be a stop gap measure.<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 11/25/19 4:48 AM, Baesken, Matthias
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:AM6PR02MB507875B99CACB1078A3D0F81934A0@AM6PR02MB5078.eurprd02.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hello, any comments on
the issue ?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Could we maybe switch
from using <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">NSTextInputSourceIdentifier<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">to<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">String (NSString* ?) , because </span>
<a
href="https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier"
moz-do-not-send="true"><span \
lang="EN-US">https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier</span></a><span
lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">says
NSTextInputSourceIdentifier is a typealias for String \
?<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US"><o:p> \
</o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards \
,Matthias<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Hello, I noticed that
since today our jdk/jdk build fails on macOS . We run it
on macOS 10.12 .<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">It seems <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a
href="https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33"
moz-do-not-send="true"><span
style="color:windowtext;text-decoration:none">https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8214578: [macos]
Problem with backslashes on macOS/JIS keyboard: Java
ignores system settings<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Brought a dependency
on 10.13. Was that intended ? Could we keep 10.12
compatibility ?
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">At least the doc of
NSTextInputSourceIdentifier : <a
href="https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier"
moz-do-not-send="true"><span
style="color:windowtext;text-decoration:none">https://developer.appl \
e.com/documentation/appkit/nstextinputsourceidentifier</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">mentions macOS
10.13+ .<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Build errors are \
:<o:p></o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">----------------------------<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5:
error: unknown type name \
'NSTextInputSourceIdentifier'<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"> NSTextInputSourceIdentifier kbdLayout;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> ^<o:p></o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: \
error: assignment to readonly property<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"> self.cglLayer = \
windowLayer;<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US"> \
~~~~~~~~~~~~~ ^ ~~~~~~~~~~~<o:p></o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19: \
error: assignment to readonly property<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"> self.cglLayer = nil;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> ~~~~~~~~~~~~~ ^
~~~<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">3 errors \
generated.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">…<o:p></o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18: \
error: incompatible pointer to integer conversion initializing 'BOOL' (aka 'signed \
char') with an expression
of type 'id' [-Werror,-Wint-conversion]<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> BOOL
mouseIsOver = [[window contentView] mouseIsOver];<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> </span>^
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal">2 errors generated.<o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards, \
Matthias<o:p></o:p></span></p> </div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic