[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR: [XS] 8234323: NULL-check return value of SurfaceData_InitOps on macosx
From: "Baesken, Matthias" <matthias.baesken () sap ! com>
Date: 2019-11-20 14:25:17
Message-ID: AM6PR02MB50787898C71AB58CB2BE86A0934F0 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
Thanks !
In case of no objections I'll push it as trivial tomorrow .
Best regards, Matthias
From: Langer, Christoph <christoph.langer@sap.com>
Sent: Mittwoch, 20. November 2019 15:20
To: Baesken, Matthias <matthias.baesken@sap.com>; 2d-dev@openjdk.java.net
Subject: RE: RFR: [XS] 8234323: NULL-check return value of SurfaceData_Init=
Ops on macosx
Hi Matthias,
looks good and trivial to me.
Cheers
Christoph
From: 2d-dev <2d-dev-bounces@openjdk.java.net<mailto:2d-dev-bounces@openjdk=
.java.net>> On Behalf Of Baesken, Matthias
Sent: Dienstag, 19. November 2019 15:07
To: 2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net>
Subject: [CAUTION] Re: [OpenJDK 2D-Dev] RFR: [XS] 8234323: NULL-check retur=
n value of SurfaceData_InitOps on macosx
Small update - I had to add an inclusion, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.1/
Best regards, Matthias
Hello, please review this small macos related fix .
In the java.desktop coding, at most usages of SurfaceData_InitOps the retur=
n value of the function is NULL-checked to avoid crashes in seldom cases wh=
ere the function SurfaceData_InitOps returns NULL.
However in the macos related coding this is missing at some places.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8234323
http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.0/
Thanks, Matthias
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks \
!<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">In case of no \
objections I’ll push it as trivial tomorrow .<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">Best regards, \
Matthias<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> \
Langer, Christoph <christoph.langer@sap.com> <br>
<b>Sent:</b> Mittwoch, 20. November 2019 15:20<br>
<b>To:</b> Baesken, Matthias <matthias.baesken@sap.com>; \
2d-dev@openjdk.java.net<br> <b>Subject:</b> RE: RFR: [XS] 8234323: NULL-check return \
value of SurfaceData_InitOps on macosx<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi Matthias,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">looks good and trivial to \
me.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Cheers<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Christoph<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <div style="border:none;border-left:solid \
blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> 2d-dev \
<<a href="mailto:2d-dev-bounces@openjdk.java.net">2d-dev-bounces@openjdk.java.net</a>>
<b>On Behalf Of </b>Baesken, Matthias<br>
<b>Sent:</b> Dienstag, 19. November 2019 15:07<br>
<b>To:</b> <a href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Subject:</b> [CAUTION] Re: [OpenJDK 2D-Dev] RFR: [XS] 8234323: NULL-check return \
value of SurfaceData_InitOps on macosx<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Small update – I had to add an \
inclusion, new webrev :<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.1/">http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.1/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best regards, Matthias<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hello, please review this small \
macos related fix .<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white">In \
the java.desktop coding, at most usages of SurfaceData_InitOps the return value of \
the function is NULL-checked to avoid crashes in seldom cases where the \
function SurfaceData_InitOps returns NULL. <o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white">However \
in the macos related coding this is missing at some places.</span><span \
lang="EN-US"><o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Bug/webrev :<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8234323">https://bugs.openjdk.java.net/browse/JDK-8234323</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.0/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks, Matthias<o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic