[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [14] RFR JDK-8233910:java/awt/ColorClass/AlphaColorTest.java is failing
From: Prasanta Sadhukhan <prasanta.sadhukhan () oracle ! com>
Date: 2019-11-12 6:39:02
Message-ID: 8b1ab27d-15da-7aef-6c13-c8212ff52833 () oracle ! com
[Download RAW message or body]
On 12-Nov-19 11:20 AM, Philip Race wrote:
> It can't hurt can it ?
>
> And a while (a good while) back an AWT developer claimed it was also
> recommended for AWT ... I can't find that claim - too hard to locate.
>
> So whilst we don't need to rush off and update all pure AWT tests we
> also don't
> need to create more technical debt.
>
OK. Tried without EDT change and mach5 is still green for 3 iterations
on all 3 platforms .
http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.1/
Regards
Prasanta
> -phil.
>
>
> On 11/11/19, 9:14 PM, Prasanta Sadhukhan wrote:
>>
>> I felt it was not needed as it is awt test and it is not necessary to
>> call under EDT, unlike swing.
>>
>> Regards
>>
>> Prasanta
>>
>> On 12-Nov-19 1:06 AM, Philip Race wrote:
>>> Hi,
>>>
>>> I don't understand why you make this change :-
>>> - SwingUtilities.invokeAndWait(() -> createAndShowGUI());
>>> + createAndShowGUI(); -phil.
>>>
>>>
>>> On 11/11/19, 3:14 AM, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a testfix for an issue seen to be failing
>>>> intermittently in mach5 nightly linux system.
>>>>
>>>> The test uses robot to pick color from a frame's midpoint and check
>>>> if the alpha is blended properly with the color but it seems the
>>>> color is picked from wrong point.
>>>>
>>>> Proposed fix is to make the fraae undecorated and also call
>>>> setLocationRelativeTo() to show the frame at the middle away from
>>>> taskbar to avoid possible mis-pick of color.
>>>>
>>>> mach5 job is run on all 3 platforms and link is present in JBS.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8233910
>>>>
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.0/
>>>>
>>>> Regards
>>>>
>>>> Prasanta
>>>>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 12-Nov-19 11:20 AM, Philip Race
wrote:<br>
</div>
<blockquote type="cite" cite="mid:5DCA4842.6080605@oracle.com">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
It can't hurt can it ? <br>
<br>
And a while (a good while) back an AWT developer claimed it was
also recommended for AWT ... I can't find that claim - too hard to
locate.<br>
<br>
So whilst we don't need to rush off and update all pure AWT tests
we also don't<br>
need to create more technical debt.<br>
<br>
</blockquote>
<p>OK. Tried without EDT change and mach5 is still green for 3
iterations on all 3 platforms .</p>
<p><a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.1/">http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.1/</a></p>
<p>Regards</p>
<p>Prasanta<br>
</p>
<blockquote type="cite" cite="mid:5DCA4842.6080605@oracle.com">
-phil.<br>
<br>
<br>
On 11/11/19, 9:14 PM, Prasanta Sadhukhan wrote:
<blockquote
cite="mid:9d0905e4-fcef-2b0e-68ed-712a5735ac7a@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<p>I felt it was not needed as it is awt test and it is not
necessary to call under EDT, unlike swing.</p>
<p>Regards</p>
<p>Prasanta<br>
</p>
<div class="moz-cite-prefix">On 12-Nov-19 1:06 AM, Philip Race
wrote:<br>
</div>
<blockquote type="cite" cite="mid:5DC9B852.7020805@oracle.com">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Hi,<br>
<br>
I don't understand why you make this change :-<br>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<pre><span class="removed">- SwingUtilities.invokeAndWait(() -> \
createAndShowGUI());</span> <span class="new">+ createAndShowGUI();
-phil.
</span></pre>
<br>
<br>
On 11/11/19, 3:14 AM, Prasanta Sadhukhan wrote:
<blockquote
cite="mid:160f30a5-59a9-bec6-a595-a6e4df734cdd@oracle.com"
type="cite">Hi All, <br>
<br>
Please review a testfix for an issue seen to be failing
intermittently in mach5 nightly linux system. <br>
<br>
The test uses robot to pick color from a frame's midpoint
and check if the alpha is blended properly with the color
but it seems the color is picked from wrong point. <br>
<br>
Proposed fix is to make the fraae undecorated and also call
setLocationRelativeTo() to show the frame at the middle away
from taskbar to avoid possible mis-pick of color. <br>
<br>
mach5 job is run on all 3 platforms and link is present in
JBS. <br>
<br>
Bug: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8233910"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8233910</a>
<br>
<br>
webrev: <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8233910/webrev.0/"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.0/</a>
<br>
<br>
Regards <br>
<br>
Prasanta <br>
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic