[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/b
From: "Baesken, Matthias" <matthias.baesken () sap ! com>
Date: 2019-11-04 9:19:08
Message-ID: AM6PR02MB507833C471140406FEE30EC5937F0 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
I'll push this now as XS with the review of Christoph.
I think Prasanta and Phil are okay with the change too .
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 31. Oktober 2019 09:51
To: 'Prasanta Sadhukhan' <prasanta.sadhukhan@oracle.com>
Cc: 2d-dev@openjdk.java.net; Philip Race <philip.race@oracle.com>; Langer, =
Christoph <christoph.langer@sap.com>
Subject: RE: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude javax/swing/plaf/=
basic/BasicGraphicsUtils/8132119/bug8132119.java
* We can work on it but probably, it is safe to problem list the test f=
or linux for now.
Ok, great. May I add you as reviewer ?
Best regards, Matthias
From: Prasanta Sadhukhan <prasanta.sadhukhan@oracle.com<mailto:prasanta.sad=
hukhan@oracle.com>>
Sent: Donnerstag, 31. Oktober 2019 09:27
To: Philip Race <philip.race@oracle.com<mailto:philip.race@oracle.com>>; La=
nger, Christoph <christoph.langer@sap.com<mailto:christoph.langer@sap.com>>
Cc: Baesken, Matthias <matthias.baesken@sap.com<mailto:matthias.baesken@sap=
.com>>; 2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude javax/swing/plaf/=
basic/BasicGraphicsUtils/8132119/bug8132119.java
This test tests the newly added public API of BasicGraphicsUtils (exposing =
the functionality provided by internal class SwingUtilities2) for use by th=
ird party LAFs in JDK9 and beyond, so I guess we cannot ditch it completely=
. Regarding the test fragility, I actually incorporated the changes propose=
d by Phil, which are
- add "x" to the position it passes to checkImageContainsSymbol
- increase WIDTH
- use rendering hints to use aliased text in testDrawString()
which makes the test pass in linux but it now creates problem in macos. We =
can work on it but probably, it is safe to problem list the test for linux =
for now.
Regards
Prasanta
On 30-Oct-19 8:08 PM, Philip Race wrote:
Theoretically we've been going to fix this fragile test for weeks.
It tests something important or else I'd ditch it completely ..
Prasanta ?
-phil.
On 10/30/19, 7:14 AM, Langer, Christoph wrote:
Hi Matthias,
looks good, I definitely second that. Let's wait what 2d folks (Phil?) have=
to say.
Best regards
Christoph
From: Baesken, Matthias <matthias.baesken@sap.com><mailto:matthias.baesken@=
sap.com>
Sent: Mittwoch, 30. Oktober 2019 14:59
To: 2d-dev@openjdk.java.net<mailto:2d-dev@openjdk.java.net>
Cc: Langer, Christoph <christoph.langer@sap.com><mailto:christoph.langer@sa=
p.com>
Subject: RFR [XS] : 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUt=
ils/8132119/bug8132119.java
Please review the following small change .
It excludes javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.ja=
va ; the test seems to be fragile on various Linux distros ,
for instance on our Ubuntu 18 .
The issues are already described in detail here :
https://bugs.openjdk.java.net/browse/JDK-8229935
"All in all this test looks really fragile. It is a miracle it has passed a=
s much as it has .. I think Linux
may expose this because the font being used is more or less "fixed" on the =
other platforms but
on Linux the font being used varies."
As long as 8229935 is not fixed, the test should be excluded at least o=
n Linux .
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8233202
http://cr.openjdk.java.net/~mbaesken/webrevs/8233202.0/<http://cr.openjdk.j=
ava.net/%7Embaesken/webrevs/8233202.0/>
Thanks, Matthias
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1110859534;
mso-list-template-ids:-356334768;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1
{mso-list-id:1640183855;
mso-list-type:hybrid;
mso-list-template-ids:1006792636 462316594 67567619 67567621 67567617 67567619 \
67567621 67567617 67567619 67567621;} @list l1:level1
{mso-level-start-at:3589;
mso-level-number-format:bullet;
mso-level-text:\F0D8;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;
mso-fareast-font-family:Calibri;
mso-bidi-font-family:"Times New Roman";}
@list l1:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l1:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l1:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l1:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l1:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l1:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l1:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l1:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US">I’ll push this now as XS \
with the review of Christoph.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US" style="color:windowtext;mso-fareast-language:EN-US">I think </span><span \
lang="EN-US" style="color:windowtext">Prasanta and Phil are okay with the change too \
.</span><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US"><o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US">Best regards, \
Matthias<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext"> \
Baesken, Matthias <br>
<b>Sent:</b> Donnerstag, 31. Oktober 2019 09:51<br>
<b>To:</b> 'Prasanta Sadhukhan' <prasanta.sadhukhan@oracle.com><br>
<b>Cc:</b> 2d-dev@openjdk.java.net; Philip Race <philip.race@oracle.com>; \
Langer, Christoph <christoph.langer@sap.com><br> <b>Subject:</b> RE: [OpenJDK \
2D-Dev] RFR [XS] : 8233202: exclude \
javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<ul style="margin-top:0cm" type="disc">
<li class="MsoListParagraph" style="color:windowtext;margin-left:0cm;mso-list:l1 \
level1 lfo3"> <span lang="EN-US" style="color:black">We can work on it but probably, \
it is safe to problem list the test for linux for now.</span><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p></o:p></span></li></ul> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US">Ok, great. May I add you as \
reviewer ?<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US">Best regards, \
Matthias<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext"> \
Prasanta Sadhukhan <<a \
href="mailto:prasanta.sadhukhan@oracle.com">prasanta.sadhukhan@oracle.com</a>> \
<br> <b>Sent:</b> Donnerstag, 31. Oktober 2019 09:27<br>
<b>To:</b> Philip Race <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>>; Langer, \
Christoph <<a href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>><br>
<b>Cc:</b> Baesken, Matthias <<a \
href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>>; <a \
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br> <b>Subject:</b> \
Re: [OpenJDK 2D-Dev] RFR [XS] : 8233202: exclude \
javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>This test tests the newly added public API of BasicGraphicsUtils (exposing the \
functionality provided by internal class SwingUtilities2) for use by third party LAFs \
in JDK9 and beyond, so I guess we cannot ditch it completely. Regarding the test \
fragility, I actually incorporated the changes proposed by Phil, which \
are<o:p></o:p></p> <p>- add "x" to the position it passes to \
checkImageContainsSymbol<o:p></o:p></p> <p>- increase WIDTH <o:p></o:p></p>
<p>- use rendering hints to use aliased text in testDrawString()<o:p></o:p></p>
<p>which makes the test pass in linux but it now creates problem in macos. We can \
work on it but probably, it is safe to problem list the test for linux for \
now.<o:p></o:p></p> <p class="MsoNormal">Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 30-Oct-19 8:08 PM, Philip Race wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Theoretically we've been going to fix this fragile test for \
weeks.<br> <br>
It tests something important or else I'd ditch it completely ..<br>
<br>
Prasanta ?<br>
<br>
-phil.<br>
<br>
On 10/30/19, 7:14 AM, Langer, Christoph wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi Matthias,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">looks good, I definitely second that. Let’s wait what 2d \
folks (Phil?) have to say.<o:p></o:p></p> <p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Best regards<o:p></o:p></p>
</blockquote>
</blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Christoph<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> Baesken, Matthias <a \
href="mailto:matthias.baesken@sap.com"> <matthias.baesken@sap.com></a> <br>
<b>Sent:</b> Mittwoch, 30. Oktober 2019 14:59<br>
<b>To:</b> <a href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Cc:</b> Langer, Christoph <a \
href="mailto:christoph.langer@sap.com"><christoph.langer@sap.com></a><br> \
<b>Subject:</b> RFR [XS] : 8233202: exclude \
javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java<o:p></o:p></p> \
</div> </div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please review the following small change .<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">It excludes \
javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java ; the test \
seems to be fragile on various Linux distros ,<o:p></o:p></p> <p \
class="MsoNormal"> for instance on our Ubuntu 18 .<o:p></o:p></p> \
<p class="MsoNormal"> <o:p></o:p></p> <p class="MsoNormal">The issues are \
already described in detail here :<o:p></o:p></p> <p \
class="MsoNormal"> <o:p></o:p></p> <p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8229935"><span \
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8229935</span></a><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:35.4pt"> <o:p></o:p></p>
<p class="MsoNormal" style="margin-left:35.4pt">„All in all this test looks \
really fragile. It is a miracle it has passed as much as it has .. I think Linux<br> \
may expose this because the font being used is more or less "fixed" on the \
other platforms but<br> on Linux the font being used varies.”<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">As long as 8229935 is not<span \
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7"> \
fixed, the test should be excluded at least on Linux \
.</span><o:p></o:p></p> <p class="MsoNormal"><span \
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7"> </span><o:p></o:p></p>
<p class="MsoNormal"><span \
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7">Bug/webrev \
:</span><o:p></o:p></p> <p class="MsoNormal"><span \
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7"> </span><o:p></o:p></p>
<p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8233202"><span \
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8233202</span></a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8233202.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8233202.0/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks, Matthias<o:p></o:p></p>
</div>
</blockquote>
</blockquote>
</div>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic