[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [CAUTION] RFR [XS]: 8231445: check ZALLOC return values in awt coding
From: "Langer, Christoph" <christoph.langer () sap ! com>
Date: 2019-09-25 9:05:09
Message-ID: AM6PR02MB5192F372D6888ECB0869B48E8A870 () AM6PR02MB5192 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
Hi Matthias,
looks good to me.
Maybe you want to create a Macro for the repeating pattern:
graphicsConfigs[ind] = ZALLOC (_AwtGraphicsConfigData);
if (graphicsConfigs[ind] == NULL) {
JNU_ThrowOutOfMemoryError(env, "allocation in getAllConfigs failed");
goto cleanup;
}
in getAllConfigs?
Best regards
Christoph
From: 2d-dev <2d-dev-bounces@openjdk.java.net> On Behalf Of Baesken, Matthias
Sent: Mittwoch, 25. September 2019 09:40
To: awt-dev@openjdk.java.net; 2d-dev@openjdk.java.net
Subject: [CAUTION] [OpenJDK 2D-Dev] RFR [XS]: 8231445: check ZALLOC return values in awt coding
Hello, please review this small fix . It deals with return value checking of ZALLOC .
ZALLOC is a macro using calloc, please see :
jdk/src/java.desktop/unix/native/common/awt/awt_p.h
/* allocated and initialize a structure */
#define ZALLOC(T) ((struct T *)calloc(1, sizeof(struct T)))
... so the return value has to be checked which is missing at some places.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8231445
http://cr.openjdk.java.net/~mbaesken/webrevs/8231445.0/
Thanks, Matthias
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi Matthias,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">looks good to me.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Maybe you want to create a Macro for the \
repeating pattern:<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">graphicsConfigs[ind] = ZALLOC \
(_AwtGraphicsConfigData);<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">if (graphicsConfigs[ind] == NULL) {<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"> \
JNU_ThrowOutOfMemoryError(env, "allocation in getAllConfigs \
failed");<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"> </span>goto cleanup;<o:p></o:p></p> <p \
class="MsoNormal">}<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">in getAllConfigs?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best regards<o:p></o:p></p>
<p class="MsoNormal">Christoph<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="mso-fareast-language:DE"> 2d-dev <2d-dev-bounces@openjdk.java.net> <b>On \
Behalf Of </b>Baesken, Matthias<br> <b>Sent:</b> Mittwoch, 25. September 2019 \
09:40<br> <b>To:</b> awt-dev@openjdk.java.net; 2d-dev@openjdk.java.net<br>
<b>Subject:</b> [CAUTION] [OpenJDK 2D-Dev] RFR [XS]: 8231445: check ZALLOC return \
values in awt coding<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hello, please review this small fix . \
It deals with return value checking of ZALLOC .<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">ZALLOC is a macro using calloc, please see \
:<br> <br>
jdk/src/java.desktop/unix/native/common/awt/awt_p.h<br>
/* allocated and initialize a structure */<br>
#define ZALLOC(T) ((struct T *)calloc(1, sizeof(struct T)))<br>
<br>
… so the return value has to be checked which is \
missing at some places.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal">Bug/webrev \
:<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8231445">https://bugs.openjdk.java.net/browse/JDK-8231445</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/~mbaesken/webrevs/8231445.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8231445.0/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks, Matthias<o:p></o:p></p>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic