[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR [XS] : 8230900: missing ReleaseStringUTFChars in java.desktop native code
From: Philip Race <philip.race () oracle ! com>
Date: 2019-09-13 17:44:55
Message-ID: 5D7BD597.5020101 () oracle ! com
[Download RAW message or body]
Looks good.
-phil.
On 9/12/19, 11:37 PM, Baesken, Matthias wrote:
>
> Hi Christoph,
>
> I removed the blanks after ReleaseStringUTFChars in fontpath.c,
> and adjusted the ReleaseStringUTFChars call to C++ syntax in
> ShellFolder2.c.
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8230900.1/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8230900.1/>
>
> Best Regards ,
>
> Matthias
>
> *From:*Langer, Christoph <christoph.langer@sap.com>
> *Sent:* Donnerstag, 12. September 2019 21:29
> *To:* Baesken, Matthias <matthias.baesken@sap.com>;
> 2d-dev@openjdk.java.net; awt-dev@openjdk.java.net
> *Subject:* RE: RFR [XS] : 8230900: missing ReleaseStringUTFChars in
> java.desktop native code
>
> Hi Matthias,
>
> the changes seem to make sense.
>
> I've got 2 findings:
>
> In fontpath.c, there is a space between ReleaseStringUTFChars and (
> which should be removed in lines 1282 and 1339.
>
> In ShellFolder2.c, line 1134, the function call takes only 2
> parameters. You need to remove the first param env. Otherwise it
> breaks the Windows build.
>
> Thanks
>
> Christoph
>
> *From:*2d-dev <2d-dev-bounces@openjdk.java.net
> <mailto:2d-dev-bounces@openjdk.java.net>> *On Behalf Of *Baesken, Matthias
> *Sent:* Donnerstag, 12. September 2019 11:08
> *To:* 2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net>;
> awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
> *Subject:* [CAUTION] [OpenJDK 2D-Dev] RFR [XS] : 8230900: missing
> ReleaseStringUTFChars in java.desktop native code
>
> Hello, please reviews this small fix .
>
> It adds a couple of missing ReleaseStringUTFChars calls in
> java.desktop module native coding (mostly in cases of early returns).
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8230900
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8230900.0/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8230900.0/>
>
> Thanks, Matthias
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Looks good.<br>
<br>
-phil.<br>
<br>
On 9/12/19, 11:37 PM, Baesken, Matthias wrote:
<blockquote
cite="mid:AM6PR02MB5078A199F7419E7E769ED19C93B30@AM6PR02MB5078.eurprd02.prod.outlook.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:DE;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.new
{mso-style-name:new;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi Christoph, <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">I removed the blanks
after </span><span lang="EN-US">ReleaseStringUTFChars in
fontpath.c, and adjusted the
</span><span style="mso-fareast-language:DE" \
lang="EN-US">ReleaseStringUTFChars call to C++ syntax in
</span><span lang="EN-US">ShellFolder2.c.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">New webrev :</span><span
lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8230900.1/">http://cr.openjdk.java.net/~mbaesken/webrevs/8230900.1/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best Regards ,<o:p></o:p></p>
<p class="MsoNormal"> Matthias<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:DE" \
lang="EN-US">From:</span></b><span style="mso-fareast-language:DE" lang="EN-US"> \
Langer,
Christoph <a class="moz-txt-link-rfc2396E" \
href="mailto:christoph.langer@sap.com"><christoph.langer@sap.com></a> <br>
<b>Sent:</b> Donnerstag, 12. September 2019 21:29<br>
<b>To:</b> Baesken, Matthias
<a class="moz-txt-link-rfc2396E" \
href="mailto:matthias.baesken@sap.com"><matthias.baesken@sap.com></a>; <a \
class="moz-txt-link-abbreviated" \
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a>; <a \
class="moz-txt-link-abbreviated" \
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br> \
<b>Subject:</b> RE: RFR [XS] : 8230900: missing
ReleaseStringUTFChars in java.desktop native \
code<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Matthias,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">the changes seem to
make sense.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I’ve got 2 \
findings:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">In fontpath.c, there
is a space between ReleaseStringUTFChars and ( which
should be removed in lines 1282 and 1339.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">In ShellFolder2.c,
line 1134, the function call takes only 2 parameters. You
need to remove the first param env. Otherwise it breaks
the Windows build.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue
1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:DE" \
lang="EN-US">From:</span></b><span style="mso-fareast-language:DE" lang="EN-US"> \
2d-dev <<a moz-do-not-send="true"
\
href="mailto:2d-dev-bounces@openjdk.java.net">2d-dev-bounces@openjdk.java.net</a>> \
<b>On Behalf Of </b>Baesken, Matthias<br> <b>Sent:</b> Donnerstag, 12. September \
2019 11:08<br> <b>To:</b> <a moz-do-not-send="true"
\
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a>; <a \
moz-do-not-send="true" href="mailto:awt-dev@openjdk.java.net">
awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> [CAUTION] [OpenJDK 2D-Dev] RFR [XS]
: 8230900: missing ReleaseStringUTFChars in
java.desktop native code<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hello, please
reviews this small fix .<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">It adds a couple of
missing ReleaseStringUTFChars calls in \
java.desktop module native coding (mostly in cases of early
returns).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Bug/webrev \
:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8230900"><span
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8230900</span></a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8230900.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8230900.0/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks, Matthias<o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic