[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing
From:       Dmitry Batrak <dmitry.batrak () jetbrains ! com>
Date:       2019-08-29 10:58:13
Message-ID: CAET5FPvmaa8AcLw3_9ufba1p09tC32eF4KSJJWwmKqgh3n9WLw () mail ! gmail ! com
[Download RAW message or body]

Hello,

I'd like to submit a patch for JDK-8210058. I'm not a Committer, so I'll
need someone to sponsor this change.

The issue is related to the implementation of algorithmic italics in
FreeType font scaler. At the moment it uses FT_GlyphSlot_Oblique, but its
implementation doesn't take into account the glyph transform, previously
set using FT_Set_Transform, and FreeType developers don't seem to have any
interest in changing that (see
https://savannah.nongnu.org/bugs/index.php?54565).
The proposed solution is to include corresponding shear transform
explicitly in matrix passed to FT_Set_Transform instead of using
FT_GlyphSlot_Oblique.
Proposed patch doesn't add any tests, as the change only impacts glyph
rendering, and I couldn't think of a reliable way to test that
automatically. Existing automated tests from OpenJDK pass after the fix.

Issue:  https://bugs.openjdk.java.net/browse/JDK-8210058
Webrev: http://cr.openjdk.java.net/~dbatrak/8210058/webrev.00/

Best regards,
Dmitry Batrak

[Attachment #3 (text/html)]

<div dir="ltr">Hello,<br><br>I&#39;d like to submit a patch for JDK-8210058. I&#39;m \
not a Committer, so I&#39;ll need someone to sponsor this change.<br><br><div>The \
issue is related to the implementation of algorithmic italics in FreeType font \
scaler. At the moment it uses FT_GlyphSlot_Oblique, but its implementation \
doesn&#39;t take into account the glyph transform, previously set using \
FT_Set_Transform, and FreeType developers don&#39;t seem to have any interest in \
changing that (see <a \
href="https://savannah.nongnu.org/bugs/index.php?54565">https://savannah.nongnu.org/bugs/index.php?54565</a>).</div><div>The \
proposed solution is to include corresponding shear transform explicitly in matrix \
passed to FT_Set_Transform instead of using FT_GlyphSlot_Oblique.</div><div>Proposed \
patch doesn&#39;t add any tests, as the change only impacts glyph rendering, and I \
couldn&#39;t think of a reliable way to test that automatically. Existing automated \
tests from OpenJDK pass after the fix.<br></div><br>Issue:   <a \
href="https://bugs.openjdk.java.net/browse/JDK-8210058">https://bugs.openjdk.java.net/browse/JDK-8210058</a><br>Webrev: \
<a href="http://cr.openjdk.java.net/~dbatrak/8210058/webrev.00/">http://cr.openjdk.java.net/~dbatrak/8210058/webrev.00/</a><br><br>Best \
regards,<br>Dmitry Batrak</div>



[prev in list] [next in list] [prev in thread] [next in thread]