[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] RFR [14]: JDK-8228711: Path rendered incorrectly when it goes outside the clipping 
From:       Laurent_Bourgès <bourges.laurent () gmail ! com>
Date:       2019-07-29 7:56:16
Message-ID: CAKjRUT78E7nCP1fkbwNQHiMYPsZkomTOaMmzd4rnFWiee4GyAA () mail ! gmail ! com
[Download RAW message or body]

Hi,

Please review this bug fix for the Marlin renderer (introduced in
JDK11.0.2):
JBS: https://bugs.openjdk.java.net/browse/JDK-8228711
webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8228711.0/

This patch is very close to MarlinFX patch integrated last week in OpenJFX
14, see https://bugs.openjdk.java.net/browse/JDK-8226789

Changes:
- Stroker: fixed closePath() to preserve last position and its outcode
- TransformingPathConsumer2D: fixed PathClipFilter.closePath() to preserve
last position and its outcode
- Dasher: better precision handling (comparison float value with epsilon)
- ClipShapeTest: use preliminary curve subdivision (length > 50px) to avoid
false positives on long stroked curves (quad / cubic) + lowered thresholds

Cheers,
Laurent

[Attachment #3 (text/html)]

<div dir="ltr"><div>Hi,</div><div><br></div><div>Please review this bug fix for the \
Marlin renderer (introduced in JDK11.0.2):</div><div>JBS: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8228711">https://bugs.openjdk.java.net/browse/JDK-8228711</a></div><div>webrev: \
<a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-8228711.0/">http://cr.open \
jdk.java.net/~lbourges/marlin/marlin-8228711.0/</a></div><div><br></div><div>This \
patch is very close to MarlinFX patch integrated last week in OpenJFX 14, see <a \
href="https://bugs.openjdk.java.net/browse/JDK-8226789">https://bugs.openjdk.java.net/browse/JDK-8226789</a></div><div><br></div><div>Changes:</div><div>- \
Stroker: fixed closePath() to preserve last position and its outcode</div><div>- \
TransformingPathConsumer2D: fixed PathClipFilter.closePath() to preserve last \
position and its outcode</div><div>- Dasher: better precision handling (comparison \
float value with epsilon)</div><div>- ClipShapeTest: use preliminary curve \
subdivision (length &gt; 50px)  to avoid false positives on long stroked curves (quad \
/ cubic) + lowered  thresholds</div><br><div>Cheers,</div><div>Laurent</div></div>



[prev in list] [next in list] [prev in thread] [next in thread]