[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] [12u] RFR (S): 8228466: Fix build on AIX and with Solaris Studio 12u4 in 12u after 
From:       "Langer, Christoph" <christoph.langer () sap ! com>
Date:       2019-07-22 6:28:57
Message-ID: AM6PR02MB519212B02535DD166006E8DA8AC40 () AM6PR02MB5192 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]

Hi,

please review and approve this patch for fixing the AIX and the Solaris/SS1=
2u4 build of JDK12u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8228466
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8228466.0/

The build issues were only discovered after the final OpenJDK 12.0.2 source=
 was published. Initially I only reported AIX but we also see the build bro=
ken on Solaris with the older Sun Studio level 12u4. As per [0], Oracle bui=
lds 12u with SS12u6 but we at SAP still used 12u4 and found it working unti=
l then. The fix for Solaris seems to be small and harmless, so I request to=
 integrate it as well. The changes prove to work in JDK 11.0.4 [1].

As per prior discussion [2], I request review and approval for pushing this=
 to 12u.

Thanks
Christoph

[0] https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms
[1] http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/a267d045754a
[2] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-July/00144=
1.html


[Attachment #3 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal"><span lang="EN-US">please review and approve this patch for \
fixing the AIX and the Solaris/SS12u4 build of JDK12u.<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p>&nbsp;</o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8228466"> \
https://bugs.openjdk.java.net/browse/JDK-8228466</a> <o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Webrev: <a \
href="http://cr.openjdk.java.net/~clanger/webrevs/8228466.0/"> \
http://cr.openjdk.java.net/~clanger/webrevs/8228466.0/</a> <o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p>&nbsp;</o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">The build issues were only discovered after the \
final OpenJDK 12.0.2 source was published. Initially I only reported AIX but we also \
see the build broken on Solaris with the older Sun Studio level 12u4. As per [0], \
Oracle  builds 12u with SS12u6 but we at SAP still used 12u4 and found it working \
until then. The fix for Solaris seems to be small and harmless, so I request to \
integrate it as well. The changes prove to work in JDK 11.0.4 \
[1].<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p>&nbsp;</o:p></span></p> <p class="MsoNormal"><span lang="EN-US">As \
per prior discussion [2], I request review and approval for pushing this to \
12u.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p>&nbsp;</o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Thanks<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Christoph<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p>&nbsp;</o:p></span></p> <p class="MsoNormal"><span lang="EN-US">[0] \
<a href="https://wiki.openjdk.java.net/display/Build/Supported&#43;Build&#43;Platforms">
 https://wiki.openjdk.java.net/display/Build/Supported&#43;Build&#43;Platforms</a> \
<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US">[1] <a \
href="http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/a267d045754a"> \
http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/a267d045754a</a> \
<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US">[2] <a \
href="https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-July/001441.html"> \
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-July/001441.html</a><o:p></o:p></span></p>
 <p class="MsoNormal"><span lang="EN-US"><o:p>&nbsp;</o:p></span></p>
</div>
</body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic