[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info
From: "Baesken, Matthias" <matthias.baesken () sap ! com>
Date: 2019-07-16 15:08:59
Message-ID: AM6PR02MB5078854BE5140584ABC3484593CE0 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
Ping , any comments on this one ?
Thanks, Matthias
From: Baesken, Matthias
Sent: Mittwoch, 10. Juli 2019 08:49
To: 2d-dev@openjdk.java.net
Cc: Phil Race (philip.race@oracle.com) <philip.race@oracle.com>
Subject: FW: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the \
fontconfig info file
> Before I, or anyone else, starts to look at or comment on this,
> can you instead post to the correct list : 2d-dev.
Sure!
Best regards, Matthias
From: Philip Race <philip.race@oracle.com<mailto:philip.race@oracle.com>>
Sent: Dienstag, 9. Juli 2019 17:26
To: Baesken, Matthias <matthias.baesken@sap.com<mailto:matthias.baesken@sap.com>>
Cc: awt-dev@openjdk.java.net<mailto:awt-dev@openjdk.java.net>
Subject: Re: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the \
fontconfig info file
Hi,
Before I, or anyone else, starts to look at or comment on this,
can you instead post to the correct list : 2d-dev.
-phil.
On 7/9/19, 7:21 AM, Baesken, Matthias wrote:
Hello, please review this small change that enhances logging a bit .
When reading the fcinfo - file (fontconfig info file) we currently have very limited \
logging. This should be enhanced to get more info in case of errors , and to have at \
least some info in the log when -Dsun.java2d.debugfonts=true is set.
Currently the logging writes a ton of info about lots of non-existant files , \
but misses the fcinfo file .
Example output , we run here with -Dsun.java2d.debugfonts=true set : (with my \
added "successfully parsed the fontconfig file at ..." from the patch )
...
INFO: Creating standard Font Configuration
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.properties Jul 09, 2019 \
3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.bfc Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.properties Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.4.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.4.12.14-25.25-default.properties Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.4.12.14-25.25-default.bfc Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.4.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.4.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findFontConfigFile
INFO: Did not find a fontconfig file.
Jul 09, 2019 3:36:59 PM sun.font.FcFontConfiguration readFcInfo
INFO: successfully parsed the fontconfig file at \
/myhomedir/user/.java/fonts/14.0.0.1-internal/fcinfo-1-thismachine-Linux-4.12.14-25.25-default-en-US.properties
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8227441
http://cr.openjdk.java.net/~mbaesken/webrevs/8227441.0/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8227441.0/>
Thanks, Matthias
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Ping , any \
comments on this one ?<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="color:windowtext"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US" style="color:windowtext">Thanks, Matthias<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE"> Baesken, Matthias <br>
<b>Sent:</b> Mittwoch, 10. Juli 2019 08:49<br>
<b>To:</b> 2d-dev@openjdk.java.net<br>
<b>Cc:</b> Phil Race (philip.race@oracle.com) <philip.race@oracle.com><br>
<b>Subject:</b> FW: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading \
the fontconfig info file<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">>Before I, or anyone else, starts to look \
at or comment on this,<br> >can you instead post to the correct list : \
2d-dev.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="color:windowtext"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US" style="color:windowtext">Sure!<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US" style="color:windowtext">Best regards, Matthias<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE"> Philip Race <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> <br>
<b>Sent:</b> Dienstag, 9. Juli 2019 17:26<br>
<b>To:</b> Baesken, Matthias <<a \
href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>><br> \
<b>Cc:</b> <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br> \
<b>Subject:</b> Re: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading \
the fontconfig info file<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi,<br>
<br>
Before I, or anyone else, starts to look at or comment on this,<br>
can you instead post to the correct list : 2d-dev.<br>
<br>
-phil.<br>
<br>
On 7/9/19, 7:21 AM, Baesken, Matthias wrote: <span style="mso-fareast-language:DE">
<o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US">Hello, please review this small \
change that enhances logging a bit .</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">When reading the fcinfo - file (fontconfig info file) we currently have \
very limited logging. <br> This should be enhanced to get more info in case of \
errors , and to have at least some info in the log when -Dsun.java2d.debugfonts=true \
is set.</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">Currently the logging writes a ton of info about \
lots of non-existant files , but misses the fcinfo file .</span><o:p></o:p></p> \
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Example output , we run here with \
-Dsun.java2d.debugfonts=true set : (with my \
added “successfully parsed the fontconfig file at \
…” from the patch )</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US"> …</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">INFO: Creating standard Font \
Configuration</span><o:p></o:p></p> <p class="MsoNormal"><span lang="EN-US">Jul 09, \
2019 3:36:59 PM sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.properties</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.bfc</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.properties</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.Linux.4.bfc</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.Linux.properties</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.Linux.bfc</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration \
findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span lang="EN-US">INFO: Looking \
for text fontconfig file : \
/images/jdk/lib/fontconfig.4.12.14-25.25-default.properties</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.4.12.14-25.25-default.bfc</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for text fontconfig file : \
/images/jdk/lib/fontconfig.4.properties</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.4.bfc</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration \
findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span lang="EN-US">INFO: Looking \
for text fontconfig file : \
/images/jdk/lib/fontconfig.properties</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.awt.FontConfiguration findImpl</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Looking for binary fontconfig file : \
/images/jdk/lib/fontconfig.bfc</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration \
findFontConfigFile</span><o:p></o:p></p> <p class="MsoNormal"><span \
lang="EN-US">INFO: Did not find a fontconfig file.</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">Jul 09, 2019 3:36:59 PM \
sun.font.FcFontConfiguration readFcInfo</span><o:p></o:p></p> <p \
class="MsoNormal"><span lang="EN-US">INFO: successfully parsed the fontconfig file at \
/myhomedir/user/.java/fonts/14.0.0.1-internal/fcinfo-1-thismachine-Linux-4.12.14-25.25-default-en-US.properties</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Bug/webrev :</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8227441">https://bugs.openjdk.java.net/browse/JDK-8227441</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8227441.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8227441.0/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks, Matthias<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic