[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> RFR: 8227587: Add internal privileged System.loadLibrary
From: Philip Race <philip.race () oracle ! com>
Date: 2019-07-12 14:14:55
Message-ID: 5D2895DF.8070001 () oracle ! com
[Download RAW message or body]
Hi,
Regarding all the touches on the desktop module
1) awt-dev isn't the only list, you should have included swing-dev and
2d-dev at least
2) I am wondering what client testing you propose to do to verify this ?
3) I've spent spare time over a number of months trying to decrease
unnecessary coupling between desktop and base modules. This seems to create
additional technical debt there with minimal benefit, so in other words
I'd much prefer that either you don't do this at all or the many, many,
uses in the desktop module that are the heaviest Java->native code
user in the JDK are dealt with entirely separately (separate bug) and at
a minimum
there is one place in the desktop module that they all call to and
perhaps only then *through*.
So do not push this.
-phil.
On 7/12/19, 6:27 AM, Roger Riggs wrote:
> Hi Claes,
>
> Looks fine.
>
> Thanks for the updates, Roger
>
>
> On 7/11/19 10:39 AM, Claes Redestad wrote:
>> Hi Roger,
>>
>> On 2019-07-11 16:10, Roger Riggs wrote:
>>> Hi Claes,
>>>
>>> JavaLangAccess.java:
>>> 316: Add @param tag
>>
>> done.
>>
>>>
>>> System.java: 2282, 2287
>>> Runtime.loadLibrary0 makes a second check for a security manager.
>>> Is there any potential gain by calling ClassLoader.loadLibrary
>>> directly?
>>> None of the internal uses would have a separatorChar.
>>
>> Most of the gain comes from not having to load one-off PA classes or
>> lambdas, but of course avoiding the indexOf and a few indirections are
>> marginally helpful to startup. We should at least assert that the
>> library names are sane, though.
>>
>>>
>>> I expect most of the files need a copyright update.
>>> The script in <repo>/make/scripts/update_copyright_year.sh should do
>>> the work for modified files.
>>
>> Fixed copyrights and updated in place:
>> http://cr.openjdk.java.net/~redestad/8227587/open.00
>>
>> Thanks!
>>
>> /Claes
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
Regarding all the touches on the desktop module<br>
1) awt-dev isn't the only list, you should have included swing-dev
and 2d-dev at least<br>
2) I am wondering what client testing you propose to do to verify
this ?<br>
<br>
3) I've spent spare time over a number of months trying to decrease<br>
unnecessary coupling between desktop and base modules. This seems to
create<br>
additional technical debt there with minimal benefit, so in other
words<br>
I'd much prefer that either you don't do this at all or the many,
many,<br>
uses in the desktop module that are the heaviest Java->native
code<br>
user in the JDK are dealt with entirely separately (separate bug)
and at a minimum<br>
there is one place in the desktop module that they all call to and<br>
perhaps only then *through*.<br>
<br>
So do not push this.<br>
<br>
-phil.<br>
<br>
<br>
On 7/12/19, 6:27 AM, Roger Riggs wrote:
<blockquote
cite="mid:60d95350-c42c-1498-5c72-174736e863c0@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Hi Claes,<br>
<br>
Looks fine.<br>
<br>
Thanks for the updates, Roger<br>
<br>
<br>
<div class="moz-cite-prefix">On 7/11/19 10:39 AM, Claes Redestad
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:2cbfd5d8-c4a0-4a2d-ba62-6fed14dc7155@oracle.com">Hi
Roger, <br>
<br>
On 2019-07-11 16:10, Roger Riggs wrote: <br>
<blockquote type="cite">Hi Claes, <br>
<br>
JavaLangAccess.java: <br>
316: Add @param tag <br>
</blockquote>
<br>
done. <br>
<br>
<blockquote type="cite"> <br>
System.java: 2282, 2287 <br>
Runtime.loadLibrary0 makes a second check for a security
manager. <br>
Is there any potential gain by calling ClassLoader.loadLibrary
directly? <br>
None of the internal uses would have a separatorChar. <br>
</blockquote>
<br>
Most of the gain comes from not having to load one-off PA
classes or <br>
lambdas, but of course avoiding the indexOf and a few
indirections are <br>
marginally helpful to startup. We should at least assert that
the <br>
library names are sane, though. <br>
<br>
<blockquote type="cite"> <br>
I expect most of the files need a copyright update. <br>
The script in
<repo>/make/scripts/update_copyright_year.sh should do
the work for modified files. <br>
</blockquote>
<br>
Fixed copyrights and updated in place: <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eredestad/8227587/open.00">http://cr.openjdk.java.net/~redestad/8227587/open.00</a>
<br>
<br>
Thanks! <br>
<br>
/Claes <br>
</blockquote>
<br>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic