[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] JDK-8226654 Some swing gtk regression tests fail with "java.lang.InternalError:
From:       Philip Race <philip.race () oracle ! com>
Date:       2019-07-05 18:12:12
Message-ID: 5D1F92FC.40507 () oracle ! com
[Download RAW message or body]

Looks ok to me too, but I think awt-dev (added) is the most appropriate
email list since this is AWT Robot code.

-phil.

On 7/5/19, 1:51 AM, Prasanta Sadhukhan wrote:
>
> looks ok to me but the review should have been done in swing-dev alias.
>
> Regards
> Prasanta
> On 04-Jul-19 6:38 PM, Alexey Ushakov wrote:
>> Hello,
>>
>> Here is a fix of the regression caused by JDK-8225118. Please, have a 
>> look.
>> I've moved resolving gdk_window_get_scale_factor symbol under gtk 
>> version check as was suggested in the comments.
>>
>> Webrev: http://cr.openjdk.java.net/~avu/JDK-8226654/webrev.00 
>> <http://cr.openjdk.java.net/%7Eavu/JDK-8226654/webrev.00>
>>
>> Best Regards,
>> Alexey
>

[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Looks ok to me too, but I think awt-dev (added) is the most
    appropriate<br>
    email list since this is AWT Robot code.<br>
    <br>
    -phil.<br>
    <br>
    On 7/5/19, 1:51 AM, Prasanta Sadhukhan wrote:
    <blockquote
      cite="mid:0b47babe-1869-4372-6150-4826230ff566@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <p>looks ok to me but the review should have been done in
        swing-dev alias.<br>
      </p>
      Regards<br>
      Prasanta<br>
      <div class="moz-cite-prefix">On 04-Jul-19 6:38 PM, Alexey Ushakov
        wrote:<br>
      </div>
      <blockquote type="cite"
        cite="mid:FDDE3E69-E294-4DA9-9479-4596B2B05400@jetbrains.com">
        <meta http-equiv="Content-Type" content="text/html;
          charset=UTF-8">
        Hello,
        <div class=""><br class="">
        </div>
        <div class="">Here is a fix of the regression caused
          by  JDK-8225118. Please, have a look.  </div>
        <div class="">I've moved resolving  gdk_window_get_scale_factor
          symbol under gtk version check as was suggested in the
          comments.</div>
        <div class=""><br class="">
        </div>
        <div class="">Webrev:  <a
            href="http://cr.openjdk.java.net/%7Eavu/JDK-8226654/webrev.00"
            class="" \
moz-do-not-send="true">http://cr.openjdk.java.net/~avu/JDK-8226654/webrev.00</a></div>
  <div class=""><br class="">
        </div>
        <div class="">Best Regards,</div>
        <div class="">Alexey</div>
      </blockquote>
      <br>
    </blockquote>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic