[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2019-06-07 21:43:49
Message-ID: d409928d-c236-dae6-e10d-fb74d35bf50c () oracle ! com
[Download RAW message or body]

Looks fine.

On 07/06/2019 01:08, Prasanta Sadhukhan wrote:
> Modified webrev http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.1/
> 
> to use @link for cases where it points to public class/API.   For \
> Font/FontMetrics/DocFlavor, the link was pointing to some heading and not to any \
> API, where @link was not working so kept <a href> for those cases. 
> Regards
> Prasanta
> On 07-Jun-19 6:16 AM, Jonathan Gibbons wrote:
> > You should be able to link to public API in other modules.
> > 
> > There was an issue with hard-coded '<a href=...>` links when javadoc added the \
> > extra level of module directory into the output hierarchy, but those issues have \
> > now been sorted out. 
> > -- Jon
> > 
> > On 06/06/2019 05:31 PM, Sergey Bylokhov wrote:
> > > On 06/06/2019 12:50, Jonathan Gibbons wrote:
> > > > You should be able to use {@link} to refer to other Java elements;
> > > 
> > > It is possible even across the different modules?(I remember there was some \
> > > related issue) 
> > > > 
> > > > -- Jon
> > > > 
> > > > 
> > > > On 06/06/2019 12:46 PM, Sergey Bylokhov wrote:
> > > > > Hi, Prasanta.
> > > > > 
> > > > > Can you please double check is it possible to use {@link } instead of <a/> \
> > > > > in the java files? For example in \
> > > > > src/java.desktop/share/classes/javax/print/attribute/package-info.java 
> > > > > Note that some of these docs use 80 chars per line alignment, please use \
> > > > > the same style. 
> > > > > On 06/06/2019 11:34, Prasanta Sadhukhan wrote:
> > > > > > Hi All,
> > > > > > 
> > > > > > Please review a doc-fix to fix broken links in java.desktop files
> > > > > > 
> > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8225368
> > > > > > 
> > > > > > webrev: http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.0/
> > > > > > 
> > > > > > Regards
> > > > > > Prasanta
> > > > > 
> > > > > 
> > > > 
> > > 
> > > 
> > 
> 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]