[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.ja
From:       Erik Joelsson <erik.joelsson () oracle ! com>
Date:       2019-05-28 13:36:20
Message-ID: c2ddca6f-e40d-e3dc-f47d-477b1e42189b () oracle ! com
[Download RAW message or body]

Looks good, thanks!

/Erik

On 2019-05-24 16:36, Philip Race wrote:
> No other comments so far so here's that update :
> http://cr.openjdk.java.net/~prr/8224778.1/
>
> -phil.
>
> On 5/24/19, 2:41 PM, Philip Race wrote:
>> Yes, I just copied that line + edited it.
>> I can update both lines if that is what you are asking but I'll wait 
>> a little to see
>> if there are any other comments first.
>>
>> -phil.
>>
>> On 5/24/19, 2:16 PM, Erik Joelsson wrote:
>>> Hello Phil,
>>>
>>> Patch looks good, but the curly braces look weird in a makefile. I 
>>> see the line below which you probably emulated also uses them, but 
>>> they really should just be normal braces.
>>>
>>> /Erik
>>>
>>> On 2019-05-24 14:03, Phil Race wrote:
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8224778
>>>> webrev : http://cr.openjdk.java.net/~prr/8224778/
>>>>
>>>> With this fix the test can find the demo jar in its traditional 
>>>> place as before,
>>>> and now also where it is placed by JIB to be invoked from RunTests.gmk
>>>>
>>>> -phil
>>>>
[prev in list] [next in list] [prev in thread] [next in thread]