[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts for East Asian countries cannot belong to Composit
From: "Toshio 5 Nakamura" <TOSHIONA () jp ! ibm ! com>
Date: 2019-05-20 12:20:53
Message-ID: OF1F78C86C.501D3165-ON00258400.00415662-00258400.0043D49E () notes ! na ! collabserv ! com
[Download RAW message or body]
<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, \
sans-serif;font-size:9pt" ><div dir="ltr" ><div>Hi phil,</div> <div> </div>
<div>Do you have chance to check this proposal again?</div>
<div> </div>
<div>To relieve your worry, I tested all locales additionally with<br>Ubuntu16.04, \
18.04, RHEL7, 8, and CentOS7. There were<br>many improvements.</div> \
<div> </div> <div>But, acutually, this testcase in the proposal detected \
two</div> <div>other issues. I believe the root causes are different, and</div>
<div>they can be treated separately. Details are in the bug DB.</div>
<div> </div>
<div>By the way, Noto CJK fonts v2.001 [1] seems to change<br>their fullname to the \
same one as familyname. So, this problem</div> <div>doesn't exist with the new \
version.</div> <div> </div>
<div>Anyway, since many distributions still use Noto CJK fonts v1.001,<br>I believe \
this proposal is still useful.</div> <div> </div>
<div>[1] <a href="https://github.com/googlefonts/noto-cjk">https://github.com/googlefonts/noto-cjk</a><br>JBS: \
<a href="https://bugs.openjdk.java.net/browse/JDK-8219901">https://bugs.openjdk.java.net/browse/JDK-8219901</a><br>Webrev.02: \
<a href="http://cr.openjdk.java.net/~tnakamura/8219901/webrev.02/">http://cr.openjdk.java.net/~tnakamura/8219901/webrev.02/</a></div>
<div> </div>
<div>Thanks,<br>Toshio Nakamura</div></div>
<div dir="ltr" > </div>
<blockquote dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; \
padding-left:5px; direction:ltr; margin-right:0px" >----- Original message \
-----<br>From: "Toshio 5 Nakamura" <TOSHIONA@jp.ibm.com><br>Sent by: "2d-dev" \
<2d-dev-bounces@openjdk.java.net><br>To: philip.race@oracle.com<br>Cc: \
2d-dev@openjdk.java.net<br>Subject: Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts \
for East Asian countries cannot belong to CompositeFont<br>Date: Tue, Apr 30, 2019 \
7:58 PM<br> <div dir="ltr" style="font-family:Arial, Helvetica, \
sans-serif;font-size:9pt" ><div dir="ltr" >Hi Phil,</div> <div dir="ltr" \
><div> </div> <div>Thank you so much for the review and pointing out.</div>
<div> </div>
<div>I updated the webrev to cover non-English results by testcase side.</div>
<div> </div>
<div>Additionally, I need another fix in \
FcFontConfiguration.java.<br>From internationalization view point, we need to \
tell zh_CN and zh_TW,<br>and fcinfo's file name requires not only language but \
also country.</div> <div> </div>
<div>I tested this with major locales under Ubuntu 16.04, 18.04, CentOS 7,<br>RHEL7 \
and 8beta.</div> <div> </div>
<div>Could you kindly review this again?<br><a \
href="http://cr.openjdk.java.net/~tnakamura/8219901/webrev.02/" \
target="_blank">http://cr.openjdk.java.net/~tnakamura/8219901/webrev.02/</a></div> \
<div> </div> <div>Thanks,<br>Toshio Nakamura</div></div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid \
#aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" \
>----- Original message -----<br>From: Phil Race \
> <philip.race@oracle.com><br>To: Toshio 5 Nakamura \
> <TOSHIONA@jp.ibm.com>, jayathirth.d.v@oracle.com<br>Cc: \
> 2d-dev@openjdk.java.net<br>Subject: Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto \
> fonts for East Asian countries cannot belong to CompositeFont<br>Date: Fri, Apr 26, \
> 2019 7:26 AM<br> <br><!--Notes ACF
<meta http-equiv="Content-Type" content="text/html; charset=utf8" >--> The test fails \
for me when I set the Japanese locale. I am using Ubuntu 16.04.<br>Have you done any \
locale testing ?<br><br>env|grep \
LANG<br>LANG=ja_JP.UTF-8<br>GDM_LANG=ja_JP<br>LANGUAGE=ja_JP.UTF-8<br> $ \
~/jdk-client/build/linux-x86_64-server-release/jdk/bin/java \
FCCompositeTest<br>PF=Noto Sans Mono CJK JP Regular<br>FC=Noto Sans Mono CJK JP \
Regular<br>PF=TakaoPGothic<br>FC=Takao P????????????<br>java.lang.RuntimeException: \
FullName mismatch: TakaoPGothic,Takao P????????????<br> at \
FCCompositeTest.test(FCCompositeTest.java:92)<br> at \
FCCompositeTest.main(FCCompositeTest.java:52)<br>Exception in thread "main" \
java.lang.RuntimeException: Method invocation exception<br> at \
FCCompositeTest.test(FCCompositeTest.java:97)<br> at \
FCCompositeTest.main(FCCompositeTest.java:52)<br><br>-phil.<br> <div>On 4/23/19 \
3:14 AM, Toshio 5 Nakamura wrote:</div> <blockquote \
cite="mid:OF269623C6.FA612F0C-ON002583E5.0037F5F5-002583E5.00384C2B@notes.na.collabserv.com" \
type="cite" ><!--Notes ACF <meta http-equiv="content-type" content="text/html; \
charset=utf8" >--> <div dir="ltr" style="font-family:Arial, Helvetica, \
sans-serif;font-size:9pt" ><div dir="ltr" ><div>I apologize if my poor description \
caused confusion.</div> <div> </div>
<div>Hi Jay,<br>Thank you so much for your review.</div>
<div> </div>
<div>Hi phil,<br>I'm looking forward to hearing your results.<br>Noto font is \
expected to be used more widely, and I'm eager to fix this problem.<br>I welcome \
any suggestions or comments.</div> <div> </div>
<div>Thanks,<br>Toshio Nakamura</div></div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid \
#aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; \
margin-right:0px" >----- Original message -----<br>From: Jayathirth Rao <a \
href="mailto:jayathirth.d.v@oracle.com" \
target="_blank"><jayathirth.d.v@oracle.com></a><br>To: Toshio 5 Nakamura <a \
href="mailto:TOSHIONA@jp.ibm.com" \
target="_blank"><TOSHIONA@jp.ibm.com></a><br>Cc: Philip Race <a \
href="mailto:philip.race@oracle.com" \
target="_blank"><philip.race@oracle.com></a>, <a \
href="mailto:2d-dev@openjdk.java.net" \
target="_blank">2d-dev@openjdk.java.net</a><br>Subject: Re: [OpenJDK 2D-Dev] [13] \
JDK-8219901: Noto fonts for East Asian countries cannot belong to \
CompositeFont<br>Date: Tue, Apr 9, 2019 3:26 PM<br> <br><!--Notes ACF <meta \
http-equiv="Content-Type" content="text/html; charset=utf8" >--> <div><font \
face="Default Monospace,Courier New,Courier,monospace" size="2" ><span \
style="font-size: 9pt; white-space: normal;" ><font face="Helvetica" \
>Hi,</font></span></font> <div style="font-size: 9pt; white-space: normal;" \
> > </div>
<div style="font-size: 9pt; white-space: normal;" ><font face="Default \
Monospace,Courier New,Courier,monospace" size="2" ><font \
face="Helvetica" >(Ignore the previous mail received with less \
info)</font></font></div> <div style="font-size: 9pt; white-space: normal;" \
> </div> <div style="font-size: 9pt; white-space: normal;" ><font face="Default \
> Monospace,Courier New,Courier,monospace" size="2" ><font \
> face="Helvetica" >Observations:</font></font></div>
<div><font face="Default Monospace,Courier New,Courier,monospace" \
size="2" ><font face="Helvetica" ><span style="font-size: 9pt; white-space: normal;" \
>I went through different FontConfiguration & FontManager implementations \
> and </span><span style="white-space: normal;" >I</span><span style="font-size: \
> 9pt; white-space: normal;" > see that in case of fontConfig(linux) only \
> we</span><span style="white-space: normal;" > are encoding/decoding \
> CompositeFonts in a unique way(In case of font config we \
> override </span></font><span style="font-family: Helvetica; white-space: \
> normal;" >get2DCompositeFontInfo()</span><span style="white-space: normal;" ><font \
> face="Helvetica" >). For other platforms we use </font><font face="Menlo" \
> >parent </font></span><span style="font-family: Helvetica; white-space: \
> > normal;" >get2DCompositeFontInfo() where we are populating face names \
> > using </span><font face="Menlo" ><span style="font-size: 9pt;" \
> > >getFaceNameFromComponentFontName().</span></font></font></div>
<div> </div>
<div><font face="Default Monospace,Courier New,Courier,monospace" \
size="2" ><font face="Helvetica" ><span style="font-size: 9pt; white-space: normal;" \
>Also </span><span style="font-size: 9pt; white-space: normal;" \
> >getDefaultPlatformFont() returns predetermined face names in case of Windows and \
> > Mac.</span></font></font></div>
<div> </div>
<div><font face="Default Monospace,Courier New,Courier,monospace" \
size="2" ><font face="Helvetica" >For Linux changes made in FontConfiguration and \
FontManager looks fine.</font></font></div> <div> </div>
<div><font face="Default Monospace,Courier New,Courier,monospace" \
size="2" ><font face="Helvetica" >Thanks,</font></font></div> <div><font \
face="Default Monospace,Courier New,Courier,monospace" size="2" ><font \
face="Helvetica" >Jay</font></font></div> <div> </div>
<div> </div></div>
<div><blockquote type="cite" ><div>On 04-Apr-2019, at 6:14 PM, Toshio 5 Nakamura \
<<a href="mailto:TOSHIONA@jp.ibm.com" moz-do-not-send="true" \
target="_blank">TOSHIONA@jp.ibm.com</a>> wrote:</div>
<div><div dir="ltr" style="font-family:Arial, Helvetica, \
sans-serif;font-size:9pt" ><div dir="ltr" >Hi phil, Jay,</div> <div dir="ltr" \
> </div> <div dir="ltr" >Thank you for taking your time to review this \
> patch.</div>
<div dir="ltr" > </div>
<div dir="ltr" >Thanks,</div>
<div dir="ltr" >Toshio Nakamura</div>
<blockquote data-history-content-modified="1" data-history-expanded="1" dir="ltr" \
style="border-left:solid #aaaaaa 2px; margin-left:5px; \
padding-left:5px; direction:ltr; margin-right:0px" >----- Original \
message -----<br>From: Jayathirth Rao <<a href="mailto:jayathirth.d.v@oracle.com" \
moz-do-not-send="true" target="_blank">jayathirth.d.v@oracle.com</a>><br>To: <a \
href="mailto:TOSHIONA@jp.ibm.com" moz-do-not-send="true" \
target="_blank">TOSHIONA@jp.ibm.com</a><br>Cc: 2d-dev <<a \
href="mailto:2d-dev@openjdk.java.net" moz-do-not-send="true" \
target="_blank">2d-dev@openjdk.java.net</a>><br>Subject: Re: [OpenJDK 2D-Dev] [13] \
JDK-8219901: Noto fonts for East Asian countries cannot belong to \
CompositeFont<br>Date: Thu, Apr 4, 2019 8:43 PM<br> <br><!--Notes ACF <meta \
http-equiv="Content-Type" content="text/html; charset=utf8" >-->Hi, <div> </div>
<div>I am also taking a look at this.</div>
<div>I will update my observations soon.</div>
<div> </div>
<div>Thanks,</div>
<div>Jay</div>
<div><div>
<blockquote type="cite" ><div>On 04-Apr-2019, at 8:23 AM, Philip Race <<a \
href="mailto:philip.race@oracle.com" moz-do-not-send="true" \
target="_blank">philip.race@oracle.com</a>> wrote:</div>
<div><!--Notes ACF
<meta content="text/html; charset=utf8" http-equiv="Content-Type" class="" >-->
<div bgcolor="#FFFFFF" text="#000000" >I will get back to this soon but you will \
still need a 2nd reviewer.<br><br>-phil.<br><br>On 3/25/19, 12:29 AM, Toshio 5 \
Nakamura wrote: <blockquote \
cite="mid:OF8B118B83.17979021-ON002583C8.00286DD1-002583C8.002930A9@notes.na.collabserv.com" \
type="cite" ><div dir="ltr" style="font-family:Arial, \
Helvetica, sans-serif;font-size:9pt" ><div dir="ltr" >Hi Phil,</div> <div dir="ltr" \
> </div> <div dir="ltr" >Just a gentle reminder, I appreciate it if you have a \
> time to look at this.</div>
<div dir="ltr" > </div>
<div dir="ltr" >Thanks,</div>
<div dir="ltr" >Toshio Nakamura</div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid \
#aaaaaa 2px; margin-left:5px; padding-left:5px; \
direction:ltr; margin-right:0px" >----- Original \
message -----<br>From: "Toshio 5 Nakamura" <a href="mailto:TOSHIONA@jp.ibm.com" \
moz-do-not-send="true" target="_blank"><TOSHIONA@jp.ibm.com></a><br>Sent by: \
"2d-dev" <a href="mailto:2d-dev-bounces@openjdk.java.net" moz-do-not-send="true" \
target="_blank"><2d-dev-bounces@openjdk.java.net></a><br>To: Philip Race <a \
href="mailto:philip.race@oracle.com" moz-do-not-send="true" \
target="_blank"><philip.race@oracle.com></a><br>Cc: 2d-dev <a \
href="mailto:2d-dev@openjdk.java.net" moz-do-not-send="true" \
target="_blank"><2d-dev@openjdk.java.net></a><br>Subject: Re: [OpenJDK 2D-Dev] \
[13] JDK-8219901: Noto fonts for East Asian countries cannot belong to \
CompositeFont<br>Date: Mon, Mar 11, 2019 9:58 PM <p><font size="2" >Hi \
Phil,</font><br><br><font size="2" >Thank you so much for your \
reviewing.</font><br><br><font size="2" >Yes, "family" part can be removed with a few \
changes in</font><br><font size="2" \
>"src/java.desktop/unix/classes/sun/awt/FcFontManager.java".</font><br><br><font \
> size="2" >The updated webrev is:</font><br><font size="2" ><a \
> href="http://cr.openjdk.java.net/%7Etnakamura/8219901/webrev.01" \
> moz-do-not-send="true" \
> target="_blank">http://cr.openjdk.java.net/~tnakamura/8219901/webrev.01</a>/</font><br><br><tt><font \
> face="" size="3" >> So you don't need to clean everything - just your \
> develop -internal<br>> and -ea folders.</font></tt><br><font size="2" >Yes, \
> thank you for the clarification.</font><br><br><font size="2" \
> >Thanks,</font><br><font size="2" >Toshio Nakamura</font><br><br><tt><font face="" \
> > size="3" >Philip Race <a href="mailto:philip.race@oracle.com" \
> > moz-do-not-send="true" target="_blank"><philip.race@oracle.com></a> wrote \
> > on 2019/03/10 18:05:18:<br><br>> From: Philip Race <a \
> > href="mailto:philip.race@oracle.com" moz-do-not-send="true" \
> > target="_blank"><philip.race@oracle.com></a></font></tt><br><tt><font \
> > face="" size="3" >> To: Toshio 5 Nakamura <a href="mailto:TOSHIONA@jp.ibm.com" \
> > moz-do-not-send="true" \
> > target="_blank"><TOSHIONA@jp.ibm.com></a></font></tt><br><tt><font face="" \
> > size="3" >> Cc: 2d-dev <a href="mailto:2d-dev@openjdk.java.net" \
> > moz-do-not-send="true" \
> > target="_blank"><2d-dev@openjdk.java.net></a></font></tt><br><tt><font \
> > face="" size="3" >> Date: 2019/03/10 18:05</font></tt><br><tt><font face="" \
> > size="3" >> Subject: Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts for \
> > East<br>> Asian countries cannot belong to \
> > CompositeFont</font></tt><br><tt><font face="" size="3" >><br>> I can \
> > sponsor this but first :<br>><br>> You seem to have made "family" redundant \
> > but aren't removing it.<br>> There's no point in writing it out if nothing \
> > uses it on reading.<br>> So we should remove it unless you can explain why you \
> > think it should be kept.<br>><br>> I don't think this (removing it) is a \
> > problem for backports or<br>> compatibility of the<br>> format since \
> > release name is part of the file name where we write<br>> the \
> > information,<br>> and such a file name will necessarily be a consequence of a \
> > feature<br>> or update release<br>> containing this fix.<br>><br>> \
> > Where it might be an issue is testing on 13-ea builds since they all \
> > report<br>> that as the version string so for testing you may need to clean \
> > out your<br>> ~/.java/fonts/13-ea folder. The same is for your 13-internal \
> > private builds.<br>><br>> I think this is your point when you wrote \
> > :-<br>><br>>> The cached font list is stored under ~/.java/fonts \
> > directory.<br>>> We should delete it before applying the \
> > fix.<br>><br>> So you don't need to clean everything - just your \
> > develop -internal<br>> and -ea folders.<br>><br>> Meanwhile I tested it \
> > .. and it seemed OK but I am still trying to join<br>> up all the dots to make \
> > sure it is all correct code-wise.<br>><br>> -phil<br>><br>> On \
> > 2/28/19, 3:21 PM, Toshio 5 Nakamura wrote: </font></tt><br><tt><font face="" \
> > size="3" >> Hi,<br>><br>> Could you review the fix and may I have a \
> > sponsor for it?<br>><br>> Bug: <a \
> > href="https://bugs.openjdk.java.net/browse/JDK-8219901" moz-do-not-send="true" \
> > target="_blank">https://bugs.openjdk.java.net/browse/JDK-8219901</a><br>> \
> > Webrev: <a href="http://cr.openjdk.java.net/%7Etnakamura/8219901/webrev.00/" \
> > moz-do-not-send="true" \
> > target="_blank">http://cr.openjdk.java.net/~tnakamura/8219901/webrev.00/</a><br>><br>> \
> > Issue:<br>> Even if Google Noto fonts[1] were installed and listed by \
> > fontconfig library<br>> on Linux, CompositeFont couldn't contain \
> > it.<br>><br>> Fix description:<br>> \
> > "src/java.desktop/share/classes/sun/font/CompositeFont.java" (l. 296)<br>> \
> > validates the target font by comparing names. But, the current code<br>> \
> > compared FamilyName with FullName (Font.getFontName()).<br>> Then, Noto font \
> > was treated as invalid.<br>> \
> > "src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java"<br>> should \
> > provide FullName.<br>><br>> The cached font list is stored under \
> > ~/.java/fonts directory.<br>> We should delete it before applying the \
> > fix.<br>><br>> This fix is possible to change the default font, if \
> > CompositeFont<br>> is used (especially under Ubuntu18.04 and East Asian \
> > settings).<br>> But, I believe the fixed behavior is correct.<br>><br>> \
> > [1] <a href="https://www.google.com/get/noto/" moz-do-not-send="true" \
> > target="_blank">https://www.google.com/get/noto/</a><br>><br>> \
> > Thanks,<br>> Toshio Nakamura</font></tt></p></blockquote>
<div dir="ltr" > </div></div></blockquote></div></div></blockquote></div></div></blockquote>
<div dir="ltr" > </div></div></div></blockquote></div></blockquote>
<div dir="ltr" > </div></div></blockquote></blockquote>
<div dir="ltr" > </div></div></blockquote>
<div dir="ltr" > </div></div><BR>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic