[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to us
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2019-03-29 20:35:31
Message-ID: 71919cfa-6c7d-d908-2fad-319a9b714c37 () oracle ! com
[Download RAW message or body]

But it looks like an overkill to wait 8 minutes for one test, isn't it?
Probably we can force the less timeout by the "sun.java2d.print.minRefreshTime"?

On 29/03/2019 08:28, Alexey Ivanov wrote:
> Please take a look at the updated webrev where I've removed @ignore tag from the \
> test: http://cr.openjdk.java.net/~aivanov/8221263/webrev.1/
> 
> On 29/03/2019 01:09, Philip Race wrote:
> > Are you looking for a reason other than that the implementation
> > is set to refresh the printer list every 4 minutes ?
> 
> Yes, remote printer list is refreshed every 4 minutes on Windows.
> 
> The reason why I added step 6 is that the user has no way of knowing when the \
> refresh occurred. The refresh could happen just before the printer is added. \
> Waiting for another refresh is to prevent false failures. If the list isn't updated \
> in two refresh cycles, likely it won't be updated. In this case, the user will \
> click Fail. 
> Regards,
> Alexey
> 
> > 
> > -phil.
> > 
> > 
> > On 3/28/19, 5:52 PM, Sergey Bylokhov wrote:
> > > Hi, Alexey.
> > > 
> > > I think it is ok to drop @ignore tag, but I wonder why did you add the step6 to \
> > > the instruction. 197                                         +                  \
> > > "updated.\n" 198                                         + "Step 6: If the list \
> > > is not updated, wait for another " 199                                         \
> > > +                   "4 minutes, and then click Refresh again.\n" 
> > > On 28/03/2019 09:07, Alexey Ivanov wrote:
> > > > Hi,
> > > > 
> > > > Please review the following fix for jdk 13:
> > > > 
> > > > bug: https://bugs.openjdk.java.net/browse/JDK-8221263
> > > > webrev: http://cr.openjdk.java.net/~aivanov/8221263/webrev.0/
> > > > 
> > > > This is a complete re-write of the test.
> > > > 
> > > > It's semi-automatic: the tester is to add or remove a remote printer and to \
> > > > make sure the change is reflected in the list of printers returned from \
> > > > PrintServiceLookup.lookupPrintServices(null, null). Added or removed printers \
> > > > are highlighted in the "Before" and "After" lists. 
> > > > I've attached the screenshots to the JBS issue.
> > > > 
> > > > I'm adding 8221263 and 8221412 to @bug tag.
> > > > 
> > > > 
> > > > Shall I remove @ignore tag from the test? If it's there, jtreg does not start \
> > > > the test, likely it will never be run. 
> > > > Thank you in advance.
> > > > 
> > > > Regards,
> > > > Alexey 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]