[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] Request for Sponsor: 8217735: awt_image_GifImageDecoder_parseImage() "interlace
From: Andrew Leonard <andrew_m_leonard () uk ! ibm ! com>
Date: 2019-03-28 14:49:45
Message-ID: OFDB5AD58A.5E067AA2-ON002583CB.00515F3A-802583CB.005175C0 () notes ! na ! collabserv ! com
[Download RAW message or body]
This is a multipart message in MIME format.
--=_alternative 00517502802583CB_=
Content-Type: text/plain; charset="US-ASCII"
Thank you for merging :-)
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leonard@uk.ibm.com
From: Jayathirth Rao <jayathirth.d.v@oracle.com>
To: Andrew Leonard <andrew_m_leonard@uk.ibm.com>
Cc: 2d-dev@openjdk.java.net
Date: 27/03/2019 12:59
Subject: Re: [OpenJDK 2D-Dev] Request for Sponsor: 8217735:
awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong
type
Hi Andrew,
Thanks for your contribution.
I would be happy to sponsor this change.
May be J9 by default has tighter checks for JNI parameter types or
-XCheck:jni option(https://www.eclipse.org/openj9/docs/xcheck/) is enabled
while running Swingset demo.
I think if we enable non-standard option -XCheck:jni in hotspot(
https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html#BABHDABI
) we might see similar issue.
I think there is no need for regression test for this case and I will just
add a label in bug.
Change looks good to me.
Thanks,
Jay
On 27-Mar-2019, at 5:00 PM, Andrew Leonard <andrew_m_leonard@uk.ibm.com>
wrote:
Thanks Prasanta, moving to 2d-dev maillist...
Hi,
Please can I obtain a sponsor for this simple fix to correct the
parseImage() jni parameter type?
https://bugs.openjdk.java.net/browse/JDK-8217735
http://cr.openjdk.java.net/~aleonard/8217735/webrev.00/
The problem manifests itself most notably with OpenJ9 when running the
SwingSet2 demo, depending on how the stack byte alignment resolves
iteself.
I've not seen an issue yet running SwingSet2 with Hotspot, possibly by
luck of stack alignment.
Many thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leonard@uk.ibm.com
From: Prasanta Sadhukhan <prasanta.sadhukhan@oracle.com>
To: Andrew Leonard <andrew_m_leonard@uk.ibm.com>,
awt-dev@openjdk.java.net
Date: 27/03/2019 09:57
Subject: Re: <AWT Dev> Request for Sponsor: 8217735:
awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong
type
I can sponsor this...But I guess this review should be going to 2d-dev
instead of awt-dev.
Regards
Prasanta
On 27-Mar-19 1:12 AM, Andrew Leonard wrote:
Hi,
Please can I obtain a sponsor for this simple fix to correct the
parseImage() jni parameter type?
https://bugs.openjdk.java.net/browse/JDK-8217735
http://cr.openjdk.java.net/~aleonard/8217735/webrev.00/
The problem manifests itself most notably with OpenJ9 when running the
SwingSet2 demo, depending on how the stack byte alignment resolves
iteself.
I've not seen an issue yet running SwingSet2 with Hotspot, possibly by
luck of stack alignment.
Many thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leonard@uk.ibm.com
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
--=_alternative 00517502802583CB_=
Content-Type: text/html; charset="US-ASCII"
Content-Transfer-Encoding:
X-Proofpoint-UnRewURL: 6 URL's were un-rewritten
<font size=2 face="sans-serif">Thank you for merging :-)</font>
<br>
<br><font size=3>Andrew Leonard<br>
Java Runtimes Development<br>
IBM Hursley<br>
IBM United Kingdom Ltd<br>
Phone internal: 245913, external: 01962 815913<br>
internet email: andrew_m_leonard@uk.ibm.com </font>
<br>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Jayathirth Rao \
<jayathirth.d.v@oracle.com></font> <br><font size=1 color=#5f5f5f \
face="sans-serif">To: </font><font size=1 \
face="sans-serif">Andrew Leonard <andrew_m_leonard@uk.ibm.com></font> <br><font \
size=1 color=#5f5f5f face="sans-serif">Cc: </font><font \
size=1 face="sans-serif">2d-dev@openjdk.java.net</font> <br><font size=1 \
color=#5f5f5f face="sans-serif">Date: </font><font size=1 \
face="sans-serif">27/03/2019 12:59</font> <br><font size=1 color=#5f5f5f \
face="sans-serif">Subject: </font><font size=1 \
face="sans-serif">Re: [OpenJDK 2D-Dev] Request for Sponsor: 8217735: \
awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong \
type</font> <br>
<hr noshade>
<br>
<br>
<br><font size=3>Hi Andrew,</font>
<br>
<br><font size=3>Thanks for your contribution.</font>
<br><font size=3>I would be happy to sponsor this change.</font>
<br>
<br><font size=3>May be J9 by default has tighter checks for JNI parameter
types or -XCheck:jni option(</font><a \
href="https://www.eclipse.org/openj9/docs/xcheck/"><font size=3 \
color=blue><u>https://www.eclipse.org/openj9/docs/xcheck/</u></font></a><font \
size=3>) is enabled while running Swingset demo.</font>
<br>
<br><font size=3>I think if we enable non-standard option -XCheck:jni in
hotspot(</font><a href="https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html#BABHDABI"><font \
size=3 color=blue><u>https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html#BABHDABI</u></font></a><font \
size=3>) we might see similar issue.</font>
<br>
<br><font size=3>I think there is no need for regression test for this
case and I will just add a label in bug.</font>
<br><font size=3>Change looks good to me.</font>
<br>
<br><font size=3>Thanks,</font>
<br><font size=3>Jay</font>
<br>
<br><font size=3>On 27-Mar-2019, at 5:00 PM, Andrew Leonard <</font><a \
href="mailto:andrew_m_leonard@uk.ibm.com"><font size=3 \
color=blue><u>andrew_m_leonard@uk.ibm.com</u></font></a><font size=3>> \
wrote:</font> <br>
<br><font size=2 face="sans-serif">Thanks Prasanta, moving to 2d-dev \
maillist...</font><font size=3> </font><font size=2 face="sans-serif"><br>
Hi,</font><font size=3> </font><font size=2 face="sans-serif"><br>
Please can I obtain a sponsor for this simple fix to correct the parseImage()
jni parameter type?</font><font size=3> </font><font size=3 color=blue><u><br>
</u></font><a href="https://bugs.openjdk.java.net/browse/JDK-8217735"><font size=2 \
color=blue face="sans-serif"><u>https://bugs.openjdk.java.net/browse/JDK-8217735</u></font></a><font \
size=3> </font><font size=3 color=blue><u><br>
</u></font><a href="http://cr.openjdk.java.net/%7Ealeonard/8217735/webrev.00/"><font \
size=2 color=blue face="sans-serif"><u>http://cr.openjdk.java.net/~aleonard/8217735/webrev.00/</u></font></a><font \
size=3> </font><font size=2 face="sans-serif"><br>
<br>
The problem manifests itself most notably with OpenJ9 when running the
SwingSet2 demo, depending on how the stack byte alignment resolves \
iteself.</font><font size=3> </font><font size=2 face="sans-serif"><br>
I've not seen an issue yet running SwingSet2 with Hotspot, possibly by
luck of stack alignment.</font><font size=3> </font><font size=2 \
face="sans-serif"><br> <br>
Many thanks</font><font size=3> </font><font size=2 face="sans-serif"><br>
Andrew</font><font size=3> <br>
<br>
Andrew Leonard<br>
Java Runtimes Development<br>
IBM Hursley<br>
IBM United Kingdom Ltd<br>
Phone internal: 245913, external: 01962 815913<br>
internet </font><a href="mailto:andrew_m_leonard@uk.ibm.com"><font size=3 \
color=blue><u>email: andrew_m_leonard@uk.ibm.com</u></font></a><font size=3> <br>
<br>
<br>
<br>
</font><font size=1 color=#5f5f5f face="sans-serif"><br>
From: </font><font size=1 face="sans-serif">Prasanta
Sadhukhan <</font><a href="mailto:prasanta.sadhukhan@oracle.com"><font size=1 \
color=blue face="sans-serif"><u>prasanta.sadhukhan@oracle.com</u></font></a><font \
size=1 face="sans-serif">></font><font size=3> </font><font size=1 color=#5f5f5f \
face="sans-serif"><br>
To: </font><font size=1 face="sans-serif">Andrew
Leonard <</font><a href="mailto:andrew_m_leonard@uk.ibm.com"><font size=1 \
color=blue face="sans-serif"><u>andrew_m_leonard@uk.ibm.com</u></font></a><font \
size=1 face="sans-serif">>, </font><a href="mailto:awt-dev@openjdk.java.net"><font \
size=1 color=blue face="sans-serif"><u>awt-dev@openjdk.java.net</u></font></a><font \
size=3> </font><font size=1 color=#5f5f5f face="sans-serif"><br>
Date: </font><font size=1 face="sans-serif">27/03/2019
09:57</font><font size=3> </font><font size=1 color=#5f5f5f face="sans-serif"><br>
Subject: </font><font size=1 face="sans-serif">Re:
<AWT Dev> Request for Sponsor: 8217735: awt_image_GifImageDecoder_parseImage()
"interlace" param has the wrong type</font><font size=3> <br>
</font>
<hr noshade><font size=3><br>
<br>
<br>
I can sponsor this...But I guess this review should be going to 2d-dev
instead of awt-dev.</font>
<p><font size=3>Regards<br>
Prasanta <br>
On 27-Mar-19 1:12 AM, Andrew Leonard wrote: </font><font size=2 \
face="sans-serif"><br> Hi,</font><font size=3> </font><font size=2 \
face="sans-serif"><br> Please can I obtain a sponsor for this simple fix to correct \
the parseImage() jni parameter type?</font><font size=3> </font><font size=3 \
color=blue><u><br> </u></font><a \
href="https://bugs.openjdk.java.net/browse/JDK-8217735"><font size=2 color=blue \
face="sans-serif"><u>https://bugs.openjdk.java.net/browse/JDK-8217735</u></font></a><font \
size=3> </font><font size=3 color=blue><u><br>
</u></font><a href="http://cr.openjdk.java.net/%7Ealeonard/8217735/webrev.00/"><font \
size=2 color=blue face="sans-serif"><u>http://cr.openjdk.java.net/~aleonard/8217735/webrev.00/</u></font></a><font \
size=3> </font><font size=2 face="sans-serif"><br>
<br>
The problem manifests itself most notably with OpenJ9 when running the
SwingSet2 demo, depending on how the stack byte alignment resolves \
iteself.</font><font size=3> </font><font size=2 face="sans-serif"><br>
I've not seen an issue yet running SwingSet2 with Hotspot, possibly by
luck of stack alignment.</font><font size=3> </font><font size=2 \
face="sans-serif"><br> <br>
Many thanks</font><font size=3> </font><font size=2 face="sans-serif"><br>
Andrew</font><font size=3> <br>
<br>
Andrew Leonard<br>
Java Runtimes Development<br>
IBM Hursley<br>
IBM United Kingdom Ltd<br>
Phone internal: 245913, external: 01962 815913<br>
internet email: </font><a href="mailto:andrew_m_leonard@uk.ibm.com"><font size=3 \
color=blue><u>andrew_m_leonard@uk.ibm.com</u></font></a><font size=3> </font><font \
size=2 face="sans-serif"><br> <br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU</font><font size=3> <br>
<br>
</font><font size=2 face="sans-serif"><br>
<br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU</font>
<p>
<p>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>
--=_alternative 00517502802583CB_=--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic