[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts for East Asian countries cannot belong to Composit
From: "Toshio 5 Nakamura" <TOSHIONA () jp ! ibm ! com>
Date: 2019-03-25 7:29:54
Message-ID: OF8B118B83.17979021-ON002583C8.00286DD1-002583C8.002930A9 () notes ! na ! collabserv ! com
[Download RAW message or body]
<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, \
sans-serif;font-size:9pt" ><div dir="ltr" >Hi Phil,</div> <div dir="ltr" \
> </div> <div dir="ltr" >Just a gentle reminder, I appreciate it if you have a \
> time to look at this.</div>
<div dir="ltr" > </div>
<div class="mail-signature-container" dir="ltr" >Thanks,</div>
<div class="mail-signature-container" dir="ltr" >Toshio Nakamura</div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid \
#aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" \
>----- Original message -----<br>From: "Toshio 5 Nakamura" \
> <TOSHIONA@jp.ibm.com><br>Sent by: "2d-dev" \
> <2d-dev-bounces@openjdk.java.net><br>To: Philip Race \
> <philip.race@oracle.com><br>Cc: 2d-dev \
> <2d-dev@openjdk.java.net><br>Subject: Re: [OpenJDK 2D-Dev] [13] JDK-8219901: \
> Noto fonts for East Asian countries cannot belong to CompositeFont<br>Date: Mon, \
> Mar 11, 2019 9:58 PM<br>
<p><font size="2" >Hi Phil,</font><br><br><font size="2" >Thank you so much for your \
reviewing.</font><br><br><font size="2" >Yes, "family" part can be removed with a few \
changes in</font><br><font size="2" \
>"src/java.desktop/unix/classes/sun/awt/FcFontManager.java".</font><br><br><font \
> size="2" >The updated webrev is:</font><br><font size="2" ><a \
> href="http://cr.openjdk.java.net/~tnakamura/8219901/webrev.01" \
> target="_blank">http://cr.openjdk.java.net/~tnakamura/8219901/webrev.01</a>/</font><br><br><tt><font \
> face="" size="3" >> So you don't need to clean everything - just your \
> develop -internal<br>> and -ea folders.</font></tt><br><font size="2" >Yes, \
> thank you for the clarification.</font><br><br><font size="2" \
> >Thanks,</font><br><font size="2" >Toshio Nakamura</font><br><br><tt><font face="" \
> > size="3" >Philip Race <philip.race@oracle.com> wrote on 2019/03/10 \
> > 18:05:18:<br><br>> From: Philip Race \
> > <philip.race@oracle.com></font></tt><br><tt><font face="" size="3" >> \
> > To: Toshio 5 Nakamura <TOSHIONA@jp.ibm.com></font></tt><br><tt><font \
> > face="" size="3" >> Cc: 2d-dev \
> > <2d-dev@openjdk.java.net></font></tt><br><tt><font face="" size="3" >> \
> > Date: 2019/03/10 18:05</font></tt><br><tt><font face="" size="3" >> Subject: \
> > Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts for East<br>> Asian \
> > countries cannot belong to CompositeFont</font></tt><br><tt><font face="" \
> > size="3" >><br>> I can sponsor this but first :<br>><br>> You seem to \
> > have made "family" redundant but aren't removing it.<br>> There's no point in \
> > writing it out if nothing uses it on reading.<br>> So we should remove it \
> > unless you can explain why you think it should be kept.<br>><br>> I don't \
> > think this (removing it) is a problem for backports or<br>> compatibility of \
> > the<br>> format since release name is part of the file name where we \
> > write<br>> the information,<br>> and such a file name will necessarily be a \
> > consequence of a feature<br>> or update release<br>> containing this \
> > fix.<br>><br>> Where it might be an issue is testing on 13-ea builds since \
> > they all report<br>> that as the version string so for testing you may need to \
> > clean out your<br>> ~/.java/fonts/13-ea folder. The same is for your \
> > 13-internal private builds.<br>><br>> I think this is your point when you \
> > wrote :-<br>><br>>> The cached font list is stored under ~/.java/fonts \
> > directory.<br>>> We should delete it before applying the \
> > fix.<br>><br>> So you don't need to clean everything - just your \
> > develop -internal<br>> and -ea folders.<br>><br>> Meanwhile I tested it \
> > .. and it seemed OK but I am still trying to join<br>> up all the dots to make \
> > sure it is all correct code-wise.<br>><br>> -phil<br>><br>> On \
> > 2/28/19, 3:21 PM, Toshio 5 Nakamura wrote: </font></tt><br><tt><font face="" \
> > size="3" >> Hi,<br>><br>> Could you review the fix and may I have a \
> > sponsor for it?<br>><br>> Bug: <a \
> > href="https://bugs.openjdk.java.net/browse/JDK-8219901" \
> > target="_blank">https://bugs.openjdk.java.net/browse/JDK-8219901</a><br>> \
> > Webrev: <a href="http://cr.openjdk.java.net/~tnakamura/8219901/webrev.00/" \
> > target="_blank">http://cr.openjdk.java.net/~tnakamura/8219901/webrev.00/</a><br>><br>> \
> > Issue:<br>> Even if Google Noto fonts[1] were installed and listed by \
> > fontconfig library<br>> on Linux, CompositeFont couldn't contain \
> > it.<br>><br>> Fix description:<br>> \
> > "src/java.desktop/share/classes/sun/font/CompositeFont.java" (l. 296)<br>> \
> > validates the target font by comparing names. But, the current code<br>> \
> > compared FamilyName with FullName (Font.getFontName()).<br>> Then, Noto font \
> > was treated as invalid.<br>> \
> > "src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java"<br>> should \
> > provide FullName.<br>><br>> The cached font list is stored under \
> > ~/.java/fonts directory.<br>> We should delete it before applying the \
> > fix.<br>><br>> This fix is possible to change the default font, if \
> > CompositeFont<br>> is used (especially under Ubuntu18.04 and East Asian \
> > settings).<br>> But, I believe the fixed behavior is correct.<br>><br>> \
> > [1] <a href="https://www.google.com/get/noto/" \
> > target="_blank">https://www.google.com/get/noto/</a><br>><br>> \
> > Thanks,<br>> Toshio Nakamura</font></tt></p></blockquote>
<div dir="ltr" > </div></div><BR>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic