[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics
From:       Philip Race <philip.race () oracle ! com>
Date:       2019-02-27 15:20:52
Message-ID: 5C76AAD4.2020806 () oracle ! com
[Download RAW message or body]

The webrev still appears to be against jdk/jdk not jdk/client

I had suggested excluding small point sizes since I don't think
the failures I saw can possibly be limited to Solaris ... it just
hasn't been reproduced elsewhere yet.

-phil.

On 2/25/19, 9:06 PM, Martin Balao wrote:
> Hi,
>
> Here we have Webrev.03:
>
>   * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.03/
>
>   * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.03.zip
>
> Changes:
>
>   * Test moved to test/jdk/java/awt/FontMetrics
>
>   * Test imports are now explicit
>
>   * getAllFonts NPE handled
>
>   * Solaris excluded from test
>
>   * Serb added as a reviewer (commit message)
>
> Are we good to go?
>
> Thanks,
> Martin.-
[prev in list] [next in list] [prev in thread] [next in thread]