[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8
From: Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date: 2019-02-26 0:09:55
Message-ID: 23E2B148-4E63-4BC6-8F32-7627A9B02BC7 () oracle ! com
[Download RAW message or body]
Erik/Phil, thanks for the reviews. Change pushed!
I also filed https://bugs.openjdk.java.net/browse/JDK-8219676 \
<https://bugs.openjdk.java.net/browse/JDK-8219676> to cover re-enabling the warnings \
(effectively reverting this change) once harfbuzz has been upgraded.
Cheers,
Mikael
> On Feb 25, 2019, at 2:16 PM, Erik Joelsson <erik.joelsson@oracle.com> wrote:
>
> Looks good.
>
> /Erik
>
> On 2019-02-25 13:28, Mikael Vidstedt wrote:
> > Please review this change which (temporarily) disables two gcc warnings which are \
> > triggered by the harfbuzz code.
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8219675 \
> > <https://bugs.openjdk.java.net/browse/JDK-8219675>
> > webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/ \
> > <http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/>
> > This change disables the two warnings in question (missing-attributes and \
> > class-memaccess). An alternative would be to make changes to the harfbuzz code \
> > itself instead.
> > Passes tier1.
> >
> > Cheers,
> > Mikael
> >
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class=""><div class=""><br \
class=""></div>Erik/Phil, thanks for the reviews. Change pushed!<div class=""><br \
class=""></div><div class="">I also filed <a \
href="https://bugs.openjdk.java.net/browse/JDK-8219676" \
class="">https://bugs.openjdk.java.net/browse/JDK-8219676</a> to cover \
re-enabling the warnings (effectively reverting this change) once harfbuzz has been \
upgraded.</div><div class=""><br class=""></div><div class="">Cheers,</div><div \
class="">Mikael<br class=""><div><br class=""><blockquote type="cite" class=""><div \
class="">On Feb 25, 2019, at 2:16 PM, Erik Joelsson <<a \
href="mailto:erik.joelsson@oracle.com" class="">erik.joelsson@oracle.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Looks \
good.<br class=""><br class="">/Erik<br class=""><br class="">On 2019-02-25 13:28, \
Mikael Vidstedt wrote:<br class=""><blockquote type="cite" class="">Please review \
this change which (temporarily) disables two gcc warnings which are triggered by the \
harfbuzz code.<br class=""><br class="">JBS: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8219675" \
class="">https://bugs.openjdk.java.net/browse/JDK-8219675</a> <<a \
href="https://bugs.openjdk.java.net/browse/JDK-8219675" \
class="">https://bugs.openjdk.java.net/browse/JDK-8219675</a>><br class="">webrev: \
<a href="http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/" \
class="">http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/</a> \
<<a href="http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/" \
class="">http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/</a>><br \
class=""><br class="">This change disables the two warnings in question \
(missing-attributes and class-memaccess). An alternative would be to make changes to \
the harfbuzz code itself instead.<br class=""><br class="">Passes tier1.<br \
class=""><br class="">Cheers,<br class="">Mikael<br class=""><br \
class=""></blockquote></div></div></blockquote></div><br \
class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic