[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] FW: RFR : 8218965: aix: support xlclang++ in the compiler detection
From: Philip Race <philip.race () oracle ! com>
Date: 2019-02-20 1:35:36
Message-ID: 5C6CAEE8.9030708 () oracle ! com
[Download RAW message or body]
Fine with me.
-phil.
On 2/19/19, 4:10 AM, Doerr, Martin wrote:
>
> Hi Matthias,
>
> build has passed with this version. I think you can ship it.
>
> Best regards,
>
> Martin
>
> *From:*Baesken, Matthias
> *Sent:* Dienstag, 19. Februar 2019 09:57
> *To:* Philip Race <philip.race@oracle.com>
> *Cc:* 2d-dev@openjdk.java.net; Doerr, Martin <martin.doerr@sap.com>
> *Subject:* RE: [OpenJDK 2D-Dev] FW: RFR : 8218965: aix: support
> xlclang++ in the compiler detection
>
> Hello, for some reason a "c" (__ibmxlc__) was in my last webrev
> that does not belong there; the macro name is __ibmxl__ :
>
> 118 #elif !defined(HB_NO_MT) && defined(_AIX) && (defined(__IBMCPP__)
> > > defined(__ibmxl__))
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.2/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8218965.2/>
>
> >
>
> > If there's a hb release with it soon I can use that or I will try
> > to remember to re-apply it ...
>
> >
>
> Thanks for looking into it (and for trying to remember 😉 ) !
>
> Best regards, Matthias
>
> *From:*Philip Race <philip.race@oracle.com
> <mailto:philip.race@oracle.com>>
> *Sent:* Dienstag, 19. Februar 2019 01:18
> *To:* Baesken, Matthias <matthias.baesken@sap.com
> <mailto:matthias.baesken@sap.com>>
> *Cc:* 2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net>; Doerr,
> Martin <martin.doerr@sap.com <mailto:martin.doerr@sap.com>>
> *Subject:* Re: [OpenJDK 2D-Dev] FW: RFR : 8218965: aix: support
> xlclang++ in the compiler detection
>
> Yes .. I see that ...
> https://github.com/harfbuzz/harfbuzz/commit/5c2bb1de8de31fecf0dae2ef905b896e42d39f1d
>
> .. looks ok ..
> although I soon need to upgrade harfbuzz in JDK and the
> current release of 2.3.1 doesn't have that change.
>
> If there's a hb release with it soon I can use that or I will try
> to remember to re-apply it ...
>
> -phil.
>
> On 2/18/19, 7:08 AM, Baesken, Matthias wrote:
>
> FYI - this change
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.1/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8218965.1/>
>
> includes a small harfbuzz fix by Martin as well ; he fixed
> it as well in the upstream harfbuzz project .
>
> Best regards, Matthias
>
> *From:*Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
> <mailto:magnus.ihse.bursie@oracle.com>
> *Sent:* Montag, 18. Februar 2019 15:46
> *To:* Doerr, Martin <martin.doerr@sap.com>
> <mailto:martin.doerr@sap.com>
> *Cc:* Baesken, Matthias <matthias.baesken@sap.com>
> <mailto:matthias.baesken@sap.com>; build-dev@openjdk.java.net
> <mailto:build-dev@openjdk.java.net>
> *Subject:* Re: RFR : 8218965: aix: support xlclang++ in the
> compiler detection
>
> Looks good to me.
>
> /Magnus
>
>
> 18 feb. 2019 kl. 15:37 skrev Doerr, Martin <martin.doerr@sap.com
> <mailto:martin.doerr@sap.com>>:
>
> Hi Matthias,
>
> excellent. Looks good to me. This should make AIX ready for
> JEP 347.
>
> Thanks
>
> Martin
>
> *From:*Baesken, Matthias
> *Sent:* Montag, 18. Februar 2019 13:53
> *To:* Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com
> <mailto:magnus.ihse.bursie@oracle.com>>;
> 'build-dev@openjdk.java.net
> <mailto:build-dev@openjdk.java.net>'
> <build-dev@openjdk.java.net <mailto:build-dev@openjdk.java.net>>
> *Cc:* Doerr, Martin <martin.doerr@sap.com
> <mailto:martin.doerr@sap.com>>
> *Subject:* RE: RFR : 8218965: aix: support xlclang++ in the
> compiler detection
>
> Hello Martin and Magnus,
>
> I included Martin's harfbuzz fix and adjusted the xlc
> version check ( renamed variable to XLC_USES_CLANG and also
> check the *TOOLCHAIN_PATH ) .*
>
> >
>
> > If we're talking about a short migration story, where soon XLC
> 16 will be required, and we can just replace
>
> > TOOLCHAIN_CC_BINARY_xlc="xlc_r"
>
> > with
>
> > TOOLCHAIN_CC_BINARY_xlc="xlclang"
>
> > then I can accept it anyway, so we don't need to complicate
> things.
> >
>
> Yes , that's the idea - to do the replacement above sooner
> or later ; depends of course also on the introduction of the
> C++11/14 features in the code base .
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.1/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8218965.1/>
>
> Best Regards, Matthias
>
> *From:*Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com
> <mailto:magnus.ihse.bursie@oracle.com>>
> *Sent:* Montag, 18. Februar 2019 11:18
> *To:* Baesken, Matthias <matthias.baesken@sap.com
> <mailto:matthias.baesken@sap.com>>;
> 'build-dev@openjdk.java.net
> <mailto:build-dev@openjdk.java.net>'
> <build-dev@openjdk.java.net <mailto:build-dev@openjdk.java.net>>
> *Cc:* Doerr, Martin <martin.doerr@sap.com
> <mailto:martin.doerr@sap.com>>
> *Subject:* Re: RFR : 8218965: aix: support xlclang++ in the
> compiler detection
>
> On 2019-02-15 14:30, Baesken, Matthias wrote:
>
>
>
> Are they both pointing to the same binary, and the mode of operation
>
> (legacy xlc vs xlclang) is determined by the name of the executable?
>
>
>
>
>
> Hello, in the installation I use I have separate binaries .
>
>
>
>
>
>
>
> Is xlclang++ always available for version 16+ of xlc?
>
>
>
>
>
> I think so, as least I am not aware of an installation mode with separate \
> binaries .
> However I am not an XLC installation guru😊 .
>
>
>
>
>
> If so, maybe we should just make sure we call the compiler with the
>
> correct name if version 16+ is detected?
>
>
>
>
>
> I thought that we currently first set the toolchain name and then set a fix \
> name for the binary and check the version .
> But I might be wrong. Maybe we need to adjust this .
>
> Or just at some future point in time declare xlc16 as minimum requirement \
> (this makes things easier , we can then use the new binary names ).
>
> Yeah, we can adjust the process if needed. And to solve this
> *properly*, we should. I still think this looks like the wrong
> way to do it. But...
>
> If we're talking about a short migration story, where soon XLC
> 16 will be required, and we can just replace
>
> TOOLCHAIN_CC_BINARY_xlc="xlc_r"
>
> with
>
> TOOLCHAIN_CC_BINARY_xlc="xlclang"
>
> then I can accept it anyway, so we don't need to complicate
> things.
>
> I also don't like how xlclang is just run from the path, but
> OTOH it's only you guys who are going to run that in practice,
> and it's just going to be temporary, so, whatever.
>
> The name AIX_USE_CLANG is not really correct, though. This is
> not about AIX. It should be XLC_USE_CLANG (or maybe better
> XLC_USES_CLANG, even perhaps XLC_IS_CLANG?!). And, as I said,
> it should use true/false, not 0/1.
>
> If you fix this, and we agree that this is a temporary
> measure, I'm OK with the patch.
>
> /Magnus
>
>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Fine with me.<br>
<br>
-phil.<br>
<br>
On 2/19/19, 4:10 AM, Doerr, Martin wrote:
<blockquote
cite="mid:AM6PR02MB4788056D17EAE4B8E4E65D139A7C0@AM6PR02MB4788.eurprd02.prod.outlook.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI Emoji";
panose-1:2 11 5 2 4 2 4 2 2 3;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.new
{mso-style-name:new;
color:blue;
font-weight:bold;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.changed
{mso-style-name:changed;}
span.EmailStyle27
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Hi Matthias,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">build has passed with this version. I think you
can ship it.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Martin<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="color:windowtext"
lang="EN-US">From:</span></b><span
style="color:windowtext" lang="EN-US"> Baesken, Matthias
<br>
<b>Sent:</b> Dienstag, 19. Februar 2019 09:57<br>
<b>To:</b> Philip Race <a class="moz-txt-link-rfc2396E" \
href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" \
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a>; \
Doerr, Martin
<a class="moz-txt-link-rfc2396E" \
href="mailto:martin.doerr@sap.com"><martin.doerr@sap.com></a><br> \
<b>Subject:</b> RE: [OpenJDK 2D-Dev] FW: RFR : 8218965:
aix: support xlclang++ in the compiler \
detection<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Hello, for some reason a "c" (__ibmxlc__)
was in my last webrev that does not belong there; the
macro name is __ibmxl__ :<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US">118
#elif !defined(HB_NO_MT) && defined(_AIX) &&
(defined(__IBMCPP__) || defined(__ibmxl__))<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">New webrev :<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8218965.2/">http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.2/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">>If there's a hb
release with it soon I can use that or I will try<br>
>to remember to re-apply it ...</span><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Thanks for looking into it (and for trying to
remember
</span><span style="font-family:"Segoe UI
Emoji",sans-serif;color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">😉</span><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> ) !<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Best regards, Matthias<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="color:windowtext"
lang="EN-US">From:</span></b><span
style="color:windowtext" lang="EN-US"> Philip Race
<<a moz-do-not-send="true"
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>>
<br>
<b>Sent:</b> Dienstag, 19. Februar 2019 01:18<br>
<b>To:</b> Baesken, Matthias <<a
moz-do-not-send="true"
href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>><br>
<b>Cc:</b> <a moz-do-not-send="true"
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a>;
Doerr, Martin <<a moz-do-not-send="true"
href="mailto:martin.doerr@sap.com">martin.doerr@sap.com</a>><br>
<b>Subject:</b> Re: [OpenJDK 2D-Dev] FW: RFR :
8218965: aix: support xlclang++ in the compiler
detection<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Yes .. I see that ... <br>
<a moz-do-not-send="true"
href="https://github.com/harfbuzz/harfbuzz/commit/5c2bb1de8de31fecf0dae2ef905b896e42d3 \
9f1d">https://github.com/harfbuzz/harfbuzz/commit/5c2bb1de8de31fecf0dae2ef905b896e42d39f1d</a><br>
<br>
.. looks ok ..<br>
although I soon need to upgrade harfbuzz in JDK and the<br>
current release of 2.3.1 doesn't have that change.<br>
<br>
If there's a hb release with it soon I can use that or I
will try<br>
to remember to re-apply it ... <br>
<br>
-phil.<br>
<br>
On 2/18/19, 7:08 AM, Baesken, Matthias wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US">FYI
- this change</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8218965.1/">http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.1/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">includes a small harfbuzz fix by Martin
as well ; he fixed it as well in the upstream
harfbuzz project . </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Best regards, Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="mso-fareast-language:EN-US" lang="EN-US"> \
</span><o:p></o:p></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="color:windowtext"
lang="EN-US">From:</span></b><span
style="color:windowtext" lang="EN-US"> Magnus Ihse
Bursie
<a moz-do-not-send="true"
\
href="mailto:magnus.ihse.bursie@oracle.com"><magnus.ihse.bursie@oracle.com></a> \
<br> <b>Sent:</b> Montag, 18. Februar 2019 15:46<br>
<b>To:</b> Doerr, Martin <a moz-do-not-send="true"
\
href="mailto:martin.doerr@sap.com"><martin.doerr@sap.com></a><br> <b>Cc:</b> \
Baesken, Matthias <a moz-do-not-send="true"
\
href="mailto:matthias.baesken@sap.com"><matthias.baesken@sap.com></a>; <a \
moz-do-not-send="true"
\
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a><br> \
<b>Subject:</b> Re: RFR : 8218965: aix: support
xlclang++ in the compiler detection</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Looks good
to me. <o:p></o:p></p>
<div id="AppleMailSignature">
<p class="MsoNormal">/Magnus<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
18 feb. 2019 kl. 15:37 skrev Doerr, Martin <<a
moz-do-not-send="true"
href="mailto:martin.doerr@sap.com">martin.doerr@sap.com</a>>:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US">Hi
Matthias,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">excellent. Looks good to me. This
should make AIX ready for JEP 347.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Thanks</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Martin</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="mso-fareast-language:EN-US" lang="EN-US"> \
</span><o:p></o:p></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="color:windowtext" lang="EN-US">From:</span></b><span
style="color:windowtext" lang="EN-US"> Baesken,
Matthias
<br>
<b>Sent:</b> Montag, 18. Februar 2019 13:53<br>
<b>To:</b> Magnus Ihse Bursie <<a
moz-do-not-send="true"
\
href="mailto:magnus.ihse.bursie@oracle.com">magnus.ihse.bursie@oracle.com</a>>; \
'<a moz-do-not-send="true"
\
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>' <<a \
moz-do-not-send="true"
\
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>><br> \
<b>Cc:</b> Doerr, Martin <<a moz-do-not-send="true"
\
href="mailto:martin.doerr@sap.com">martin.doerr@sap.com</a>><br> <b>Subject:</b> \
RE: RFR : 8218965: aix: support
xlclang++ in the compiler detection</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US">Hello
Martin and Magnus,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">I included Martin's harfbuzz fix and
adjusted the xlc version check ( renamed
variable to
</span><span lang="EN-US">XLC_USES_CLANG and also
check the </span><b><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">TOOLCHAIN_PATH ) .</span></b><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">>If we're
talking about a short migration story, where soon
XLC 16 will be required, and we can just replace
</span><o:p></o:p></p>
<pre style="background:#EEEEEE"><span \
lang="EN-US">>TOOLCHAIN_CC_BINARY_xlc="xlc_r"</span><o:p></o:p></pre>
<p class="MsoNormal"><span \
lang="EN-US">>with</span><o:p></o:p></p>
<pre style="background:#EEEEEE"><span \
lang="EN-US">>TOOLCHAIN_CC_BINARY_xlc="xlclang"</span><o:p></o:p></pre> <p \
class="MsoNormal"><span lang="EN-US">> then I can accept it anyway, so we don't \
need to complicate things.<br>
</span><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">Yes , that's the idea - to do the
replacement above sooner or later ; depends of
course also on the introduction of the C++11/14
features in the code base .</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US">New webrev :</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"
lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"><a
moz-do-not-send="true"
\
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8218965.1/">http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.1/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US">Best
Regards, Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="color:windowtext;mso-fareast-language:EN-US"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue
1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="color:windowtext" \
lang="EN-US">From:</span></b><span style="color:windowtext" lang="EN-US"> Magnus
Ihse Bursie <<a moz-do-not-send="true"
\
href="mailto:magnus.ihse.bursie@oracle.com">magnus.ihse.bursie@oracle.com</a>> \
<br> <b>Sent:</b> Montag, 18. Februar 2019 11:18<br>
<b>To:</b> Baesken, Matthias <<a
moz-do-not-send="true"
\
href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>>; '<a \
moz-do-not-send="true"
\
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>' <<a \
moz-do-not-send="true"
\
href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>><br> \
<b>Cc:</b> Doerr, Martin <<a moz-do-not-send="true"
\
href="mailto:martin.doerr@sap.com">martin.doerr@sap.com</a>><br> <b>Subject:</b> \
Re: RFR : 8218965: aix:
support xlclang++ in the compiler \
detection</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"> <o:p></o:p></p>
<div>
<p class="MsoNormal">On 2019-02-15 14:30, Baesken,
Matthias wrote:<o:p></o:p></p>
</div>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre> <o:p></o:p></pre>
<pre>Are they both pointing to the same binary, and the mode of \
operation<o:p></o:p></pre>
<pre>(legacy xlc vs xlclang) is determined by the name of the \
executable?<o:p></o:p></pre> <pre> <o:p></o:p></pre>
</blockquote>
<pre> <o:p></o:p></pre>
<pre>Hello, in the installation I use I have separate \
binaries .<o:p></o:p></pre> <pre> <o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre> <o:p></o:p></pre>
<pre>Is xlclang++ always available for version 16+ of \
xlc?<o:p></o:p></pre> <pre> <o:p></o:p></pre>
</blockquote>
<pre> <o:p></o:p></pre>
<pre>I think so, as least I am not aware of an installation \
mode with separate binaries .<o:p></o:p></pre>
<pre>However I am not an XLC installation guru <span \
style="font-family:"Segoe UI Emoji",sans-serif">😊</span> \
.<o:p></o:p></pre> <pre> <o:p></o:p></pre>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre> <o:p></o:p></pre>
<pre>If so, maybe we should just make sure we call the compiler \
with the<o:p></o:p></pre>
<pre>correct name if version 16+ is detected?<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre> <o:p></o:p></pre>
<pre>I thought that we currently first set the toolchain \
name and then set a fix name for the binary and check the version \
.<o:p></o:p></pre>
<pre>But I might be wrong. Maybe we need to adjust this \
.<o:p></o:p></pre> <pre>Or just at some future point in time declare xlc16 \
as minimum requirement (this makes things easier , we can then use the new \
binary names ).<o:p></o:p></pre> </blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
Yeah, we can adjust the process if needed. And to
solve this *properly*, we should. I still think this
looks like the wrong way to do it. But...<br>
<br>
If we're talking about a short migration story,
where soon XLC 16 will be required, and we can just
replace
<o:p></o:p></p>
<pre \
style="background:#EEEEEE">TOOLCHAIN_CC_BINARY_xlc="xlc_r"<o:p></o:p></pre>
<p class="MsoNormal" \
style="margin-bottom:12.0pt">with<o:p></o:p></p>
<pre \
style="background:#EEEEEE">TOOLCHAIN_CC_BINARY_xlc="xlclang"<o:p></o:p></pre> <p \
class="MsoNormal" style="margin-bottom:12.0pt">then I can accept it anyway, so we \
don't need to complicate things.<br>
<br>
I also don't like how xlclang is just run from the
path, but OTOH it's only you guys who are going to
run that in practice, and it's just going to be
temporary, so, whatever.
<br>
<br>
The name AIX_USE_CLANG is not really correct,
though. This is not about AIX. It should be
XLC_USE_CLANG (or maybe better XLC_USES_CLANG, even
perhaps XLC_IS_CLANG?!). And, as I said, it should
use true/false, not 0/1.<br>
<br>
If you fix this, and we agree that this is a
temporary measure, I'm OK with the patch.<br>
<br>
/Magnus<br>
<br>
<br>
<br>
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</blockquote>
</blockquote>
</div>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic