[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <Sound Dev> RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words
From: Stefan Reich <stefan.reich.maker.of.eye () googlemail ! com>
Date: 2018-12-11 20:20:41
Message-ID: CAC2-jLEnKHih-9WqyHmTbQb8GcOo5BGNVvpATSZQUsykVctDYQ () mail ! gmail ! com
[Download RAW message or body]
What is this, the thought police?
Cheers
Stefan
BotCompany.de
On Tue, 11 Dec 2018 at 20:47, Phil Race <philip.race@oracle.com> wrote:
> 1) Thanks for uploading the webrev. much better for one person to do
> this than make
> everyone who wants to look at it go through a tedious and off-putting
> set of steps.
>
> 2) I've added some client lists since you are touching UI client files,
> not just core-libs.
> To me the client ones look OK, one looks more like it was a typo
> than anything intentional,
> and the other was pretty mild.
>
> 3) Regarding the comment in the bug report about hb-private.hh and the
> use of
> /* CRAP pool: Common Region for Access Protection. */
> since it not only is in an upstream library, but also used 14 times in
> variable names,
> then I can't possibly agree with your comment that an argument for
> leaving them
> would be "shaky". Take this up with the upstream library ... I have no
> interest in
> renaming these every time we upgrade this library.
>
> -phil.
>
> On 12/11/18 8:45 AM, Adam Farley8 wrote:
> > Sure thing:
> >
> > http://cr.openjdk.java.net/~afarley/8215217/webrev/
> >
> > Best Regards
> >
> > Adam Farley
> > IBM Runtimes
> >
> >
> > Volker Simonis <volker.simonis@gmail.com> wrote on 11/12/2018 15:46:44:
> >
> >> From: Volker Simonis <volker.simonis@gmail.com>
> >> To: adam.farley@uk.ibm.com
> >> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
> >> Date: 11/12/2018 15:47
> >> Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words
> >>
> >> Hi Adam,
> >>
> >> in order to prevent me from using swear words, could you please upload
> >> your webrev to cr.openjdk.java.net :)
> >>
> >> As you may have realized webrevs are a collection of HTML files and it
> >> makes no big sense to provide them as a zip file.
> >>
> >> Thank you and best regards,
> >> Volker
> >> On Tue, Dec 11, 2018 at 4:04 PM Adam Farley8 <adam.farley@uk.ibm.com>
> > wrote:
> >>> Hey All,
> >>>
> >>> I've spotted 12 instances of swear words in OpenJDK source comments,
> > and
> >>> it seems appropriate to remove them.
> >>>
> >>> Bug: INVALID URI REMOVED
> >
> u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8215217&d=DwIBaQ&c=jf_iaSHvJObTbx-
> >> siA1ZOg&r=P5m8KWUXJf-
> >>
> >
> CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=GfAb5QlDParO6DVrhdvPZTSafShnFACNF3JgqF-
> >> _RkM&s=Qscaf2tTpPcZKpIelJ6SrP0uRYSFoKaCNATns0FX7_Y&e=
> >>> I've created a webrev and attached to the bug.
> >>>
> >>> Also, I've mentioned in the bug that there are additional swears in
> > more
> >>> excusable locations. It would be good to get the community's take on
> >>> those.
> >>>
> >>> Reviews and opinions welcome. :)
> >>>
> >>> Best Regards
> >>>
> >>> Adam Farley
> >>> IBM Runtimes
> >>>
> >>> Unless stated otherwise above:
> >>> IBM United Kingdom Limited - Registered in England and Wales with
> > number
> >>> 741598.
> >>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> > 3AU
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with number
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
>
>
--
Stefan Reich
BotCompany.de // Java-based operating systems
[Attachment #3 (text/html)]
<div dir="ltr"><div>What is this, the thought \
police?</div><div><br></div><div>Cheers</div><div><br></div><div>Stefan</div><div>BotCompany.de<br></div></div><br><div \
class="gmail_quote"><div dir="ltr">On Tue, 11 Dec 2018 at 20:47, Phil Race <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">1) Thanks for \
uploading the webrev. much better for one person to do <br> this than make<br>
everyone who wants to look at it go through a tedious and off-putting <br>
set of steps.<br>
<br>
2) I've added some client lists since you are touching UI client files, <br>
not just core-libs.<br>
To me the client ones look OK, one looks more like it was a typo <br>
than anything intentional,<br>
and the other was pretty mild.<br>
<br>
3) Regarding the comment in the bug report about hb-private.hh and the <br>
use of<br>
/* CRAP pool: Common Region for Access Protection. */<br>
since it not only is in an upstream library, but also used 14 times in <br>
variable names,<br>
then I can't possibly agree with your comment that an argument for <br>
leaving them<br>
would be "shaky". Take this up with the upstream library ... I have no <br>
interest in<br>
renaming these every time we upgrade this library.<br>
<br>
-phil.<br>
<br>
On 12/11/18 8:45 AM, Adam Farley8 wrote:<br>
> Sure thing:<br>
><br>
> <a href="http://cr.openjdk.java.net/~afarley/8215217/webrev/" rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~afarley/8215217/webrev/</a><br> ><br>
> Best Regards<br>
><br>
> Adam Farley<br>
> IBM Runtimes<br>
><br>
><br>
> Volker Simonis <<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>> wrote on 11/12/2018 15:46:44:<br> \
><br> >> From: Volker Simonis <<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>><br> >> To: <a \
href="mailto:adam.farley@uk.ibm.com" target="_blank">adam.farley@uk.ibm.com</a><br> \
>> Cc: Java Core Libs <<a href="mailto:core-libs-dev@openjdk.java.net" \
target="_blank">core-libs-dev@openjdk.java.net</a>><br> >> Date: 11/12/2018 \
15:47<br> >> Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear \
Words<br> >><br>
>> Hi Adam,<br>
>><br>
>> in order to prevent me from using swear words, could you please upload<br>
>> your webrev to <a href="http://cr.openjdk.java.net" rel="noreferrer" \
target="_blank">cr.openjdk.java.net</a> :)<br> >><br>
>> As you may have realized webrevs are a collection of HTML files and it<br>
>> makes no big sense to provide them as a zip file.<br>
>><br>
>> Thank you and best regards,<br>
>> Volker<br>
>> On Tue, Dec 11, 2018 at 4:04 PM Adam Farley8 <<a \
href="mailto:adam.farley@uk.ibm.com" \
target="_blank">adam.farley@uk.ibm.com</a>><br> > wrote:<br>
>>> Hey All,<br>
>>><br>
>>> I've spotted 12 instances of swear words in OpenJDK source \
comments,<br> > and<br>
>>> it seems appropriate to remove them.<br>
>>><br>
>>> Bug: INVALID URI REMOVED<br>
> u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8215217&d=DwIBaQ&c=jf_iaSHvJObTbx-<br>
>> siA1ZOg&r=P5m8KWUXJf-<br>
>><br>
> CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=GfAb5QlDParO6DVrhdvPZTSafShnFACNF3JgqF-<br>
>> _RkM&s=Qscaf2tTpPcZKpIelJ6SrP0uRYSFoKaCNATns0FX7_Y&e=<br>
>>> I've created a webrev and attached to the bug.<br>
>>><br>
>>> Also, I've mentioned in the bug that there are additional swears \
in<br> > more<br>
>>> excusable locations. It would be good to get the community's take \
on<br> >>> those.<br>
>>><br>
>>> Reviews and opinions welcome. :)<br>
>>><br>
>>> Best Regards<br>
>>><br>
>>> Adam Farley<br>
>>> IBM Runtimes<br>
>>><br>
>>> Unless stated otherwise above:<br>
>>> IBM United Kingdom Limited - Registered in England and Wales with<br>
> number<br>
>>> 741598.<br>
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire \
PO6<br> > 3AU<br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with number<br>
> 741598.<br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" \
class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Stefan \
Reich<div>BotCompany.de // Java-based operating \
systems<br></div></div></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic