[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2018-12-01 2:05:54
Message-ID: 834ba451-818d-a488-df22-7b4b5cd6f5d2 () oracle ! com
[Download RAW message or body]

+1

On 30/11/2018 13:16, Alexey Ivanov wrote:
> Hi Prasanta,
> 
> Looks good to me.
> 
> Regards,
> Alexey
> 
> On 30/11/2018 17:23, Prasanta Sadhukhan wrote:
> > Hi Alexey,
> > 
> > Ok. Modified webrev:
> > http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/
> > 
> > Regards
> > Prasanta
> > On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:
> > > Hi Prasanta,
> > > 
> > > Adding style="text-align: center" attribute to <tbody> element is cleaner and \
> > > achieves the same result as it applies to all <td> (as well <th> which are \
> > > center-aligned by default anyway). If the content of the table is modified in \
> > > the future, there will be no need to add style attributes to new cells which \
> > > will have non-empty content. 
> > > Does it look reasonable?
> > > 
> > > Regards,
> > > Alexey
> > > 
> > > On 30/11/2018 15:25, Prasanta Sadhukhan wrote:
> > > > Hi Alexey,
> > > > 
> > > > I have modified to keep the "X" centred. Please find the modified webrev:
> > > > http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.1/
> > > > 
> > > > Regards
> > > > Prasanta
> > > > On 30-Nov-18 4:50 PM, Alexey Ivanov wrote:
> > > > > Hi Prasanta,
> > > > > 
> > > > > Would the presentation benefit from
> > > > > <tbody style="text-align: center">
> > > > > to keep X centred and thus to preserve the visual appearance?
> > > > > 
> > > > > Do you mind updating the copyright?
> > > > > 
> > > > > Otherwise, the change looks good to me.
> > > > > 
> > > > > Regards,
> > > > > Alexey
> > > > > 
> > > > > On 30/11/2018 07:41, Prasanta Sadhukhan wrote:
> > > > > > Hi All,
> > > > > > 
> > > > > > Please review a doc-fix to comply with HTML5 standard by removing the \
> > > > > >                 obsolete <td> attribute "align"
> > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213051
> > > > > > webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.0/
> > > > > > 
> > > > > > Regards
> > > > > > Prasanta
> > > > > 
> > > > 
> > > 
> > 
> 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]