[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR(S): 8214343: Handle the absence of Xrandr more generically
From:       Phil Race <philip.race () oracle ! com>
Date:       2018-11-27 17:19:54
Message-ID: 00af6f9c-5394-49ad-8a0e-d9c937021926 () oracle ! com
[Download RAW message or body]


+1

-phil.

On 11/27/18 8:45 AM, Erik Joelsson wrote:
> Looks ok to me.
>
> /Erik
>
> On 2018-11-27 05:52, Volker Simonis wrote:
>> Hi,
>>
>> can I please have a review for the following trivial change which
>> handles the absence of Xrandr more generically:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2018/8214343/
>> https://bugs.openjdk.java.net/browse/JDK-8214343
>>
>> Change JDK-8213944 fixed the build on AIX (which has no Xrandr) by
>> conditionally excluding the relevant parts on AIX with the help of
>> preprocessor defines. On the mailing lists the wish was expressed to
>> handle the absence of Xrandr more generically during the configure
>> step, so here comes the corresponding change.
>>
>> In contrast to the suggestions on the previous mail thread I define
>> "NO_XRENDER" if we're configuring on AIX. This avoids clobbering all
>> the other platforms which support Xrandr with yet another command line
>> define of the form "-DHAVE_XRANDR". Instead, only the corresponding
>> compiler options on AIX will now contain "-DNO_XRANDR". Other
>> platforms which don't support Xrandr can now easily define NO_XRANDR
>> as well.
>>
>> Thank you and best regards,
>> Volker

[prev in list] [next in list] [prev in thread] [next in thread]