[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8130264 : change the mechanism by which JDK loads the platform-specific Pr
From:       Phil Race <philip.race () oracle ! com>
Date:       2018-11-26 21:20:48
Message-ID: ffdc3590-dc42-0e41-9b03-859507be3779 () oracle ! com
[Download RAW message or body]

Can someone review the CSR : 
https://bugs.openjdk.java.net/browse/JDK-8214322 ?

Also my email below pointed to the webrev twice .. the bug id for this 
issue is here :

https://bugs.openjdk.java.net/browse/JDK-8130264

-phil.


On 11/16/18 1:36 PM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 15/11/2018 13:41, Phil Race wrote:
>> bug: http://cr.openjdk.java.net/~prr/8130264/
>> webrev: http://cr.openjdk.java.net/~prr/8130264/
>>
>> Currently java launcher code embeds the name of the java.desktop 
>> module's PrinterJob
>> implementation class for each platform in a system property which is 
>> later
>> read by the java.desktop code to use to reflectively locate the class 
>> and instantiate it.
>>
>> This fix removes that entirely from the launcher code and the desktop 
>> module
>> now looks it up internally via a simple platform proxy class.
>>
>> This builds on all platforms and we rely on existing printing tests 
>> to verify
>> that we can still locate the implementation class.
>>
>> The new regression test just verifies the system property name space 
>> is no longer polluted.
>> I didn't find any test (apart from this new one) that references it.
>>
>> Since that system property has been around for a long time I am 
>> thinking I should file a CSR
>> to document its removal .. unless there is a concensus it is not 
>> necessary.
>>
>> -phil.
>
>

[prev in list] [next in list] [prev in thread] [next in thread]