[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8210863: Remove Xrandr include files from JDK sources
From:       Phil Race <philip.race () oracle ! com>
Date:       2018-10-31 19:17:59
Message-ID: c126cb2e-83d7-d66f-72a2-58678b335f30 () oracle ! com
[Download RAW message or body]

Erik has an updated devkit that is a pre-requisite for that. It is already
pushed and I tested with his patch which will make the new devkit the 
default.

So mach5 is green once Erik pushes his devkit fix which I have tested
to make sure we always have the header files on otherwise "minimally"
configured linux build systems.

Ergo, this will go in only once he has pushed his fix :
https://bugs.openjdk.java.net/browse/JDK-8210837

-phil.

On 10/31/18 12:02 PM, Sergey Bylokhov wrote:
> Looks fine, I assume mach5 is green.
>
> On 31/10/2018 11:57, Phil Race wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210863
>> Webrev: http://cr.openjdk.java.net/~prr/8210863/
>>
>> JDK imported Xrandr headers into it's source a really long time ago 
>> because
>> old build systems did not have it. We no longer have that problem, so 
>> we can
>> remove these.
>>
>> I am not changing the code to remove the dynamic loading of the 
>> functions and
>> change it to compile time link against them.
>> We can probably do that too at a later time,   but the immediate goal 
>> is to
>> remove these source files since they are imported 3rd party sources.
>>
>> -phil.
>>
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]