[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong usage of NSPrintJobDisposi
From: Jayathirth D V <jayathirth.d.v () oracle ! com>
Date: 2018-10-13 4:43:15
Message-ID: b325b9fc-a3ff-40b3-81e5-9d69d4ed9790 () default
[Download RAW message or body]
Hi Prasanta,
Changes are fine.
Thanks,
Jay
From: Prasanta Sadhukhan
Sent: Thursday, October 11, 2018 1:40 PM
To: 2d-dev
Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong usage \
of NSPrintJobDispositionValue in mac10.12
Hi All,
Please review a build issue fix for usage of NSPrintJobDispositionValue in HYPERLINK \
"https://bugs.openjdk.java.net/browse/JDK-8211055"JDK-8211055: Provide print to a \
file (PDF) feature even when printer was not connected It seems that \
NSPrintJobDispositionValue is added in 10.13 sdk \
[https://developer.apple.com/documentation/appkit/nsprintjobdispositionvalue?language=objc]
so using it in 10.12 or lower cause build issue.
Fix is to check for disposition value directly instead of storing in variable.
mach5 build is successful.
Bug:https://bugs.openjdk.java.net/browse/JDK-8212040
webrev: http://cr.openjdk.java.net/~psadhukhan/8212040/webrev/
Regards
Prasanta
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Hi \
Prasanta,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Changes are \
fine.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Jay<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext'> Prasanta \
Sadhukhan <br><b>Sent:</b> Thursday, October 11, 2018 1:40 PM<br><b>To:</b> \
2d-dev<br><b>Subject:</b> [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error \
due to wrong usage of NSPrintJobDispositionValue in \
mac10.12<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Hi All,<br><br>Please review a build issue fix for usage of \
NSPrintJobDispositionValue in <a \
href="https://bugs.openjdk.java.net/browse/JDK-8211055" title="Provide print to a \
file (PDF) feature even when printer was not \
connected"><s>JDK-8211055</s></a>: Provide print to a file (PDF) feature even when \
printer was not connected<br>It seems that NSPrintJobDispositionValue is added in \
10.13 sdk [<a href="https://developer.apple.com/documentation/appkit/nsprintjobdisposi \
tionvalue?language=objc">https://developer.apple.com/documentation/appkit/nsprintjobdispositionvalue?language=objc</a>]<br>so \
using it in 10.12 or lower cause build issue.<br><br>Fix is to check for disposition \
value directly instead of storing in variable.<br>mach5 build is \
successful.<br><br>Bug:<a \
href="https://bugs.openjdk.java.net/browse/JDK-8212040">https://bugs.openjdk.java.net/browse/JDK-8212040</a><br>webrev: \
<a href="http://cr.openjdk.java.net/~psadhukhan/8212040/webrev/">http://cr.openjdk.jav \
a.net/~psadhukhan/8212040/webrev/</a><br><br>Regards<br>Prasanta<o:p></o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic