[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt
From: Krishna Addepalli <krishna.addepalli () oracle ! com>
Date: 2018-10-02 15:35:24
Message-ID: F5D651AC-DFCD-41A5-8465-ACC425E7DE2D () oracle ! com
[Download RAW message or body]
Yes, that is right.
I have compiled it Mac, Linux and Windows locally. I tried submitting a Mach5 job, \
but was unable to as it was down. Will try it again.
Thanks
Krishna
> On 02-Oct-2018, at 3:39 AM, Philip Race <philip.race@oracle.com> wrote:
>
> I suspect I understand this one now .. the array is stack allocated so we don't \
> want NULL but the compiler probably complained about possible uninitialised use of \
> the values ?
> -phil.
>
> On 10/1/18, 9:38 AM, Philip Race wrote:
> >
> > You really do need to explain *each* of the changes better.
> > This one .. why not NULL ?
> > http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html \
> > <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html>
> >
> > -phil
> >
> > On 10/1/18, 9:19 AM, Philip Race wrote:
> > >
> > > Hi,
> > >
> > > 1) Has this been built on all platforms ?
> > > 2) I can't find the list of warnings that you are seeing and fixing and they \
> > > are all over the place. So adding 2d-dev and build-dev.
> > > For each of these changes, please show what was the warning that you received \
> > > from the compiler This might sound like a lot of work, but it won't be \
> > > disproportionate and I've made the same request for similar reviews and without \
> > > it, it is hard to review the changes.
> > > For example (and I do mean just example)
> > > http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html \
> > > <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html>
> > >
> > > why would that not be #ifdef instead ?
> > >
> > > 3) Testing .. did you run at least all our jtreg tests to make sure you didn't \
> > > break some behaviour ..
> > >
> > > -phil.
> > >
> > > On 9/29/18, 8:18 PM, Krishna Addepalli wrote:
> > > >
> > > > Hi All,
> > > >
> > > > Please review a fix for JDK-8074824: \
> > > > https://bugs.openjdk.java.net/browse/JDK-8074824 \
> > > > <https://bugs.openjdk.java.net/browse/JDK-8074824>
> > > > Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/ \
> > > > <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/>
> > > > Most of the warnings have been fixed for Linux, Mac and Windows.
> > > >
> > > > Thanks,
> > > > Krishna
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class="">Yes, that is right.<div class="">I \
have compiled it Mac, Linux and Windows locally. I tried submitting a Mach5 job, but \
was unable to as it was down. Will try it again.</div><div class=""><br \
class=""></div><div class="">Thanks</div><div class="">Krishna<br class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On 02-Oct-2018, at 3:39 AM, \
Philip Race <<a href="mailto:philip.race@oracle.com" \
class="">philip.race@oracle.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, \
0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: \
normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); \
text-decoration: none; float: none; display: inline !important;" class="">I suspect I \
understand this one now .. the array is stack allocated so we don't want \
NULL</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
background-color: rgb(255, 255, 255); text-decoration: none;" class=""><span \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, \
255, 255); text-decoration: none; float: none; display: inline !important;" \
class="">but the compiler probably complained about possible uninitialised use of the \
values ?</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
background-color: rgb(255, 255, 255); text-decoration: none;" class=""><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, \
255, 255); text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: \
normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); \
text-decoration: none; float: none; display: inline !important;" \
class="">-phil.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
background-color: rgb(255, 255, 255); text-decoration: none;" class=""><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, \
255, 255); text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: \
normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); \
text-decoration: none; float: none; display: inline !important;" class="">On 10/1/18, \
9:38 AM, Philip Race wrote:</span><blockquote cite="mid:5BB24D6E.5020600@oracle.com" \
type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); \
text-decoration: none;" class="">You really do need to explain *each* of the changes \
better.<br class="">This one .. why not NULL ?<br class=""><a moz-do-not-send="true" \
class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html" \
style="color: rgb(149, 79, 114); text-decoration: \
underline;">http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html</a><br \
class=""><br class="">-phil<br class=""><br class="">On 10/1/18, 9:19 AM, Philip Race \
wrote:<blockquote cite="mid:5BB2491B.7000501@oracle.com" type="cite" class="">Hi,<br \
class=""><br class="">1) Has this been built on all platforms ?<br class="">2) \
I can't find the list of warnings that you are seeing and fixing and they are all \
over the place.<br class="">So adding 2d-dev and build-dev.<br class="">For each of \
these changes, please show what was the warning that you received from the \
compiler<br class="">This might sound like a lot of work, but it won't be \
disproportionate and I've made the same<br class="">request for similar reviews and \
without it, it is hard to review the changes.<br class=""><br class="">For example \
(and I do mean just example)<span class="Apple-converted-space"> </span><br \
class=""><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html" \
style="color: rgb(149, 79, 114); text-decoration: \
underline;">http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html</a><br \
class=""><br class="">why would that not be #ifdef instead ?<br class=""><br \
class="">3) Testing .. did you run at least all our jtreg tests to make sure you \
didn't break<br class="">some behaviour ..<br class=""><br class="">-phil.<br \
class=""><br class="">On 9/29/18, 8:18 PM, Krishna Addepalli wrote:<blockquote \
cite="mid:57768c04-a994-46f8-8322-fa89058d58c9@default" type="cite" class=""><div \
class="WordSection1" style="page: WordSection1;"><div style="margin: 0in 0in \
0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi All,<span \
class="Apple-converted-space"> </span><o:p class=""></o:p></div><div \
style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class=""><o:p class=""> </o:p></div><div style="margin: 0in 0in 0.0001pt; \
font-size: 11pt; font-family: Calibri, sans-serif;" class="">Please review a fix for \
JDK-8074824:<span class="Apple-converted-space"> </span><a \
moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8074824" \
style="color: rgb(149, 79, 114); text-decoration: underline;" \
class="">https://bugs.openjdk.java.net/browse/JDK-8074824</a><o:p \
class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class="">Webrev:<span \
class="Apple-converted-space"> </span><a moz-do-not-send="true" \
href="http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/" style="color: \
rgb(149, 79, 114); text-decoration: underline;" \
class="">http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/</a><o:p \
class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div \
style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class="">Most of the warnings have been fixed for Linux, Mac and Windows.<o:p \
class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div \
style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class="">Thanks,<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt; \
font-size: 11pt; font-family: Calibri, sans-serif;" class="">Krishna<o:p \
class=""></o:p></div></div></blockquote></blockquote></blockquote></div></blockquote></div><br \
class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic