[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [12] Review request for 8211165: License header is absent in a few J2Ddemo sour
From:       Anton Litvinov <anton.litvinov () oracle ! com>
Date:       2018-09-26 17:08:46
Message-ID: ef764dcb-74b0-1700-7968-a3495ee52be9 () oracle ! com
[Download RAW message or body]

Hello Phil,

Thank you very much for approval of this fix. I will push the fix 
immediately. I think that for this particular case it is better to 
include also "2018,", because we add the header itself in 2018 and it 
will not look good, if we introduce the header and change the file now 
and leave just "2015,"   sub-string.

Thank you,
Anton

On 26/09/2018 17:50, Phil Race wrote:
> Looks good to me.
>
> Not sure if including 2018 is strictly needed since the only change in 
> 2018 is to add
> the legal notice itself :-)
>
> -phill
>
> On 09/26/2018 09:40 AM, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix which adds two blocks of 
>> source code comments to two files.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8211165
>> Webrev: http://cr.openjdk.java.net/~alitvinov/8211165/jdk12/webrev.00
>>
>> Thank you,
>> Anton
>

[prev in list] [next in list] [prev in thread] [next in thread]