[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling fac
From: Laurent_Bourgès <bourges.laurent () gmail ! com>
Date: 2018-09-26 7:03:11
Message-ID: CAKjRUT4uP_Sptbyr4wRo54Uo-NNc0fCmG3Kuk8U31h0G8+FvfA () mail ! gmail ! com
[Download RAW message or body]
Hi,
I pushed this patch and asked for jdk11u backport: I added label and
comment to the jbs bug.
Is it enough ? Or should I send an email to jdk updates ....
Laurent
Le dim. 23 sept. 2018 =C3=A0 09:21, Sergey Bylokhov <Sergey.Bylokhov@oracle=
.com>
a =C3=A9crit :
> Looks fine.
>
> On 18/09/2018 00:22, Laurent Bourg=C3=A8s wrote:
> > Hi,
> >
> > Please could a second reviewer have a look ?
> > Phil approved 2 weeks ago.
> > I would like this bug done asap.
> >
> > I will propose for review the javafx patch (almost the same fix) in a
> > moment.
> >
> > Cheers,
> > Laurent
> >
> > Le mar. 11 sept. 2018 =C3=A0 08:55, Laurent Bourg=C3=A8s
> > <bourges.laurent@gmail.com <mailto:bourges.laurent@gmail.com>> a =C3=A9=
crit :
> >
> > Hi,
> > Can I have a second review, please ?
> >
> > I would like to make a jdk11 updates fix request asap...
> >
> > Laurent
> >
> > Le jeu. 6 sept. 2018 =C3=A0 09:31, Laurent Bourg=C3=A8s
> > <bourges.laurent@gmail.com <mailto:bourges.laurent@gmail.com>> a
> =C3=A9crit :
> >
> > Phil,
> > Thanks for your review.
> >
> > Le jeu. 6 sept. 2018 =C3=A0 01:39, Philip Race
> > <philip.race@oracle.com <mailto:philip.race@oracle.com>> a
> =C3=A9crit :
> >
> > This looks good to me.
> > I've run all our automated tests + done some manual testing
> > as well as building on all platforms and reviewing the
> > source changes.
> >
> >
> > Do you have more closed-source tests that could be opened in
> > OpenJDK ?
> >
> >
> > > PS: What is the process to ask for backport to JDK11
> > updates ?
> >
> > If you think this important enough to backport, then this i=
s
> > the process :
> >
> > http://openjdk.java.net/projects/jdk-updates/approval.html
> >
> >
> > I fixed these bugs as I was contacted on the Marlin mailing lis=
t
> > by an end user testing the migration of its Map viewer app from
> > jdk8 to OpenJDK11.
> >
> > I made this patch as small as possible that is compatible with
> > OpenJDK 11/12 and is well tested: low risk.
> > For 12, I will propose a more important patch later to upgrade
> > to Marlin 0.9.3
> >
> > As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I
> > think it is worth fixing it in 11 too.
> >
> > Any other opinion ?
> >
> > PS: I will fix OpenJFX 11/12 soon
> >
> > Cheers,
> > Laurent
> >
>
>
> --
> Best regards, Sergey.
>
[Attachment #3 (text/html)]
<div dir="auto">Hi,<div dir="auto"><br><div dir="auto">I pushed this patch and asked \
for jdk11u backport: I added label and comment to the jbs bug.</div><div \
dir="auto"><br></div><div dir="auto">Is it enough ? Or should I send an email to jdk \
updates ....</div><div dir="auto"><br></div><div \
dir="auto">Laurent</div></div></div><br><div class="gmail_quote"><div dir="ltr">Le \
dim. 23 sept. 2018 Ã 09:21, Sergey Bylokhov <<a \
href="mailto:Sergey.Bylokhov@oracle.com">Sergey.Bylokhov@oracle.com</a>> a écrit \
:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">Looks fine.<br> <br>
On 18/09/2018 00:22, Laurent Bourgès wrote:<br>
> Hi,<br>
> <br>
> Please could a second reviewer have a look ?<br>
> Phil approved 2 weeks ago.<br>
> I would like this bug done asap.<br>
> <br>
> I will propose for review the javafx patch (almost the same fix) in a <br>
> moment.<br>
> <br>
> Cheers,<br>
> Laurent<br>
> <br>
> Le mar. 11 sept. 2018 à 08:55, Laurent Bourgès <br>
> <<a href="mailto:bourges.laurent@gmail.com" target="_blank" \
rel="noreferrer">bourges.laurent@gmail.com</a> <mailto:<a \
href="mailto:bourges.laurent@gmail.com" target="_blank" \
rel="noreferrer">bourges.laurent@gmail.com</a>>> a écrit :<br> > <br>
> Hi,<br>
> Can I have a second review, please ?<br>
> <br>
> I would like to make a jdk11 updates fix request asap...<br>
> <br>
> Laurent<br>
> <br>
> Le jeu. 6 sept. 2018 à 09:31, Laurent Bourgès<br>
> <<a href="mailto:bourges.laurent@gmail.com" target="_blank" \
rel="noreferrer">bourges.laurent@gmail.com</a> <mailto:<a \
href="mailto:bourges.laurent@gmail.com" target="_blank" \
rel="noreferrer">bourges.laurent@gmail.com</a>>> a écrit :<br> > <br>
> Phil,<br>
> Thanks for your review.<br>
> <br>
> Le jeu. 6 sept. 2018 Ã 01:39, Philip Race<br>
> <<a href="mailto:philip.race@oracle.com" target="_blank" \
rel="noreferrer">philip.race@oracle.com</a> <mailto:<a \
href="mailto:philip.race@oracle.com" target="_blank" \
rel="noreferrer">philip.race@oracle.com</a>>> a écrit :<br> > <br>
> This looks good to me.<br>
> I've run all our automated tests + done some manual \
testing<br> > as well as building on all platforms and \
reviewing the<br> > source changes.<br>
> <br>
> <br>
> Do you have more closed-source tests that could be opened in<br>
> OpenJDK ?<br>
> <br>
> <br>
> > PS: What is the process to ask for backport to \
JDK11<br> > updates ?<br>
> <br>
> If you think this important enough to backport, then this \
is<br> > the process :<br>
> <br>
> <a \
href="http://openjdk.java.net/projects/jdk-updates/approval.html" rel="noreferrer \
noreferrer" target="_blank">http://openjdk.java.net/projects/jdk-updates/approval.html</a><br>
> <br>
> <br>
> I fixed these bugs as I was contacted on the Marlin mailing \
list<br> > by an end user testing the migration of its Map viewer app \
from<br> > jdk8 to OpenJDK11.<br>
> <br>
> I made this patch as small as possible that is compatible with<br>
> OpenJDK 11/12 and is well tested: low risk.<br>
> For 12, I will propose a more important patch later to upgrade<br>
> to Marlin 0.9.3<br>
> <br>
> As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I<br>
> think it is worth fixing it in 11 too.<br>
> <br>
> Any other opinion ?<br>
> <br>
> PS: I will fix OpenJFX 11/12 soon<br>
> <br>
> Cheers,<br>
> Laurent<br>
> <br>
<br>
<br>
-- <br>
Best regards, Sergey.<br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic