[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8203796: Define API to support specifying ownership of print dialogs.
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2018-06-06 18:00:31
Message-ID: de996221-8165-5101-0f59-696eea7f7113 () oracle ! com
[Download RAW message or body]

ok, then looks fine.
On 06/06/2018 10:40, Phil Race wrote:
> A number of the other attribute classes do the same.
> It is unneeded where the class is final but harmless.
> 
> -phil.
> 
> On 06/05/2018 03:19 PM, Sergey Bylokhov wrote:
>> Looks fine.
>> I think that final keyword may be dropped from the methods in 
>> DialogOwner or it was intentionally added?
>>
>>>>> One small note is about unnecessary final keywords on methods in 
>>>>> final class DialogOwner.
>>
>>
> 


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]