[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [XS] RFR : JDK-8204085: avoid printing uninitialized pointer in
From: Philip Race <philip.race () oracle ! com>
Date: 2018-05-30 14:25:14
Message-ID: 5B0EB44A.5080009 () oracle ! com
[Download RAW message or body]
Yes, please. And it looks fine. We have an internal static code analysis
tool
which should catch this sort of thing but it is weakest on Windows ..
-phil.
On 5/30/18, 7:11 AM, Baesken, Matthias wrote:
>
> Hi Christoph, Sergey and Thomas , thanks for the reviews .
>
> * And make sure you push it to the client repo...
> *
>
> Thanks for pointing this out, otherwise I would have taken the normal
> jdk repo .
>
> Best regards, Matthias
>
> *From:*Langer, Christoph
> *Sent:* Mittwoch, 30. Mai 2018 16:01
> *To:* Baesken, Matthias <matthias.baesken@sap.com>; 2d-dev
> <2d-dev@openjdk.java.net>
> *Subject:* RE: [XS] RFR : JDK-8204085: avoid printing uninitialized
> pointer in
> java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp
>
> Hi Matthias,
>
> maybe the code would become nicer if you do it like this:
>
> ...
>
> jobject localObj = env->NewLocalRef(wsdo->peer);
>
> PDATA pData = localObj == NULL ? NULL : JNI_GET_PDATA(localObj);
>
> if (pData == NULL) {
>
> ...
>
> But the change is very trivial and I would be fine with it, as you did
> in the webrev. Do whatever is more convenient to you, no need for
> another webrev.
>
> And make sure you push it to the client repo...
>
> Best regards
>
> Christoph
>
> *From:*Baesken, Matthias
> *Sent:* Mittwoch, 30. Mai 2018 15:33
> *To:* 2d-dev <2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net>>
> *Cc:* Langer, Christoph <christoph.langer@sap.com
> <mailto:christoph.langer@sap.com>>
> *Subject:* [XS] RFR : JDK-8204085: avoid printing uninitialized
> pointer in
> java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp
>
> Hi could I please get reviews for this very small change :
>
> In
> java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp
> , function GDIWindowSurfaceData_GetComp,
>
> we might print pointer pData in uninitialized state.
>
> This occurs in case localObj == NULL , then we would print pData
> without initialization.
>
> The small fix adds initialization to pData :
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8204085
>
> change :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8204085/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8204085/>
>
> Thanks, Matthias
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Yes, please. And it looks fine. We have an internal static code
analysis tool<br>
which should catch this sort of thing but it is weakest on Windows
..<br>
<br>
-phil.<br>
<br>
On 5/30/18, 7:11 AM, Baesken, Matthias wrote:
<blockquote cite="mid:bd13326a44384b1ba7432e4692439869@sap.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.changed
{mso-style-name:changed;
color:blue;
font-weight:bold;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:2008170652;
mso-list-type:hybrid;
mso-list-template-ids:-42817714 905891192 67567619 67567621 67567617 67567619 \
67567621 67567617 67567619 67567621;} @list l0:level1
{mso-level-start-at:5;
mso-level-number-format:bullet;
mso-level-text:\F0D8;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;
mso-fareast-font-family:Calibri;
mso-bidi-font-family:"Times New Roman";}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi Christoph, Sergey
and Thomas , thanks for the reviews .<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<ul style="margin-top:0cm" type="disc">
<li class="MsoListParagraph"
style="margin-left:0cm;mso-list:l0 level1 lfo1"><span
lang="EN-US">And make sure you push it to the client \
repo…<o:p></o:p></span></li> <li class="MsoListParagraph"
style="margin-left:0cm;mso-list:l0 level1 lfo1"><span
lang="EN-US"><o:p> </o:p></span></li>
</ul>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks for pointing this
out, otherwise I would have taken the normal jdk repo \
.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards, \
Matthias<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:DE" \
lang="EN-US">From:</span></b><span style="mso-fareast-language:DE" lang="EN-US"> \
Langer, Christoph
<br>
<b>Sent:</b> Mittwoch, 30. Mai 2018 16:01<br>
<b>To:</b> Baesken, Matthias
<a class="moz-txt-link-rfc2396E" \
href="mailto:matthias.baesken@sap.com"><matthias.baesken@sap.com></a>; \
2d-dev
<a class="moz-txt-link-rfc2396E" \
href="mailto:2d-dev@openjdk.java.net"><2d-dev@openjdk.java.net></a><br> \
<b>Subject:</b> RE: [XS] RFR : JDK-8204085: avoid printing uninitialized pointer in
java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi Matthias,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">maybe the code would
become nicer if you do it like this:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">...<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">jobject localObj =
env->NewLocalRef(wsdo->peer);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">PDATA pData = localObj
== NULL ? NULL : JNI_GET_PDATA(localObj);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">if (pData == NULL) \
{<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">...<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">But the change is very
trivial and I would be fine with it, as you did in the
webrev. Do whatever is more convenient to you, no need for
another webrev.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">And make sure you push
it to the client repo…<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue
1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:DE" \
lang="EN-US">From:</span></b><span style="mso-fareast-language:DE" lang="EN-US">
Baesken, Matthias
<br>
<b>Sent:</b> Mittwoch, 30. Mai 2018 15:33<br>
<b>To:</b> 2d-dev <<a moz-do-not-send="true"
\
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a>><br> <b>Cc:</b> \
Langer, Christoph <<a moz-do-not-send="true"
\
href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>><br> \
<b>Subject:</b> [XS] RFR : JDK-8204085: avoid printing uninitialized pointer in
java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi could I please
get reviews for this very small change :<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333;background:white"
lang="EN-US">In
java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp
, function GDIWindowSurfaceData_GetComp,
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333;background:white"
lang="EN-US">we might print pointer pData in
uninitialized state. <o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333;background:white"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333;background:white"
lang="EN-US">This occurs in case localObj == NULL , then
we would print pData without \
initialization.<o:p></o:p></span></p> <p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333;background:white"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333;background:white"
lang="EN-US">The small fix adds initialization to
pData :</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Bug:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8204085">https://bugs.openjdk.java.net/browse/JDK-8204085</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">change :<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8204085/">http://cr.openjdk.java.net/~mbaesken/webrevs/8204085/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks, \
Matthias<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic