[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color initialization from standard
From: Jayathirth D V <jayathirth.d.v () oracle ! com>
Date: 2018-04-18 10:04:25
Message-ID: a4f320fa-12a5-43dd-a0f6-756d435d10cf () default
[Download RAW message or body]
Hello All,
Since changes related to JDK-6574555 is pushed.
Please find new webrev which captures test case changes over JDK-6574555.
http://cr.openjdk.java.net/~jdv/5109146/webrev.01/
Thanks,
Jay
From: Jayathirth D V
Sent: Tuesday, April 17, 2018 3:34 PM
To: 2d-dev
Subject: [OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color \
initialization from standard metadata is incomplete
Hello All,
Please review the following fix in JDK11 :
Bug : https://bugs.openjdk.java.net/browse/JDK-5109146
Webrev : http://cr.openjdk.java.net/~jdv/5109146/webrev.00/
Issue: PNGMetadata.mergeStandardTree() function doesn't set proper bKGD colortype.
Solution: When bKGD R, G, B values are unique we need to store appropriate bKGD \
colortype in metadata.
Note : Test case which is present as part of review in JDK-6574555 is only updated to \
handle regression scenario for this bug also. Regression scenario between this bug \
and JDK-6574555 differ only in what type(native/standard) metadata we use to merge \
bKGD RGB values.
Thanks,
Jay
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" \
vlink="#954F72"><div class=WordSection1><p class=MsoNormal>Hello \
All,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Since \
changes related to JDK-6574555 is pushed.<o:p></o:p></p><p class=MsoNormal>Please \
find new webrev which captures test case changes over JDK-6574555.<o:p></o:p></p><p \
class=MsoNormal><a href="http://cr.openjdk.java.net/~jdv/5109146/webrev.01/">http://cr.openjdk.java.net/~jdv/5109146/webrev.01/</a> \
<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Jay<o:p></o:p></p><p \
class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b>From:</b> Jayathirth D V <br><b>Sent:</b> Tuesday, April 17, 2018 \
3:34 PM<br><b>To:</b> 2d-dev<br><b>Subject:</b> [OpenJDK 2D-Dev] [11] RFR \
JDK-5109146: PNGMetadata Background color initialization from standard metadata is \
incomplete<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Hello All,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Please review the following fix in JDK11 :<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Bug : <a \
href="https://bugs.openjdk.java.net/browse/JDK-5109146">https://bugs.openjdk.java.net/browse/JDK-5109146</a> \
<o:p></o:p></p><p class=MsoNormal>Webrev : <a \
href="http://cr.openjdk.java.net/~jdv/5109146/webrev.00/">http://cr.openjdk.java.net/~jdv/5109146/webrev.00/</a> \
<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal><u>Issue:</u> PNGMetadata.mergeStandardTree() function doesn’t \
set proper bKGD colortype.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal><u>Solution:</u> When bKGD R, G, B values are unique we need to store \
appropriate bKGD colortype in metadata.<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><u>Note</u> : Test case which \
is present as part of review in JDK-6574555 is only updated to handle regression \
scenario for this bug also. Regression scenario between this bug and JDK-6574555 \
differ only in what type(native/standard) metadata we use to merge bKGD RGB \
values.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Jay<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic