[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_head
From: Phil Race <philip.race () oracle ! com>
Date: 2018-04-13 19:59:49
Message-ID: 2e82d272-3cda-9786-f5bf-14dd188fc2ec () oracle ! com
[Download RAW message or body]
On 04/13/2018 12:44 PM, Volker Simonis wrote:
>
> Phil Race <philip.race@oracle.com <mailto:philip.race@oracle.com>>
> schrieb am Fr. 13. Apr. 2018 um 19:21:
>
>
> I suppose this potentially helps the concurrency of the build ?
> I can't think of why this would be a problem now there is no
> compile-time linking
> involved and it seems Linux was already fine without this,
> but a jdk-submit would be prudent ..
>
>
> I did start Solaris and AIX builds before I left the office.
That should be sufficient ...
-phil.
> I can certainly also submit a job to JDK-submit, but at least
> hs-submit wasn't working at all (i.e. didn't return any results).
>
>
> -phil.
>
> On 04/13/2018 09:22 AM, Volker Simonis wrote:
> > Hi Erik,
> >
> > thanks for looking at the patch and good catch! You're right
> that the
> > dependency can now be removed. Here's the new webrev:
> >
> > http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524.v1
> <http://cr.openjdk.java.net/%7Esimonis/webrevs/2018/8201524.v1>
> >
> > Regards,
> > Volker
> >
> > On Fri, Apr 13, 2018 at 6:00 PM, Erik Joelsson
> <erik.joelsson@oracle.com <mailto:erik.joelsson@oracle.com>> wrote:
> >> Hello Volker,
> >>
> >> The change looks good, but now that we no longer link against
> >> libawt_headless, we should also remove the make dependency a
> few lines down.
> >> (Should have been done already for Solaris.)
> >>
> >> /Erik
> >>
> >>
> >>
> >> On 2018-04-13 06:28, Volker Simonis wrote:
> >>> Hi,
> >>>
> >>> can I please have a review for this tiny AIX cleanup:
> >>>
> >>> http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524/
> <http://cr.openjdk.java.net/%7Esimonis/webrevs/2018/8201524/>
> >>> https://bugs.openjdk.java.net/browse/JDK-8201524
> >>>
> >>> This is a follow up change of JDK-8196516 which discovered
> that on AIX
> >>> libfontmanager is always linked against libawt_headless at
> build time.
> >>> If we are running in a headfull environment, libfontmanager will
> >>> dynamically load libawt_xawt which is not good because
> libawt_headless
> >>> and libawt_xawt define some common symbols. If we're running in a
> >>> headless environment, libawt_headless may be loaded a second
> time (at
> >>> least on Linux/Solaris) which isn't good either.
> >>>
> >>> Both of these scenarios haven't caused any problems on AIX
> yet, but I
> >>> think it's good to cleanup the AIX implementation as well and
> don't
> >>> link libfontmanager against libawt_headless anymore. In order to
> >>> achieve this, we have to allow unresolved symbols during the
> linking
> >>> of libfontmanager. This can be easily achieved by adding the
> additions
> >>> linker flag "-Wl$(COMMA)-berok" through LDFLAGS_aix. This
> works fine
> >>> for AIX because options which come later on the command line take
> >>> precedence
> >>> over earlier ones.
> >>>
> >>> Thank you and best regards,
> >>> Volker
> >>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 04/13/2018 12:44 PM, Volker Simonis
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+3eh12KW5Mt53eTWCMwB6eZYcx7Nd2Qx1EwxDQ5Tcfoq7tU2w@mail.gmail.com">
<div><br>
<div class="gmail_quote">
<div dir="auto">Phil Race <<a
href="mailto:philip.race@oracle.com"
moz-do-not-send="true">philip.race@oracle.com</a>>
schrieb am Fr. 13. Apr. 2018 um 19:21:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
I suppose this potentially helps the concurrency of the
build ?<br>
I can't think of why this would be a problem now there is no
<br>
compile-time linking<br>
involved and it seems Linux was already fine without this,<br>
but a jdk-submit would be prudent ..<br>
</blockquote>
<div dir="auto"><br>
</div>
<div dir="auto">I did start Solaris and AIX builds before I
left the office. </div>
</div>
</div>
</blockquote>
<br>
That should be sufficient ...<br>
<br>
-phil.<br>
<br>
<blockquote type="cite"
cite="mid:CA+3eh12KW5Mt53eTWCMwB6eZYcx7Nd2Qx1EwxDQ5Tcfoq7tU2w@mail.gmail.com">
<div>
<div class="gmail_quote">
<div dir="auto">I can certainly also submit a job to
JDK-submit, but at least hs-submit wasn't working at all
(i.e. didn't return any results).</div>
<div dir="auto"><br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
-phil.<br>
<br>
On 04/13/2018 09:22 AM, Volker Simonis wrote:<br>
> Hi Erik,<br>
><br>
> thanks for looking at the patch and good catch! You're
right that the<br>
> dependency can now be removed. Here's the new webrev:<br>
><br>
> <a
href="http://cr.openjdk.java.net/%7Esimonis/webrevs/2018/8201524.v1"
rel="noreferrer" target="_blank" \
moz-do-not-send="true">http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524.v1</a><br>
><br>
> Regards,<br>
> Volker<br>
><br>
> On Fri, Apr 13, 2018 at 6:00 PM, Erik Joelsson <<a
href="mailto:erik.joelsson@oracle.com" target="_blank"
moz-do-not-send="true">erik.joelsson@oracle.com</a>>
wrote:<br>
>> Hello Volker,<br>
>><br>
>> The change looks good, but now that we no longer
link against<br>
>> libawt_headless, we should also remove the make
dependency a few lines down.<br>
>> (Should have been done already for Solaris.)<br>
>><br>
>> /Erik<br>
>><br>
>><br>
>><br>
>> On 2018-04-13 06:28, Volker Simonis wrote:<br>
>>> Hi,<br>
>>><br>
>>> can I please have a review for this tiny AIX
cleanup:<br>
>>><br>
>>> <a
href="http://cr.openjdk.java.net/%7Esimonis/webrevs/2018/8201524/"
rel="noreferrer" target="_blank" \
moz-do-not-send="true">http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524/</a><br>
>>> <a
href="https://bugs.openjdk.java.net/browse/JDK-8201524"
rel="noreferrer" target="_blank" \
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8201524</a><br> \
>>><br> >>> This is a follow up change of JDK-8196516 which
discovered that on AIX<br>
>>> libfontmanager is always linked against
libawt_headless at build time.<br>
>>> If we are running in a headfull environment,
libfontmanager will<br>
>>> dynamically load libawt_xawt which is not good
because libawt_headless<br>
>>> and libawt_xawt define some common symbols. If
we're running in a<br>
>>> headless environment, libawt_headless may be
loaded a second time (at<br>
>>> least on Linux/Solaris) which isn't good
either.<br>
>>><br>
>>> Both of these scenarios haven't caused any
problems on AIX yet, but I<br>
>>> think it's good to cleanup the AIX
implementation as well and don't<br>
>>> link libfontmanager against libawt_headless
anymore. In order to<br>
>>> achieve this, we have to allow unresolved
symbols during the linking<br>
>>> of libfontmanager. This can be easily achieved
by adding the additions<br>
>>> linker flag "-Wl$(COMMA)-berok" through
LDFLAGS_aix. This works fine<br>
>>> for AIX because options which come later on the
command line take<br>
>>> precedence<br>
>>> over earlier ones.<br>
>>><br>
>>> Thank you and best regards,<br>
>>> Volker<br>
>><br>
<br>
</blockquote>
</div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic