[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8200129 : Remove D3D Performance Counter.
From:       mandy chung <mandy.chung () oracle ! com>
Date:       2018-03-22 22:39:44
Message-ID: 1a5a54ce-21c0-3c58-a543-47a625d7fb48 () oracle ! com
[Download RAW message or body]

+1

Mandy

On 3/22/18 1:33 PM, Phil Race wrote:
> bug: https://bugs.openjdk.java.net/browse/JDK-8200129
> webrev: http://cr.openjdk.java.net/~prr/8200129/
>
> It was noted in another thread [1] that we had a couple of qualified 
> exports
> from java.base to java.desktop that are platform-specific but are in the
> main module-info.java.
>
> It was suggested to move these to platform-specific locations.
> But one of them doesn't seem to be at all important and we can just 
> remove it.
> It is a "counter" that basically tells you if D3D was used but I don't 
> see any
> standard tools that support it and I was able to build + run just fine.
>
> The other platform-specific export is moved here as suggested since
> it can't be just removed without some alternative.
>
> NB I did build all platforms.
>
> -phil.
>
> [1] 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052198.html


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    +1<br>
    <br>
    Mandy<br>
    <br>
    <div class="moz-cite-prefix">On 3/22/18 1:33 PM, Phil Race wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:3db6c9cd-c68f-d44a-8240-485afc05e905@oracle.com">bug:
      <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8200129">https://bugs.openjdk.java.net/browse/JDK-8200129</a>
  <br>
      webrev: <a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~prr/8200129/">http://cr.openjdk.java.net/~prr/8200129/</a>
  <br>
      <br>
      It was noted in another thread [1] that we had a couple of
      qualified exports
      <br>
      from java.base to java.desktop that are platform-specific but are
      in the
      <br>
      main module-info.java.
      <br>
      <br>
      It was suggested to move these to platform-specific locations.
      <br>
      But one of them doesn't seem to be at all important and we can
      just remove it.
      <br>
      It is a "counter" that basically tells you if D3D was used but I
      don't see any
      <br>
      standard tools that support it and I was able to build + run just
      fine.
      <br>
      <br>
      The other platform-specific export is moved here as suggested
      since
      <br>
      it can't be just removed without some alternative.
      <br>
      <br>
      NB I did build all platforms.
      <br>
      <br>
      -phil.
      <br>
      <br>
      [1]
<a class="moz-txt-link-freetext" \
href="http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052198.html">http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052198.html</a><br>
  </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic