[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createD
From: Jayathirth D V <jayathirth.d.v () oracle ! com>
Date: 2018-01-10 12:00:29
Message-ID: b718ec0b-36d5-49ac-b8ff-7bc8a86a5a7e () default
[Download RAW message or body]
Hi Prahalad,
Change looks good to me.
Thanks,
Jay
From: Brian Burkhalter
Sent: Wednesday, January 10, 2018 6:52 AM
To: Prahalad Kumar Narayanan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at \
BandedSampleModel.createDataBuffer
Hi Prahalad,
On Jan 9, 2018, at 3:42 AM, Prahalad Kumar Narayanan <HYPERLINK \
"mailto:prahalad.kumar.narayanan@oracle.com"prahalad.kumar.narayanan@oracle.com> \
wrote:
BandedSampleModel
L193-196 and 203-207: In general I think it's better for method-internal comments to \
use the "//" form instead of the "/*.*/" form.
My views:
. I find interspersed use of // and /* */ for multi-line comments in our client \
libs code.
. For example: The D3DBlitLoops uses "//" while many parts of Image IO use /* \
... */ for multi-line comments.
. While implementing the fix, I try to maintain uniformity established by the \
file getting modified.
I think that is a good approach.
. In general, I refer to this guideline- \
http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html
For the record I tend to prefer the "//" for intra-method comments as I have found \
that not infrequently in debugging one needs to comment out a section and this is \
much easier to do if the comments in question do not use the "/*.*/" style. I think \
you can leave this one as-is however.
BandedSampleModelSizeTest
Instead of defining the utility methods compareSamples(int[],int[]) and \
initSamples(int[],int) you might consider simply using \
j.u.Arrays.equals(int[],int[]) and j.u.Arrays.fill(int[],int), respectively.
My views:
. Thank you for the suggestion. It helped.
. I 've modified the test code to use Arrays.fill and Arrays.equals methods.
The modified code is now available for review under
Link: http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.01/
Kindly review at your convenience and share your thoughts.
I think this looks OK.
Thanks,
Brian
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Hi \
Prahalad,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Change looks \
good to me.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Jay<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif'> Brian Burkhalter \
<br><b>Sent:</b> Wednesday, January 10, 2018 6:52 AM<br><b>To:</b> Prahalad Kumar \
Narayanan<br><b>Cc:</b> 2d-dev<br><b>Subject:</b> Re: [OpenJDK 2D-Dev] [11] RFR: \
[JDK-8194489] Incorrect size computation at \
BandedSampleModel.createDataBuffer<o:p></o:p></span></p></div></div><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Hi \
Prahalad,<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p><div><div><p \
class=MsoNormal>On Jan 9, 2018, at 3:42 AM, Prahalad Kumar Narayanan <<a \
href="mailto:prahalad.kumar.narayanan@oracle.com">prahalad.kumar.narayanan@oracle.com</a>> \
wrote:<o:p></o:p></p></div><p class=MsoNormal><br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt;orphans: auto;text-align:start;widows: \
auto;-webkit-text-stroke-width: 0px;word-spacing:0px'><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'>BandedSampleModel<br>L193-196 \
and 203-207: In general I think it's better for method-internal comments to use the \
"//" form instead of the "/*.*/" \
form.<o:p></o:p></span></p></blockquote><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'> My \
views:<br> . I find interspersed use of // and /* */ for \
multi-line comments in our client libs code.<br> . For \
example: The D3DBlitLoops uses "//" while many parts of Image IO use /* ... \
*/ for multi-line comments.<br> . While implementing the \
fix, I try to maintain uniformity established by the file getting \
modified.</span><o:p></o:p></p></blockquote><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>I think that is a \
good approach.<o:p></o:p></p></div><p \
class=MsoNormal><br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'> . \
In general, I refer to this guideline-<span \
class=apple-converted-space> </span></span><a \
href="http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html"><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'>http://cr.openjdk.java.net/ \
~alundblad/styleguide/index-v6.html</span></a><o:p></o:p></p></blockquote><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>For the record I \
tend to prefer the “//“ for intra-method comments as I have found that \
not infrequently in debugging one needs to comment out a section and this is much \
easier to do if the comments in question do not use the “/*…*/“ \
style. I think you can leave this one as-is however.<o:p></o:p></p></div><p \
class=MsoNormal><br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt;orphans: auto;text-align:start;widows: \
auto;-webkit-text-stroke-width: 0px;word-spacing:0px'><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'>BandedSampleModelSizeTest<br>Instead \
of defining the utility methods compareSamples(int[],int[]) and \
initSamples(int[],int)<span class=apple-converted-space> </span><br>you might \
consider simply using j.u.Arrays.equals(int[],int[]) and j.u.Arrays.fill(int[],int), \
respectively. <o:p></o:p></span></p></blockquote><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'> My \
views:<br> . Thank you for the suggestion. It \
helped.<br> . I 've modified the test code to use \
Arrays.fill and Arrays.equals methods.<br><br>The modified code is now available for \
review under<br>Link:<span class=apple-converted-space> </span></span><a \
href="http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.01/"><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'>http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.01/</span></a><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'><br><br>Kindly review at \
your convenience and share your thoughts.</span><o:p></o:p></p></blockquote></div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>I think this looks \
OK.<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>Thanks,<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>Brian<o:p></o:p></p></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic