[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE sect
From: Jayathirth D V <jayathirth.d.v () oracle ! com>
Date: 2017-12-26 7:48:35
Message-ID: f41e893f-0003-4937-a8a0-8da35ace41df () default
[Download RAW message or body]
Hi Brian,
Thanks for your inputs.
I have made changes mentioned by you and will check-in code with your changes.
Please find updated webrev for reference:
http://cr.openjdk.java.net/~jdv/8190997/webrev.03/
Thanks,
Jay
From: Brian Burkhalter
Sent: Wednesday, December 20, 2017 12:59 AM
To: Jayathirth D V
Cc: Sergey Bylokhov; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws \
NullPointerException when PLTE section is missing
I concur but you might consider these changes to some verbiage:
* PNGImageReader:
L741 PNG specification -> "The PNG specification"
L744 "PLTE chunk -> "the PLTE chunk"
L749-750 message -> "Required PLTE chunk missing"
* PngPLTEChunkMissingTest
L64 Change message to match PNGImageReader lines 749-750.
Thanks,
Brian
On Dec 18, 2017, at 11:03 PM, Sergey Bylokhov <HYPERLINK \
"mailto:Sergey.Bylokhov@oracle.com"Sergey.Bylokhov@oracle.com> wrote:
The .02 version looks fine.
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-tab-span
{mso-style-name:apple-tab-span;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Hi \
Brian,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks for \
your inputs.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I have made \
changes mentioned by you and will check-in code with your \
changes.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Please find \
updated webrev for reference:<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><a \
href="http://cr.openjdk.java.net/~jdv/8190997/webrev.03/">http://cr.openjdk.java.net/~jdv/8190997/webrev.03/</a> \
<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Jay<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif'> Brian Burkhalter \
<br><b>Sent:</b> Wednesday, December 20, 2017 12:59 AM<br><b>To:</b> Jayathirth D \
V<br><b>Cc:</b> Sergey Bylokhov; 2d-dev<br><b>Subject:</b> Re: [OpenJDK 2D-Dev] [10] \
RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is \
missing<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>I concur but you might consider these changes to some \
verbiage:<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>* PNGImageReader:<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>L741<span \
class=apple-tab-span> </span>PNG specification \
-> “The PNG specification”<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>L744<span \
class=apple-tab-span> </span>“PLTE chunk \
-> “the PLTE chunk”<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>L749-750<span \
class=apple-tab-span> </span>message -> \
“Required PLTE chunk missing”<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>* \
PngPLTEChunkMissingTest<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>L64<span \
class=apple-tab-span> \
</span>Change message to match PNGImageReader lines \
749-750.<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>Thanks,<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>Brian<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Dec 18, 2017, at \
11:03 PM, Sergey Bylokhov <<a \
href="mailto:Sergey.Bylokhov@oracle.com">Sergey.Bylokhov@oracle.com</a>> \
wrote:<o:p></o:p></p></div><p class=MsoNormal><br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Helvetica",sans-serif'>The .02 version looks \
fine.</span><o:p></o:p></p></blockquote></div><p \
class=MsoNormal><o:p> </o:p></p></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic