[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0
From: Kevin Rushforth <kevin.rushforth () oracle ! com>
Date: 2017-12-11 17:13:06
Message-ID: 5A2EBCA2.5010000 () oracle ! com
[Download RAW message or body]
I started looking the FX patch on Friday. I hope to finish my review today.
-- Kevin
Philip Race wrote:
> Yes, I approved the 2D patch. I have not yet looked at the FX version.
>
> -phil
>
> On 12/10/17, 12:39 PM, Laurent Bourgès wrote:
>> Phil,
>>
>> Thanks for your review.
>>
>> I suppose you approved the Java2D patch for the RFR thread: [10] RFR
>> JDK-8191814:
>> http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008741.html
>>
>> I will push tomorrow to jdk forrest as phil & sergey? approved 2D
>> changes.
>>
>>
>> This RFR thread remains open for the JavaFX patch that Kevin started
>> to test & review.
>>
>> Cheers,
>> Laurent
>>
>> 2017-12-10 18:36 GMT+01:00 Philip Race <philip.race@oracle.com
>> <mailto:philip.race@oracle.com>>:
>>
>> I'm giving this an OK.
>> I've looked at the code, if not the maths, and run our regression
>> test suite.
>> I had a bit of trouble with my full baseline run against which to
>> compare so I've
>> re-run just the test failures that seem like they might go
>> anywhere need this code.
>> and they were pre-existing.
>>
>> -phil.
>>
>>
>> On 11/16/17, 3:01 PM, Laurent Bourgès wrote:
>>> Phil,
>>>
>>> Here is an updated webrev:
>>> http://cr.openjdk.java.net/~lbourges/marlin/marlin-082-8184429.1/
>>> <http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-082-8184429.1/>
>>>
>>> It fixes the ClipShapeTest to run ~35s (< 2mins) on my latop: 22
>>> test setups only (5000 random polygons each) that covers all
>>> aspects of the new clipping algorithm.
>>>
>>> I wonder if I should remove the 'slow' mode that has till @ignore:
>>> both tests are ignored if I run jtreg -ignore:quiet although I
>>> would like to only ignore the @ignore run (1/2).
>>>
>>>
>>> Once again, I have to create a new JBS bug for Marlin2D tomorrow
>>> then start a new RFR with a complete change log.
>>>
>>> Laurent
>>>
>>> 2017-11-16 10:50 GMT+01:00 Laurent Bourgès
>>> <bourges.laurent@gmail.com <mailto:bourges.laurent@gmail.com>>:
>>>
>>> Sergey,
>>>
>>> You can generate a number of images using a few threads
>>> when the flag is on then switch it off and compares
>>> results. The test should not draw different(on/off)
>>> modes in parallel but it can draw the images for the
>>> same mode.
>>>
>>>
>>> Yes that is always possible but I do not want to spend too
>>> much time improving the test to parallelize it.
>>>
>>> I fixed it last night and it runs only 22 test setups (1
>>> stroke width = 8px, no dashes) and takes ~ 30 seconds on my
>>> laptop (single-thread).
>>> I verified that any bug in Marlin clipping is detected by
>>> this new variant of the tests.
>>> Will provide a new patch asap.
>>>
>>>
>>>
>>> Finally I will minimize the number of stroker tests:
>>> use only 1 stroke width (=5px) and that should be
>>> enough to stay below timeout (2mins).
>>>
>>>
>>> Note that the test can be run on some slow/virtual
>>> systems, it would be good to have some additional time.
>>>
>>> Is there any documentation about jtreg tags ?
>>>
>>>
>>> You can find it here:
>>> http://openjdk.java.net/jtreg/tag-spec.html
>>> <http://openjdk.java.net/jtreg/tag-spec.html>
>>>
>>>
>>> Thanks.
>>>
>>> Laurent
>>>
>>>
>>>
>>>
>>> --
>>> --
>>> Laurent Bourgès
>>
>>
>>
>>
>> --
>> --
>> Laurent Bourgès
[Attachment #3 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
I started looking the FX patch on Friday. I hope to finish my review
today.<br>
<br>
-- Kevin<br>
<br>
<br>
Philip Race wrote:
<blockquote cite="mid:5A2EBAF3.9080003@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Yes, I approved the 2D patch. I have not yet looked at the FX version.<br>
<br>
-phil<br>
<br>
On 12/10/17, 12:39 PM, Laurent Bourgès wrote:
<blockquote
cite="mid:CAKjRUT6VmLtbas-eg+A8a=rJcBdxDdkk-BiX6fROUYOkXwawQA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>Phil,<br>
<br>
</div>
Thanks for your review.<br>
<br>
</div>
I suppose you approved the Java2D patch for the RFR thread: [10] RFR
JDK-8191814:<br>
<a moz-do-not-send="true"
href="http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008741.html">http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008741.html</a><br>
<div>
<div><br>
</div>
<div>I will push tomorrow to jdk forrest as phil & sergey?
approved 2D changes.</div>
<div><br>
</div>
<div><br>
</div>
<div>This RFR thread remains open for the JavaFX patch that Kevin
started to test & review.</div>
<div><br>
</div>
<div>Cheers,<br>
</div>
<div>Laurent<br>
</div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-12-10 18:36 GMT+01:00 Philip Race <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>></span>:<br> <blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0px \
0px 0px 0.8ex; padding-left: 1ex;"> <div bgcolor="#FFFFFF"> I'm giving this an \
OK.<br> I've looked at the code, if not the maths, and run our regression test
suite.<br>
I had a bit of trouble with my full baseline run against which to
compare so I've<br>
re-run just the test failures that seem like they might go anywhere
need this code.<br>
and they were pre-existing.<span class="gmail-HOEnZb"><font
color="#888888"><br>
<br>
-phil.</font></span>
<div>
<div class="gmail-h5"><br>
<br>
On 11/16/17, 3:01 PM, Laurent Bourgès wrote:
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>Phil,<br>
<br>
</div>
Here is an updated webrev:<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-082-8184429.1/"
target="_blank">http://cr.openjdk.java.net/~<wbr>lbourges/marlin/marlin-082-<wbr>8184429.1/</a><br>
<br>
</div>
It fixes the ClipShapeTest to run ~35s (< 2mins) on my latop: 22
test setups only (5000 random polygons each) that covers all aspects of
the new clipping algorithm. <br>
</div>
<div><br>
</div>
<div>I wonder if I should remove the 'slow' mode that has till
@ignore:</div>
<div>both tests are ignored if I run jtreg -ignore:quiet
although I would like to only ignore the @ignore run (1/2).<br>
</div>
<div><br>
</div>
<div><br>
</div>
Once again, I have to create a new JBS bug for Marlin2D tomorrow then
start a new RFR with a complete change log.<br>
<br>
</div>
</div>
Laurent<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-11-16 10:50 GMT+01:00 Laurent
Bourgès <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:bourges.laurent@gmail.com" \
target="_blank">bourges.laurent@gmail.com</a>></span>:<br> <blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0px \
0px 0px 0.8ex; padding-left: 1ex;"> <div dir="ltr">Sergey,<br>
<br>
<span></span><span></span>
<div class="gmail_extra">
<div class="gmail_quote"><span>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; \
padding-left: 1ex;"> You can generate a number of images using a few threads when the \
flag is on then switch it off and compares results. The test should not draw
different(on/off) modes in parallel but it can draw the images for the
same mode.<span><br>
</span></blockquote>
<div><br>
</div>
</span>
<div>Yes that is always possible but I do not want to spend
too much time improving the test to parallelize it.</div>
<div><br>
</div>
<div>I fixed it last night and it runs only 22 test setups (1
stroke width = 8px, no dashes) and takes ~ 30 seconds on my laptop
(single-thread). <br>
</div>
<div>I verified that any bug in Marlin clipping is detected
by this new variant of the tests.</div>
<div>Will provide a new patch asap.<br>
</div>
<span>
<div> </div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; \
padding-left: 1ex;"><span> <br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; \
padding-left: 1ex;"> Finally I will minimize the number of stroker tests: use only 1 \
stroke width (=5px) and that should be enough to stay below timeout (2mins).<br>
</blockquote>
<br>
</span> Note that the test can be run on some slow/virtual
systems, it would be good to have some additional time.<span><br>
<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; \
padding-left: 1ex;"> Is there any documentation about jtreg tags ?<br>
</blockquote>
<br>
</span> You can find it here:<br>
<a moz-do-not-send="true"
href="http://openjdk.java.net/jtreg/tag-spec.html" rel="noreferrer"
target="_blank">http://openjdk.java.net/jtreg/<wbr>tag-spec.html</a><span
class="gmail-m_-1120040164424258786m_-4692043361937150257HOEnZb"><font
color="#888888"><br>
</font></span></blockquote>
<div><br>
</div>
</span>
<div>Thanks.</div>
<span class="gmail-m_-1120040164424258786HOEnZb"><font
color="#888888">
<div><br>
</div>
<div>Laurent</div>
</font></span></div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div class="gmail-m_-1120040164424258786gmail_signature">-- <br>
Laurent Bourgès</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div class="gmail_signature">-- <br>
Laurent Bourgès</div>
</div>
</div>
</div>
</div>
</blockquote>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic