[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0
From:       Laurent_Bourgès <bourges.laurent () gmail ! com>
Date:       2017-11-16 23:01:37
Message-ID: CAKjRUT6Ai5j2SVifkuBGmjM+PjRwLETq8g3cdCHjy=YjYHuczw () mail ! gmail ! com
[Download RAW message or body]

Phil,

Here is an updated webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-082-8184429.1/

It fixes the ClipShapeTest to run ~35s (< 2mins) on my latop: 22 test
setups only (5000 random polygons each) that covers all aspects of the new
clipping algorithm.

I wonder if I should remove the 'slow' mode that has till @ignore:
both tests are ignored if I run jtreg -ignore:quiet although I would like
to only ignore the @ignore run (1/2).


Once again, I have to create a new JBS bug for Marlin2D tomorrow then start
a new RFR with a complete change log.

Laurent

2017-11-16 10:50 GMT+01:00 Laurent Bourgès <bourges.laurent@gmail.com>:

> Sergey,
>
> You can generate a number of images using a few threads when the flag is
>> on then switch it off and compares results. The test should not draw
>> different(on/off) modes in parallel but it can draw the images for the same
>> mode.
>>
>
> Yes that is always possible but I do not want to spend too much time
> improving the test to parallelize it.
>
> I fixed it last night and it runs only 22 test setups (1 stroke width =
> 8px, no dashes) and takes ~ 30 seconds on my laptop (single-thread).
> I verified that any bug in Marlin clipping is detected by this new variant
> of the tests.
> Will provide a new patch asap.
>
>
>>
>> Finally I will minimize the number of stroker tests: use only 1 stroke
>>> width (=5px) and that should be enough to stay below timeout (2mins).
>>>
>>
>> Note that the test can be run on some slow/virtual systems, it would be
>> good to have some additional time.
>>
>> Is there any documentation about jtreg tags ?
>>>
>>
>> You can find it here:
>> http://openjdk.java.net/jtreg/tag-spec.html
>>
>
> Thanks.
>
> Laurent
>



-- 
-- 
Laurent Bourgès

[Attachment #3 (text/html)]

<div dir="ltr"><div><div><div><div><div>Phil,<br><br></div>Here is an updated \
webrev:<br><a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-082-8184429.1/" \
>http://cr.openjdk.java.net/~lbourges/marlin/marlin-082-8184429.1/</a><br><br></div>It \
> fixes the ClipShapeTest to run ~35s (&lt; 2mins) on my latop: 22 test setups only \
> (5000 random polygons each) that covers all aspects of the new clipping algorithm. \
> <br></div><div><br></div><div>I wonder if I should remove the &#39;slow&#39; mode \
> that has till @ignore:</div><div>both tests are ignored if I run jtreg \
> -ignore:quiet although I would like to only ignore the @ignore run \
> (1/2).<br></div><div><br></div><div><br></div>Once again, I have to create a new \
> JBS bug for Marlin2D tomorrow then start a new RFR with a complete change \
> log.<br><br></div></div>Laurent<br></div><div class="gmail_extra"><br><div \
> class="gmail_quote">2017-11-16 10:50 GMT+01:00 Laurent Bourgès <span \
> dir="ltr">&lt;<a href="mailto:bourges.laurent@gmail.com" \
> target="_blank">bourges.laurent@gmail.com</a>&gt;</span>:<br><blockquote \
> class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
> solid;padding-left:1ex"><div \
> dir="ltr">Sergey,<br><br><span></span><span></span><div class="gmail_extra"><div \
> class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0 \
> 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
You can generate a number of images using a few threads when the flag is on then \
switch it off and compares results. The test should not draw different(on/off) modes \
in parallel but it can draw the images for the same \
mode.<span><br></span></blockquote><div><br></div></span><div>Yes that is always \
possible but I do not want to spend too much time improving the test to parallelize \
it.</div><div><br></div><div>I fixed it last night and it runs only 22 test setups (1 \
stroke width = 8px, no dashes) and takes ~ 30 seconds on my laptop (single-thread). \
<br></div><div>I verified that any bug in Marlin clipping is detected by this new \
variant of the tests.</div><div>Will provide a new patch asap.<br></div><span \
class=""><div>  </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span> <br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

Finally I will minimize the number of stroker tests: use only 1 stroke width (=5px) \
and that should be enough to stay below timeout (2mins).<br> </blockquote>
<br></span>
Note that the test can be run on some slow/virtual systems, it would be good to have \
some additional time.<span><br> <br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

Is there any documentation about jtreg tags ?<br>
</blockquote>
<br></span>
You can find it here:<br>
<a href="http://openjdk.java.net/jtreg/tag-spec.html" rel="noreferrer" \
target="_blank">http://openjdk.java.net/jtreg/<wbr>tag-spec.html</a><span \
class="m_-4692043361937150257HOEnZb"><font \
color="#888888"><br></font></span></blockquote><div><br></div></span><div>Thanks.</div><span \
class="HOEnZb"><font \
color="#888888"><div><br></div><div>Laurent</div></font></span></div></div></div> \
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" \
data-smartmail="gmail_signature">-- <br>Laurent Bourgès</div> </div>



[prev in list] [next in list] [prev in thread] [next in thread]