[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8186306: Remove pisces from Java2D sources + build.
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2017-11-13 23:44:23
Message-ID: 639f47c1-75d3-1aae-a447-54aacf68f1a0 () oracle ! com
[Download RAW message or body]

Looks fine.
I guess we should do same cleanup in the closed repo as well.

On 07/11/2017 15:08, Philip Race wrote:
> bug: https://bugs.openjdk.java.net/browse/JDK-8186306
> webrev: http://cr.openjdk.java.net/~prr/8186306/
> 
> This fix removes the pisces rasterizer code since it is superseded by 
> marlin.
> 
> In addition it removes the (always) un-used Jules code from the Xrender 
> pipe-line.
> 
> This code has never been enabled as it relied on a special version of 
> Cairo.
> 
> It could have been kept by making MarlinRenderingEngine non-final and
> extending that instead, but after discussion with Clemens (author of the
> xrender pipeline) it is decided to remove it too.
> 
> I have built on all platforms and tested on Linux with Xrender to make sure
> there was no breakage from this removal.
> 
> Additionally I have re-moved "pisces" directories from the test hierarchy
> and moved the tests there under the marlin   directory as seemed 
> appropriate.
> These tests are all valid as tests for marlin too.
> 
> One test had a system property to invoke pisces removed.
> 
> -phil


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]