[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190512: PngReader incorrectly throws IllegalArgumentException for
From: Phil Race <philip.race () oracle ! com>
Date: 2017-11-13 18:23:08
Message-ID: 92531bcb-4ab2-4150-837f-4c78d118274e () oracle ! com
[Download RAW message or body]
+1
-phil
On 11/13/2017 08:27 AM, Brian Burkhalter wrote:
> Hi Jay,
>
> Looks good.
>
> Thanks,
>
> Brian
>
> On Nov 10, 2017, at 12:31 AM, Jayathirth D V
> <jayathirth.d.v@oracle.com <mailto:jayathirth.d.v@oracle.com>> wrote:
>
>> IHDR height also.
>> And he also clarified from his side that there are no copyright issues.
>> I have updated the test case to check for negative width and negative
>> height input.
>> Please find updated webrev for review:
>> http://cr.openjdk.java.net/~jdv/8190512/webrev.01/
>> <http://cr.openjdk.java.net/%7Ejdv/8190512/webrev.01/>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
+1<br>
<br>
-phil<br>
<br>
<div class="moz-cite-prefix">On 11/13/2017 08:27 AM, Brian
Burkhalter wrote:<br>
</div>
<blockquote type="cite"
cite="mid:175D3020-A7BB-44DB-8E55-D088ED9CC738@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Hi Jay,
<div><br>
</div>
<div>Looks good.</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Brian</div>
<div><br>
<div style="">
<div>On Nov 10, 2017, at 12:31 AM, Jayathirth D V <<a
href="mailto:jayathirth.d.v@oracle.com"
moz-do-not-send="true">jayathirth.d.v@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="margin: 0in 0in 0.0001pt; font-size: 12pt;
font-family: 'Times New Roman', serif; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;"><span style="font-size:
11pt; font-family: Calibri, sans-serif; color: rgb(31,
73, 125);">IHDR height also.<o:p></o:p></span></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 12pt;
font-family: 'Times New Roman', serif; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;"><span style="font-size:
11pt; font-family: Calibri, sans-serif; color: rgb(31,
73, 125);">And he also clarified from his side that
there are no copyright issues.<o:p></o:p></span></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 12pt;
font-family: 'Times New Roman', serif; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;"><span style="font-size:
11pt; font-family: Calibri, sans-serif; color: rgb(31,
73, 125);"> </span></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 12pt;
font-family: 'Times New Roman', serif; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;"><span style="font-size:
11pt; font-family: Calibri, sans-serif; color: rgb(31,
73, 125);">I have updated the test case to check for
negative width and negative height input.<o:p></o:p></span></div>
<div style="margin: 0in 0in 0.0001pt; font-size: 12pt;
font-family: 'Times New Roman', serif; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;"><span style="font-size:
11pt; font-family: Calibri, sans-serif; color: rgb(31,
73, 125);">Please find updated webrev for \
review:<o:p></o:p></span></div> <div style="margin: 0in 0in 0.0001pt; font-size: \
12pt; font-family: 'Times New Roman', serif; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;"><span style="font-size:
11pt; font-family: Calibri, sans-serif; color: rgb(31,
73, 125);"><a
href="http://cr.openjdk.java.net/%7Ejdv/8190512/webrev.01/"
style="color: purple; text-decoration: underline;"
moz-do-not-send="true">http://cr.openjdk.java.net/~jdv/8190512/webrev.01/</a></span></div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic