[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: [OpenJDK 2D-Dev] [10] Review Request JDK - 8164811 : [hidpi]Tests fail with OpenGL Rendering
From: Pankaj Bansal <pankaj.b.bansal () oracle ! com>
Date: 2017-10-31 11:59:21
Message-ID: 4d69560c-370c-471d-864f-c0a0ff59387d () default
[Download RAW message or body]
Hi All,
Please review the fix for JDK 10.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8164811
Webrev:
http://cr.openjdk.java.net/~pbansal/8164811/webrev.00/
Issue:
The tests given in the bug were failing when run with OpenGL and GDI. This bug is \
related to https://bugs.openjdk.java.net/browse/JDK-8189257 which states that that \
HIDPI does not work with swing components when Translucent window is used. Because of \
which all the tests in the bug were failing.
Fix:
The TranslucentWindowPainter class was creating BufferedImage for OpenGL (when \
forceOpt is false) and GDI pipeline, but it is not considering the device HiDPI \
scale. There is no way to create a scaled BufferedImage because of which the scale \
value in BufImgSurfaceData is always 1. Made changes to store graphics config in \
Buffered image, so that the BufImgSurfaceManager can create BufImgSurfaceData with \
scale set properly.
This fix also fixes https://bugs.openjdk.java.net/browse/JDK-8189257
Regards,
Pankaj Bansal
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:129130379;
mso-list-type:hybrid;
mso-list-template-ids:-539963286 67698703 67698713 67698715 67698703 67698713 \
67698715 67698703 67698713 67698715;} @list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" \
vlink="#954F72"><div class=WordSection1><p class=MsoNormal>Hi All,<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Please review the fix for JDK \
10.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p \
class=MsoNormal>Bug:<o:p></o:p></p><p class=MsoNormal><a \
href="https://bugs.openjdk.java.net/browse/JDK-8164811">https://bugs.openjdk.java.net/browse/JDK-8164811</a><o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Webrev:<o:p></o:p></p><p \
class=MsoNormal><span style='color:#1F497D'> <a \
href="http://cr.openjdk.java.net/~pbansal/8164811/webrev.00/">http://cr.openjdk.java.net/~pbansal/8164811/webrev.00/</a><o:p></o:p></span></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Issue:<o:p></o:p></p><p \
class=MsoNormal>The tests given in the bug were failing when run with OpenGL and \
GDI. This bug is related to <a \
href="https://bugs.openjdk.java.net/browse/JDK-8189257">https://bugs.openjdk.java.net/browse/JDK-8189257</a> \
which states that that HIDPI does not work with swing components when Translucent \
window is used. Because of which all the tests in the bug were \
failing.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p \
class=MsoNormal>Fix:<o:p></o:p></p><pre style='background:white'><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>The \
TranslucentWindowPainter class was creating BufferedImage for OpenGL (when \
<i>forceOpt</i> is false) and GDI pipeline, but it is not considering the device \
HiDPI scale. There is no way to create a scaled BufferedImage because of which the \
scale value in BufImgSurfaceData is always 1. Made changes to store graphics config \
in Buffered image, so that the BufImgSurfaceManager can create BufImgSurfaceData with \
scale set properly.<o:p></o:p></span></pre><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>This fix also fixes <a \
href="https://bugs.openjdk.java.net/browse/JDK-8189257">https://bugs.openjdk.java.net/browse/JDK-8189257</a><o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Regards,<o:p></o:p></p><p \
class=MsoNormal>Pankaj Bansal<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic