[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [10] Review Request: 8184435 Cleanup of javadoc in javax.print package
From: Phil Race <philip.race () oracle ! com>
Date: 2017-08-25 20:11:51
Message-ID: 969cfab4-3242-d46e-256a-c89253eca854 () oracle ! com
[Download RAW message or body]
I don't see that this changes the spec. in a way that needs a CSR.
So I'll review it but it is possible that you may be told it can be
withdrawn as unnecessary.
FYI I reviewed this mostly by reading the specdiff so I wasn't looking
directly at source only changes like line length.
I'm not sure how much I like or think some necessary, a few changes such
as from "InputStream" to "input stream" and the like but I don't object
strongly enough to suggest they be amended ..
Minor nit in the change.
In DocFlavor I think "a string" would be better than "the string"
488 * @return the string representing a mime parameter, or {@code null}
if that -phil.
On 08/24/2017 06:02 PM, Sergey Bylokhov wrote:
> Hello.
>
> CSR is created:
> https://bugs.openjdk.java.net/browse/JDK-8186753
>
> On 21.08.17 20:03, Sergey Bylokhov wrote:
>> On 13.08.2017 23:23, Prasanta Sadhukhan wrote:
>>> In that case, will this be required to have 2nd part?
>>>
>>> 43 * {@link DocFlavor DocFlavor}
>>> There are manyof them in other files too like DocFlavor.java
>>> 1206 * stream ({@link java.io.Reader java.io.Reader} Other than
>>> that, it looks ok to me (btw, I have not gone through each and every
>>> file).
>>
>> The second part is needed(at least we use it) when the class name is
>> used, but "{@link javax.print.attribute}" is a package.
>>
>> If there are no more objections from others I'll create a CSR based
>> on this webrev.
>>
>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
I don't see that this changes the spec. in a way that needs a CSR.<br>
So I'll review it but it is possible that you may be told it can be<br>
withdrawn as unnecessary.<br>
<br>
<br>
FYI I reviewed this mostly by reading the specdiff so I wasn't
looking<br>
directly at source only changes like line length.<br>
<br>
I'm not sure how much I like or think some necessary, a few changes
such<br>
as from "InputStream" to "input stream" and the like but I don't
object<br>
strongly enough to suggest they be amended ..<br>
<br>
Minor nit in the change.<br>
<br>
In DocFlavor I think "a string" would be better than "the string"<br>
<pre><span class="changed">488 * @return the string representing a mime \
parameter, or {@code null} if that
-phil.
</span></pre>
<div class="moz-cite-prefix">On 08/24/2017 06:02 PM, Sergey Bylokhov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:de0d4a0d-83fd-f687-2f56-a786599a35fe@oracle.com">Hello.
<br>
<br>
CSR is created:
<br>
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8186753">https://bugs.openjdk.java.net/browse/JDK-8186753</a>
<br>
<br>
On 21.08.17 20:03, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">On 13.08.2017 23:23, Prasanta Sadhukhan
wrote:
<br>
<blockquote type="cite">In that case, will this be required to
have 2nd part?
<br>
<br>
43 * {@link DocFlavor DocFlavor}
<br>
There are manyof them in other files too like DocFlavor.java
<br>
1206 * stream ({@link java.io.Reader java.io.Reader} Other
than that, it looks ok to me (btw, I have not gone through
each and every file). </blockquote>
<br>
The second part is needed(at least we use it) when the class
name is used, but <a class="moz-txt-link-rfc2396E" \
href="mailto:{@linkjavax.print.attribute}">"{@link javax.print.attribute}"</a> is a \
package. <br>
<br>
If there are no more objections from others I'll create a CSR
based on this webrev.
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic