[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming
From: Laurent_Bourgès <bourges.laurent () gmail ! com>
Date: 2017-08-18 19:21:50
Message-ID: CAKjRUT7QV5y9FuD-VWyFHuOShhVd-F9boBYTjEDdZ41NjDgdLA () mail ! gmail ! com
[Download RAW message or body]
Thanks,
Laurent
Le 18 ao=C3=BBt 2017 7:29 PM, "Phil Race" <philip.race@oracle.com> a =C3=A9=
crit :
> CSR was approved and I have pushed the new API.
>
> -phil.
>
> On 08/17/2017 08:31 AM, Philip Race wrote:
>
> I have filed https://bugs.openjdk.java.net/browse/JDK-8186364
> and created and submitted the CSR for it :
> https://bugs.openjdk.java.net/browse/JDK-8186365
>
> -phil.
>
> On 8/17/17, 8:05 AM, Philip Race wrote:
>
> OK I'll handle the bureaucracy.
>
> -phil.
>
> On 8/17/17, 7:31 AM, Laurent Bourg=C3=A8s wrote:
>
> Phil,
> Thanks for the explanations.
>
> I am not at home until next week so I would prefer if you can create the
> new CSR and related bugs.
> As I said, this patch was reviewed and I want it to be pushed in jdk10
> finally.
>
> PS: I worked again on Marlin to implement an efficient path clipper that
> is working well and very promising performance.
>
> Cheers,
> Laurent
>
>
> Le 17 ao=C3=BBt 2017 00:33, "Phil Race" <philip.race@oracle.com> a =C3=A9=
crit :
>
>> It seems we are going to have to file a completely new bug for this.
>> It is not just a case of your permissions. The migrated "CCC" can't be
>> set to fix version 10.
>> So Joe Darcy suggested creating a backport targeted to 10 and creating a
>> CSR from that
>> but it turns out backports can't have CSRs. Joe was a bit surprised by
>> that.
>>
>> So
>> 1) create a new bug which references and largely duplicates the original
>> one
>> 2) Create a CSR for JDK 10 for that.
>> 3) Close the original bug as dup. of the new one.
>> 4) Get CSR approval and push under the new bug id.
>> We won't need to do a new code review. Just update the bugs with pointer=
s
>> to email threads explaining the relationship.
>>
>> If you want I can handle this hassle but if you want to do it you can to=
o.
>>
>>
>> -phil.
>>
>> On 08/11/2017 05:29 AM, Laurent Bourg=C3=A8s wrote:
>>
>> Ping ?
>> In holidays ?
>>
>> Le 13 juil. 2017 9:36 AM, "Laurent Bourg=C3=A8s" <bourges.laurent@gmail.=
com>
>> a =C3=A9crit :
>>
>>> Jim or Phil,
>>> Could you handle the CSR process on that patch and then push it in jdk1=
0
>>> ?
>>>
>>> I consider that bug finished on my side.
>>>
>>> Laurent
>>>
>>> Le 8 juil. 2017 10:02, "Laurent Bourg=C3=A8s" <bourges.laurent@gmail.co=
m> a
>>> =C3=A9crit :
>>>
>>>> Phil,
>>>>
>>>> Here are my comments on this CSR to be fixed in openjdk 10; I already
>>>> submitted a patch and the review process happened in may.
>>>>
>>>> Le 3 juil. 2017 7:41 PM, "Phil Race" <philip.race@oracle.com> a =C3=A9=
crit :
>>>>
>>>> Laurent,
>>>>
>>>> Investigation has determined that since this was ported over in the
>>>> "CCC migration project",
>>>> due to the way that is set up it can't be assigned to non-Oracle
>>>> employees.
>>>>
>>>>
>>>> Ok, no problem.
>>>>
>>>>
>>>> It won't affect any new CSRs that are created.
>>>>
>>>> Since the likelihood of any other similar case is extremely low, the
>>>> simplest answer is
>>>> that either Jim or myself will need to own and edit this one on your
>>>> behalf.
>>>>
>>>> Send Jim or myself the changes you would like to make off-line and
>>>> we'll take care of it.
>>>>
>>>>
>>>> Just change the fix version to 10 and the @since javadoc tag as below:
>>>>
>>>> /**
>>>> * Trims the capacity of this Path2D instance to its current
>>>> * size. An application can use this operation to minimize the
>>>> * storage of a path.
>>>> *
>>>> * @since 10
>>>> */ + public abstract void trimToSize();
>>>>
>>>> It will match the proposed patch.
>>>>
>>>> Thanks,
>>>> Laurent
>>>>
>>>>
>>>>
>>>>>>> 2017-04-20 23:04 GMT+02:00 Philip Race <philip.race@oracle.com>:
>>>>>>>
>>>>>>>> You have a capital letter here and I think it must be lower case =
..
>>>>>>>>
>>>>>>>>
>>>>>>>> 2499 * @Since 10
>>>>>>>>
>>>>>>>> -phil.
>>>>>>>>
>>>>>>>>
>>>>>>>> On 4/20/17, 1:58 PM, Laurent Bourg=C3=A8s wrote:
>>>>>>>>
>>>>>>>> Hi Phil & Jim,
>>>>>>>>
>>>>>>>> Here is the updated webrev:
>>>>>>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/
>>>>>>>>
>>>>>>>> Changes:
>>>>>>>> - trimToSize() return void
>>>>>>>> - fixed test + jtreg passed
>>>>>>>>
>>>>>>>> Bye,
>>>>>>>> Laurent
>>>>>>>>
>>>>>>>> 2017-04-20 21:30 GMT+02:00 Jim Graham <james.graham@oracle.com>:
>>>>>>>>
>>>>>>>>> Hi Laurent,
>>>>>>>>>
>>>>>>>>> The implementation looks good, except that the method
>>>>>>>>> chaining-style return value seems out of place here. Similar tri=
mToSize()
>>>>>>>>> methods in Collections return void and none of the other methods =
in this
>>>>>>>>> area use the method chaining paradigm. In the interest of mainta=
ining a
>>>>>>>>> common design theme throughout 2D this method should just return =
void.
>>>>>>>>>
>>>>>>>>> ...jim
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 4/18/17 11:49 PM, Laurent Bourg=C3=A8s wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Here is a first attempt to propose a Path2D patch (based on
>>>>>>>>>> JDK10):
>>>>>>>>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/
>>>>>>>>>>
>>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8078192
>>>>>>>>>>
>>>>>>>>>> Please review the Path2D changes, notably the javadoc (english)
>>>>>>>>>> and the modified Path2DCopyConstructor
>>>>>>>>>
>>>>>>>>>
>>
>
[Attachment #3 (text/html)]
<div dir="auto">Thanks,<div dir="auto">Laurent</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">Le 18 août 2017 7:29 PM, \
"Phil Race" <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> a écrit :<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
CSR was approved and I have pushed the new API.<br>
<br>
-phil.<br>
<br>
<div class="m_-2977860433129944453moz-cite-prefix">On 08/17/2017 08:31 AM, Philip \
Race wrote:<br>
</div>
<blockquote type="cite">
I have filed <a class="m_-2977860433129944453moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8186364" \
target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8186364</a><br> and \
created and submitted the CSR for it :<br> <a \
class="m_-2977860433129944453moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8186365" \
target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8186365</a><br> <br>
-phil.<br>
<br>
On 8/17/17, 8:05 AM, Philip Race wrote:
<blockquote type="cite">
OK I'll handle the bureaucracy.<br>
<br>
-phil.<br>
<br>
On 8/17/17, 7:31 AM, Laurent Bourgès wrote:
<blockquote type="cite">
<div dir="auto">Phil,
<div dir="auto">Thanks for the explanations.</div>
<div dir="auto"><br>
</div>
<div dir="auto">I am not at home until next week so I would
prefer if you can create the new CSR and related bugs.</div>
<div dir="auto">As I said, this patch was reviewed and I
want it to be pushed in jdk10 finally.</div>
<div dir="auto"><br>
</div>
<div dir="auto">PS: I worked again on Marlin to implement an
efficient path clipper that is working well and very
promising performance.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Cheers,</div>
<div dir="auto">Laurent</div>
<br>
<div class="gmail_extra" dir="auto"><br>
<div class="gmail_quote">Le 17 août 2017 00:33, "Phil
Race" <<a href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>> a écrit :<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <div text="#000000" \
bgcolor="#FFFFFF"> It seems we are
going to have to file a completely new bug for this.<br>
It is not just a case of your permissions. The
migrated "CCC" can't be set to fix version 10.<br>
So Joe Darcy suggested creating a backport targeted
to 10 and creating a CSR from that<br>
but it turns out backports can't have CSRs. Joe was
a bit surprised by that.<br>
<br>
So<br>
1) create a new bug which references and largely
duplicates the original one<br>
2) Create a CSR for JDK 10 for that.<br>
3) Close the original bug as dup. of the new one.<br>
4) Get CSR approval and push under the new bug id.<br>
We won't need to do a new code review. Just update
the bugs with pointers<br>
to email threads explaining the relationship.<br>
<br>
If you want I can handle this hassle but if you want
to do it you can too.<br>
<br>
<br>
-phil.<br>
<br>
<div \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647moz-cite-prefix">On
08/11/2017 05:29 AM, Laurent Bourgès wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">Ping ?
<div dir="auto">In holidays ?</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">Le 13 juil. 2017 9:36
AM, "Laurent Bourgès" <<a \
href="mailto:bourges.laurent@gmail.com" \
target="_blank">bourges.laurent@gmail.com</a>> a écrit :<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="auto">Jim or Phil,
<div dir="auto">Could you handle the CSR
process on that patch and then push it
in jdk10 ?
<div dir="auto"><br>
</div>
<div dir="auto">I consider that bug
finished on my side.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Laurent</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">Le 8 juil. 2017
10:02, "Laurent Bourgès" <<a \
href="mailto:bourges.laurent@gmail.com" \
target="_blank">bourges.laurent@gmail.com</a>> a écrit :<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="auto">
<div>Phil,</div>
<div dir="auto"><br>
</div>
<div dir="auto">Here are my comments
on this CSR to be fixed in openjdk
10; I already submitted a patch
and the review process happened in
may.<br>
<div class="gmail_extra" dir="auto"><br>
<div class="gmail_quote">Le 3
juil. 2017 7:41 PM, "Phil
Race" <<a \
href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>>
a écrit :<br type="attribution">
<blockquote \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Laurent,<br>
<br>
Investigation has
determined that since this
was ported over in the
"CCC migration project",<br>
due to the way that is set
up it can't be assigned to
non-Oracle employees.<br>
</div>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Ok, no problem.</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div class="gmail_extra" dir="auto">
<div class="gmail_quote">
<blockquote \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> \
<br> It won't affect any new
CSRs that are created.<br>
<br>
Since the likelihood of
any other similar case is
extremely low, the
simplest answer is<br>
that either Jim or myself
will need to own and edit
this one on your behalf.<br>
<br>
Send Jim or myself the
changes you would like to
make off-line and we'll
take care of it.<br>
</div>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Just change the fix
version to 10 and the @since
javadoc tag as below:</div>
<div dir="auto"><br>
</div>
<div dir="auto"> /** </div>
<div dir="auto"> * Trims the
capacity of this Path2D instance
to its current </div>
<div dir="auto"> * size. An
application can use this operation
to minimize the </div>
<div dir="auto"> * storage of a
path. </div>
<div dir="auto"> * </div>
<div dir="auto"> * @since 10 </div>
<div dir="auto"> */ + public
abstract void trimToSize(); <br>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">It will match the
proposed patch.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks,</div>
<div dir="auto">Laurent</div>
<div dir="auto"><br>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div class="gmail_extra" dir="auto">
<div class="gmail_quote">
<blockquote \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_135873225198 \
4629676m_5430966587385304386m_575913136501115138m_-590955008623482259elided-text"> \
<blockquote type="cite"> <blockquote type="cite">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div bgcolor="#FFFFFF" \
text="#000000">
<blockquote type="cite">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div bgcolor="#FFFFFF" \
text="#000000"> <div>
<div \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_135873225198 \
4629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818h5">
<blockquote type="cite">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div class="gmail_extra">
<div>
<div \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_135873225198 \
4629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579h5"><br>
<div \
class="gmail_quote">2017-04-20 23:04
GMT+02:00
Philip Race <span \
dir="ltr"><<a href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>></span>:<br>
<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div bgcolor="#FFFFFF" \
text="#000000"> You have a
capital letter
here and I
think it must
be lower case
..<br>
<br>
<br>
2499 *
@Since 10<br>
<br>
-phil.
<div>
<div \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_135873225198 \
4629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579m_2453146926484059732h5"><br>
<br>
On 4/20/17,
1:58 PM,
Laurent
Bourgès wrote:
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Hi Phil
& Jim,<br>
<br>
</div>
Here is the
updated
webrev:<br>
<a \
href="http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.2/" \
target="_blank">http://cr.openjdk.java.net/~lb<wbr>ourges/path2D/Path2D-8078192.2<wbr>/</a><br>
<br>
</div>
<div>Changes:<br>
</div>
<div>-
trimToSize()
return void<br>
</div>
<div>- fixed
test + jtreg
passed<br>
</div>
<div><br>
</div>
<div>Bye,<br>
</div>
Laurent<br>
<div \
class="gmail_extra"><br>
<div \
class="gmail_quote">2017-04-20 21:30
GMT+02:00 Jim
Graham <span \
dir="ltr"><<a href="mailto:james.graham@oracle.com" \
target="_blank">james.graham@oracle.com</a>></span>:<br>
<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Laurent,<br>
<br>
The
implementation
looks good,
except that
the method
chaining-style
return value
seems out of
place here.
Similar
trimToSize()
methods in
Collections
return void
and none of
the other
methods in
this area use
the method
chaining
paradigm. In
the interest
of maintaining
a common
design theme
throughout 2D
this method
should just
return void.<span \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_135873225198 \
4629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-68165731111174 \
34165m_479405004460737818m_2760107019594871579m_2453146926484059732m_-3829295938273823275HOEnZb"><font \
color="#888888"><br> <br>
...jim</font></span>
<div \
class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_135873225198 \
4629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-68165731111174 \
34165m_479405004460737818m_2760107019594871579m_2453146926484059732m_-3829295938273823275HOEnZb">
<div class="m_-2977860433129944453m_-1118606083435615241m_3545422113398096647m_13587 \
32251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573 \
111117434165m_479405004460737818m_2760107019594871579m_2453146926484059732m_-3829295938273823275h5"><br>
<br>
On 4/18/17
11:49 PM,
Laurent
Bourgès wrote:<br>
<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi,<br>
<br>
Here is a
first attempt
to propose a
Path2D patch
(based on
JDK10):<br>
<a \
href="http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.0/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~lb<wbr>ourges/path2D/Path2D-8078192.0<wbr>/</a><br>
<br>
JBS: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8078192" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8078192</a><br> <br>
Please review
the Path2D
changes,
notably the
javadoc
(english) and
the modified
\
Path2DCopyConstructor</blockquote> </div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</blockquote>
</blockquote>
<br>
</div>
</blockquote></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic