[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] <Swing Dev> <Sound Dev> [9] Review Request: 8180326 Update the tables in java.d
From:       Alexander Zvegintsev <alexander.zvegintsev () oracle ! com>
Date:       2017-06-08 4:34:25
Message-ID: ad507f33-67ce-4036-8a0f-841f6cd100a0 () oracle ! com
[Download RAW message or body]

Thanks for clarification, looks good to me.

Thanks,
Alexander.

On 07/06/2017 23:22, Sergey Bylokhov wrote:
> Hi, Alexander.
> These closing tags are optional in html5 standard [1]. On the link to 
> the SO there are three the example which work differently but 
> according standards[2][3][4].
> 
> [1] https://www.w3.org/TR/html5/syntax.html#syntax-tag-omission
> 
> [2] http://jsfiddle.net/robertc/rNv93/1/
> [3] http://jsfiddle.net/UqzEp/2/
> [4] http://jsfiddle.net/UqzEp/3/
> 
> ----- alexander.zvegintsev@oracle.com wrote:
> > 
> 
> Hi Sergey,
> > 
> 
> Why do we omitting closing th tag?
> > 
> 
> e.g.
> > 
> 
> + * <caption>Metal's system color mapping</caption>
> + * <thead>
> + * <tr>
> + * <th>Key
> + * <th>Value
> + * </thead>
> 
> I know that HTML parsers are usually forgiving such things. But 
> sometimes it may make thing worse:
> > 
> 
> https://stackoverflow.com/questions/7125354/what-are-the-actual-problems-of-not-closing-tags-and-attributes-in-html/7135378#7135378
>  
> Thanks,
> Alexander.
> > On 05/06/2017 06:23, Sergey Bylokhov wrote:
> > 
> 
> If there are no objections I'll change the target ws from dev to client, to \
> minimize the merges between some other javadoc fixes. 
> -----sergey.bylokhov@oracle.com  wrote:
> 
> Hello.
> Here is an updated version where most of the caption are visible.
> Bug:https://bugs.openjdk.java.net/browse/JDK-8180326
> Webrev can be found at:
> http://cr.openjdk.java.net/~serb/8180326/webrev.02/
> Specdiff:
> http://cr.openjdk.java.net/~serb/8180326/specdiff.02/overview-summary.html
> 
> You can use search to check the changes in some specific class:
> Old docs:
> http://cr.openjdk.java.net/~serb/8180326/api_old.02/overview-summary.html
> New docs:
> http://cr.openjdk.java.net/~serb/8180326/api.02/overview-summary.html
> 
> 
> -----jonathan.gibbons@oracle.com  wrote:
> 
> Phil,
> 
> I have no evidence one way or the other whether screen readers pay
> attention
> to undisplayed or invisible captions. It seemed safest to assume
> 
> that
> 
> they would
> read a visible caption, and that we should head in that general
> direction.
> 
> -- Jon
> 
> 
> On 05/17/2017 11:58 AM, Phil Race wrote:
> 
> And PS I was not saying anything to contradict
> 
> tables should not have a summary attribute and should have a
> 
> caption.
> 
> However that the docs I read on the web did seem to imply that
> summary was very much intended for ATs but it was not at all
> 
> clear
> 
> this
> 
> is the point of caption. I'm sure they can read it, but I don't
> 
> get
> 
> how making
> it visible matters to them so how it making it visible relates to
> 
> accessibility
> requirements is not an obvious connection to me. So why do we
> 
> have
> 
> to make it visible for ATs ?
> 
> -phil.
> 
> On 05/17/2017 11:54 AM, Phil Race wrote:
> 
> I will leave the decision on whether to do that now up to Sergey
> 
> although
> it seems all he has to do here is remove "invisible".
> Many of the "summary" ones had wrong or misleading text but they
> seem to have been all fixed.
> 
> I'd want to see what the new HTML looks like with a visible
> 
> title
> 
> of
> 
> course ..
> 
> -phil.
> 
> On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:
> 
> Phil,
> 
> The bottom line is that in the JDK docs, tables should not have
> 
> a
> 
> summary attribute and should have a caption. This comes down to
> 
> accessibility requirements, where we are slowly raising the bar
> 
> on
> 
> our docs, to be in accordance with Oracle's guidelines.
> 
> Hiding the caption (style="display:none") is an interim measure
> 
> we
> 
> have been using during the HTML 5 updates, especially in cases
> 
> where
> 
> the person doing the markup changes did not know enough to
> 
> create
> 
> an
> 
> appropriate caption that should be displayed. In time, we should
> 
> locate and update all table captions (in our standard docs
> 
> bundle)
> 
> that are not being displayed such that the text is both
> 
> appropriate
> 
> and visible. If you guys want to do that as part of this
> 
> update,
> 
> go
> 
> ahead. FWIW, that is what we did for the java.xml module in the
> 
> jaxp
> 
> repo ... pretty much all tables there now have a reasonable,
> 
> visible
> 
> caption.
> 
> -- Jon
> 
> 
> 
> On 05/17/2017 11:19 AM, Phil Race wrote:
> 
> I am not sure we are using the summary in a way that makes it
> worthwhile.
> As you noted in the other mail
> "The summary attribute was used to give a more descriptive
> 
> value
> 
> of the contents of the table.   A caption is more like a
> 
> title"
> 
> The values I see are more like a title and as you say that is
> 
> not
> 
> the idea. See the example here
> 
> https://www.w3.org/TR/WCAG20-TECHS/H73.html
> 
> Caption sounds like a title so it might actually be more
> appropriate than summary
> for the text we have except that its not clear why we'd want
> 
> it
> 
> to
> 
> be visible when we were fine without.
> 
> But being there and invisible may be pointless unless screen
> readers look for it even if invisible.
> 
> But if its not doing any harm I guess we can leave it as
> 
> proposed
> 
> I still need to look at the rest of the changes.
> 
> -phil.
> 
> On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
> 
> Sergey,
> 
> FWIW, the invisible caption should be regarded as a temporary
> 
> solution, until content authors can review/update the text of
> 
> the
> 
> caption and make it visible.
> 
> The general guideline in this conversion work has been to
> 
> avoid
> 
> changing the visible text of the specification, and captions
> 
> fall
> 
> into a grey area of whether the text is significant/normative
> 
> or
> 
> not.  Hence the temporary step to make them not displayed for
> 
> now.
> 
> -- Jon
> 
> On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
> 
> The "summary" is unsupported by the HTML5 and we replace it
> 
> by
> 
> invisible caption.
> These new styles are located in the stylesheet.css in the
> 
> root
> 
> of
> 
> the JavaDoc api folder, so I assume these styles should be
> 
> used
> 
> by others as well.
> They were added by this fix:
> https://bugs.openjdk.java.net/browse/JDK-8179479
> 
> -----philip.race@oracle.com  wrote:
> 
> Does this in any way match the rest of the docs ? Or is
> 
> everyone
> 
> left
> to
> style things how they want.
> I thought (?) maybe there is to be some javadoc tool
> 
> support
> 
> for
> 
> CSS
> styles.
> 
> Also why are all the table summaries removed ?
> 
> -phil.
> 
> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
> 
> This is because I use the same style for most of the
> 
> tables
> 
> 'class="striped"', which apply the same/unified style for
> all(most) of
> our tables.
> 
> Also this is because I removed 'inlined' styles, like
> 
> here:
> 
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
>  
> -----philip.race@oracle.com  wrote:
> 
> Adding 2d-dev because a number of the files are 2D.
> 
> What is the general reason for changing the appearance of
> 
> the
> 
> tables?
> 
> -phil.
> 
> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
> 
> Hello,
> Please review the fix for jdk9-dev.
> 
> This fix is a part of the effort to make all javadoc in
> 
> jdk9 be
> 
> compatible to HTML5.
> 
> It covers all errors which are reported by the javadoc
> 
> tool
> 
> during
> 
> the build of jdk for java.desktop module.
> 
> Bug:https://bugs.openjdk.java.net/browse/JDK-8180326
> Webrev can be found at:
> 
> http://cr.openjdk.java.net/~serb/8180326/webrev.01
> 
> Note that an appearance of some tables were changed
> 
> after
> 
> the
> 
> fix:
> 
> Before:
> 
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
>  
> After:
> 
> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html
> 
> Before:
> 
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
>  
> After :
> 
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html
>  
> Before:
> 
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
>  
> After:
> 
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html
>  
> 
> > 


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p>Thanks for clarification, looks good to me.<br>
    </p>
    <pre class="moz-signature" cols="72">Thanks,
Alexander.</pre>
    <div class="moz-cite-prefix">On 07/06/2017 23:22, Sergey Bylokhov
      wrote:<br>
    </div>
    <blockquote cite="mid:975b438a-ad3e-4e1d-bb41-518ba4f9017b@default"
      type="cite">
      <style type="text/css">p { margin: 0; }</style>
      <div style="font-family: Times New Roman; font-size: 12pt; color:
        #000000">Hi, Alexander.<br>
        These closing tags are optional in html5 standard [1]. On the
        link to the SO there are three the example which work
        differently but according standards[2][3][4].<br>
        <br>
        [1] <a class="moz-txt-link-freetext" \
href="https://www.w3.org/TR/html5/syntax.html#syntax-tag-omission">https://www.w3.org/TR/html5/syntax.html#syntax-tag-omission</a><br>
  <br>
        [2] <a class="moz-txt-link-freetext" \
href="http://jsfiddle.net/robertc/rNv93/1/">http://jsfiddle.net/robertc/rNv93/1/</a><br>
                
        [3] <a class="moz-txt-link-freetext" \
                href="http://jsfiddle.net/UqzEp/2/">http://jsfiddle.net/UqzEp/2/</a><br>
                
        [4] <a class="moz-txt-link-freetext" \
href="http://jsfiddle.net/UqzEp/3/">http://jsfiddle.net/UqzEp/3/</a><br>  <br>
        ----- <a class="moz-txt-link-abbreviated" \
href="mailto:alexander.zvegintsev@oracle.com">alexander.zvegintsev@oracle.com</a> \
wrote:  <br>
        &gt;
        <div>
          <p>Hi Sergey, <br>
            &gt; </p>
          <p>Why do we omitting closing th tag? <br>
            &gt; </p>
          <p>e.g. <br>
            &gt; </p>
          <p> </p>
          <pre><span class="new">+     * &lt;caption&gt;Metal's system color \
mapping&lt;/caption&gt;</span> <span class="new">+     * &lt;thead&gt;</span>
<span class="new">+     *  &lt;tr&gt;</span>
<span class="new">+     *    &lt;th&gt;Key</span>
<span class="new">+     *    &lt;th&gt;Value</span>
<span class="new">+     * &lt;/thead&gt;</span></pre>
          <p>I know that HTML parsers are usually forgiving such things.
            But sometimes it may make thing worse:<br>
            &gt; </p>
          <p><a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://stackoverflow.com/questions/7125354/what-are-the-actual-problems-of-not-closing-tags-and-attributes-in-html/7135378#7135378"
  target="_blank">https://stackoverflow.com/questions/7125354/what-are-the-actual-problems-of-not-closing-tags-and-attributes-in-html/7135378#7135378</a></p>
  <p> </p>
          <pre class="moz-signature">Thanks,
Alexander.</pre>
          <div class="moz-cite-prefix">&gt; On 05/06/2017 06:23, Sergey
            Bylokhov wrote:<br>
            &gt; </div>
          <blockquote
            cite="mid:4f6a1420-831d-4b6c-946c-05e770cb2f14@default">
            <pre>If there are no objections I'll change the target ws from dev to \
client, to minimize the merges between some other javadoc fixes.

----- <a moz-do-not-send="true" class="moz-txt-link-abbreviated" \
href="mailto:sergey.bylokhov@oracle.com" \
target="_blank">sergey.bylokhov@oracle.com</a> wrote:

</pre>
            <blockquote>
              <pre>Hello.
Here is an updated version where most of the caption are visible.
Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8180326" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8180326</a> Webrev can be \
found at: <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/webrev.02/" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/webrev.02/</a> Specdiff:
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/specdiff.02/overview-summary.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/specdiff.02/overview-summary.html</a>


You can use search to check the changes in some specific class:
Old docs:
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api_old.02/overview-summary.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api_old.02/overview-summary.html</a>
 New docs:
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api.02/overview-summary.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api.02/overview-summary.html</a>



----- <a moz-do-not-send="true" class="moz-txt-link-abbreviated" \
href="mailto:jonathan.gibbons@oracle.com" \
target="_blank">jonathan.gibbons@oracle.com</a> wrote:

</pre>
              <blockquote>
                <pre>Phil,

I have no evidence one way or the other whether screen readers pay 
attention
to undisplayed or invisible captions. It seemed safest to assume
</pre>
              </blockquote>
              <pre>that
</pre>
              <blockquote>
                <pre>they would
read a visible caption, and that we should head in that general
direction.

-- Jon


On 05/17/2017 11:58 AM, Phil Race wrote:
</pre>
                <blockquote>
                  <pre>And PS I was not saying anything to contradict
</pre>
                  <blockquote>
                    <pre>tables should not have a summary attribute and should have a
</pre>
                  </blockquote>
                </blockquote>
                <pre>caption.
</pre>
                <blockquote>
                  <pre>However that the docs I read on the web did seem to imply that
summary was very much intended for ATs but it was not at all
</pre>
                </blockquote>
              </blockquote>
              <pre>clear
</pre>
              <blockquote>
                <pre>this
</pre>
                <blockquote>
                  <pre>is the point of caption. I'm sure they can read it, but I \
don't </pre>
                </blockquote>
              </blockquote>
              <pre>get
</pre>
              <blockquote>
                <blockquote>
                  <pre>how making
it visible matters to them so how it making it visible relates to
</pre>
                </blockquote>
              </blockquote>
              <blockquote>
                <blockquote>
                  <pre>accessibility
requirements is not an obvious connection to me. So why do we
</pre>
                </blockquote>
              </blockquote>
              <pre>have
</pre>
              <blockquote>
                <blockquote>
                  <pre>to make it visible for ATs ?

-phil.

On 05/17/2017 11:54 AM, Phil Race wrote:
</pre>
                  <blockquote>
                    <pre>I will leave the decision on whether to do that now up to \
Sergey </pre>
                  </blockquote>
                </blockquote>
              </blockquote>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <pre>although
it seems all he has to do here is remove "invisible".
Many of the "summary" ones had wrong or misleading text but they
seem to have been all fixed.

I'd want to see what the new HTML looks like with a visible
</pre>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>title
</pre>
              <blockquote>
                <pre>of 
</pre>
                <blockquote>
                  <blockquote>
                    <pre>course ..

-phil.

On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:
</pre>
                    <blockquote>
                      <pre>Phil,

The bottom line is that in the JDK docs, tables should not have
</pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>a
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>summary attribute and should have a caption. This comes \
down to </pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>accessibility requirements, where we are slowly raising \
the bar </pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>on
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>our docs, to be in accordance with Oracle's guidelines.

Hiding the caption (style="display:none") is an interim measure
</pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>we
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>have been using during the HTML 5 updates, especially in \
cases </pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>where 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>the person doing the markup changes did not know enough to
</pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>create
</pre>
              <blockquote>
                <pre>an 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>appropriate caption that should be displayed. In time, we \
should </pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>locate and update all table captions (in our standard docs
</pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>bundle)
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>that are not being displayed such that the text is both
</pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>appropriate 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>and visible. If you guys want to do that as part of this
</pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>update,
</pre>
              <blockquote>
                <pre>go 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>ahead. FWIW, that is what we did for the java.xml module \
in the </pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>jaxp 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>repo ... pretty much all tables there now have a \
reasonable, </pre>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>visible 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <pre>caption.

-- Jon



On 05/17/2017 11:19 AM, Phil Race wrote:
</pre>
                      <blockquote>
                        <pre>I am not sure we are using the summary in a way that \
makes it  worthwhile.
As you noted in the other mail
"The summary attribute was used to give a more descriptive
</pre>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>value
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <pre>of the contents of the table.   A caption is more like a
</pre>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>title"
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <pre>The values I see are more like a title and as you say \
that is </pre>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>not
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <pre>the idea. See the example here

<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://www.w3.org/TR/WCAG20-TECHS/H73.html" \
target="_blank">https://www.w3.org/TR/WCAG20-TECHS/H73.html</a>

Caption sounds like a title so it might actually be more 
appropriate than summary
for the text we have except that its not clear why we'd want
</pre>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>it
</pre>
              <blockquote>
                <pre>to 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <pre>be visible when we were fine without.

But being there and invisible may be pointless unless screen 
readers look for it even if invisible.

But if its not doing any harm I guess we can leave it as
</pre>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>proposed
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <pre>I still need to look at the rest of the changes.

-phil.

On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
</pre>
                        <blockquote>
                          <pre>Sergey,

FWIW, the invisible caption should be regarded as a temporary
</pre>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <pre>solution, until content authors can review/update the \
text of </pre>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>the 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <pre>caption and make it visible.

The general guideline in this conversion work has been to
</pre>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>avoid
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <pre>changing the visible text of the specification, and \
captions </pre>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>fall 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <pre>into a grey area of whether the text is \
significant/normative </pre>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>or
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <pre>not.  Hence the temporary step to make them not \
displayed for </pre>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>now.
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <pre>-- Jon

On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
</pre>
                          <blockquote>
                            <pre>The "summary" is unsupported by the HTML5 and we \
replace it </pre>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>by
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <pre>invisible caption.
These new styles are located in the stylesheet.css in the
</pre>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>root
</pre>
              <blockquote>
                <pre>of 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <pre>the JavaDoc api folder, so I assume these styles \
should be </pre>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>used
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <pre>by others as well.
They were added by this fix:
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8179479" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8179479</a>

----- <a moz-do-not-send="true" class="moz-txt-link-abbreviated" \
href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a> \
wrote:

</pre>
                            <blockquote>
                              <pre>Does this in any way match the rest of the docs ? \
Or is </pre>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>everyone 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <pre>left
to
style things how they want.
I thought (?) maybe there is to be some javadoc tool
</pre>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>support
</pre>
              <blockquote>
                <pre>for 
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <pre>CSS
styles.

Also why are all the table summaries removed ?

-phil.

On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
</pre>
                              <blockquote>
                                <pre>This is because I use the same style for most of \
the </pre>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>tables
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <pre>'class="striped"', which apply the same/unified \
style for  all(most) of
our tables.
</pre>
                              <blockquote>
                                <pre>Also this is because I removed 'inlined' styles, \
like </pre>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>here:
</pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote> </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api_old.01/java/awt/font/TextAttribute.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <pre>----- <a moz-do-not-send="true" \
class="moz-txt-link-abbreviated" href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a> wrote:

</pre>
                                <blockquote>
                                  <pre>Adding 2d-dev because a number of the files \
are 2D.

What is the general reason for changing the appearance of
</pre>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>the
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <pre>tables?
</pre>
                              <blockquote>
                                <blockquote>
                                  <pre>-phil.

On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
</pre>
                                  <blockquote>
                                    <pre>Hello,
Please review the fix for jdk9-dev.

This fix is a part of the effort to make all javadoc in
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>jdk9 be
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <blockquote>
                                  <pre>compatible to HTML5.
</pre>
                                  <blockquote>
                                    <pre>It covers all errors which are reported by \
the javadoc </pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
                <pre>tool
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <pre>during
</pre>
                              <blockquote>
                                <blockquote>
                                  <pre>the build of jdk for java.desktop module.
</pre>
                                  <blockquote>
                                    <pre>Bug: <a moz-do-not-send="true" \
class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8180326" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8180326</a> Webrev can be \
found at: </pre>
                                  </blockquote>
                                  <pre><a moz-do-not-send="true" \
class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/webrev.01" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/webrev.01</a> </pre>
                                  <blockquote>
                                    <pre>Note that an appearance of some tables were \
changed </pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre>after
</pre>
              <blockquote>
                <pre>the
</pre>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <pre>fix:
</pre>
                              <blockquote>
                                <blockquote>
                                  <blockquote>
                                    <pre>Before:
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api_old.01/java/awt/font/TextAttribute.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <blockquote>
                                  <blockquote>
                                    <pre>After:
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api.01/java/awt/font/TextAttribute.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <blockquote>
                                  <blockquote>
                                    <pre>Before:
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <blockquote>
                                  <blockquote>
                                    <pre>After :
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api.01/javax/sound/sampled/AudioSystem.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <blockquote>
                                  <blockquote>
                                    <pre>Before:
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote>
                              <blockquote>
                                <blockquote>
                                  <blockquote>
                                    <pre>After:
</pre>
                                  </blockquote>
                                </blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
              <pre><a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eserb/8180326/api.01/javax/sound/sampled/AudioPermission.html" \
target="_blank">http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html</a>
 </pre>
              <blockquote>
                <blockquote>
                  <blockquote>
                    <blockquote>
                      <blockquote>
                        <blockquote>
                          <blockquote>
                            <blockquote> </blockquote>
                          </blockquote>
                        </blockquote>
                      </blockquote>
                    </blockquote>
                  </blockquote>
                </blockquote>
              </blockquote>
            </blockquote>
          </blockquote>
          <br>
          &gt; </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic