[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review request for 8181192: [macos] javafx.print.PrinterJob.showPrintDialog
From:       Philip Race <philip.race () oracle ! com>
Date:       2017-06-02 12:57:21
Message-ID: 593160B1.2000709 () oracle ! com
[Download RAW message or body]

+1

Please add the required RDP2 process label + comment to request this fix 
be pushed

-phil.

On 6/2/17, 5:40 AM, Anton Litvinov wrote:
> Hello Phil and Sergey,
>
> The new version of the back out fix, which does not remove the 
> regression test and adds "@ignore" jtreg tag, is following.
>
> Webrev (the 2nd version): 
> http://cr.openjdk.java.net/~alitvinov/8181192/jdk9/webrev.01
>
> Thank you,
> Anton
>
> On 6/1/2017 10:09 PM, Sergey Bylokhov wrote:
>>> The fix is fine but rather than deleting the test just mark it @ignore
>>>
>>> .. it can be then updated
>>> with a new version of the fix.
>> +1
>>
>>>
>>> -phil.
>>>
>>> On 6/1/17, 11:19 AM, Anton Litvinov wrote:
>>>> Hello,
>>>>
>>>> Could you please review the following fix for the bug.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181192
>>>> Webrev:
>>> http://cr.openjdk.java.net/~alitvinov/8181192/jdk9/webrev.00
>>>> The bug is a showstopper bug consisting in hanging during the call
>>> to
>>>> "javafx.print.PrinterJob.showPrintDialog(Windows)" method in JavaFX
>>>> application. The bug is a regression of the fix for the bug
>>> JDK-8167102.
>>>> The solution is a direct back out of the fix JDK-8167102, so it is a
>>>> reversed version of the patch for JDK-8167102.
>>>>
>>>> Thank you,
>>>> Anton
>
[prev in list] [next in list] [prev in thread] [next in thread]