[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review Request for 8159902: OGL surfaces are not HiDPI compatible on Linux/
From:       Phil Race <philip.race () oracle ! com>
Date:       2017-05-02 16:51:10
Message-ID: 6c3d17ef-9c9d-539c-fcc4-d66eaeef8d6c () oracle ! com
[Download RAW message or body]

Seems fine although I agree with Sergey to add the bug id to the test.

-phil.

On 05/01/2017 10:05 AM, Semyon Sadetsky wrote:
> On 04/30/2017 07:55 PM, Sergey Bylokhov wrote:
>
>> Hi, Semyon.
>> Should the GLXVSyncOffScreenSurfaceData/WGLVSyncOffScreenSurfaceData 
>> be updated as well? Seems it were also overlooked.
>> I thinks that instead of  «noreg-sqe » label it would be better to add 
>> the new bugid to the failed test.
> The GLXVSyncOffScreenSurfaceData surface will inherit this 
> functionality from the GLXOffScreenSurfaceData class after the current 
> fix. The WGLVSyncOffScreenSurfaceData surface inherits HiDPI support 
> from the WGLOffScreenSurfaceData class.
>
> --Semyon
>>> Hello,
>>>
>>> Please review the fix for jdk9.
>>>
>>> bug:https://bugs.openjdk.java.net/browse/JDK-8159902
>>>
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8159902/webrev.00/
>>>
>>> Probably, HiDPI support for Linux OGL was forgoten.
>>>
>>> Fix tries to add it now...
>>>
>>> --Semyon
>>>
>>>
>

[prev in list] [next in list] [prev in thread] [next in thread]