[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll
From:       Philip Race <philip.race () oracle ! com>
Date:       2017-03-29 13:33:10
Message-ID: 58DBB796.8060404 () oracle ! com
[Download RAW message or body]

+1

-phil.

On 3/29/17, 6:16 AM, Magnus Ihse Bursie wrote:
> On 2017-03-29 15:00, Erik Joelsson wrote:
>> Hello,
>>
>> The build of freetype used internally at Oracle when building OpenJDK 
>> builds (for the reference implementation) is very old. It was also 
>> built using Visual Studio 2010, which makes it require msvcr100.dll, 
>> while the rest of OpenJDK is built with Visual Studio 2013 and 
>> subsequently require msvcr120.dll.
>>
>> I have built new freetype binaries, using Visual Studio 2013, from 
>> the latest available freetype source, 2.7.1. We have verified that 
>> the OpenJDK builds using these binaries are behaving equally to those 
>> with the old binary, except for not requiring msvcr100.dll. This 
>> patch changes the jib-profiles configuration for JDK 9 to use the new 
>> freetype binaries.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8177135
>>
>> Patch:
>>
>> diff -r c38c6b270ccc common/conf/jib-profiles.js
>> --- a/common/conf/jib-profiles.js
>> +++ b/common/conf/jib-profiles.js
>> @@ -910,7 +910,7 @@
>>          freetype: {
>>              organization: common.organization,
>>              ext: "tar.gz",
>> -            revision: "2.3.4+1.0",
>> +            revision: "2.7.1-v120+1.0",
>>              module: "freetype-" + input.target_platform
>>          }
>>      };
>>
>> /Erik
>>
> Looks good to me.
>
> /Magnus

[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    +1<br>
    <br>
    -phil.<br>
    <br>
    On 3/29/17, 6:16 AM, Magnus Ihse Bursie wrote:
    <blockquote
      cite="mid:dbbb353c-a3a1-a98d-f969-42f84a93e663@oracle.com"
      type="cite">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
      <div class="moz-cite-prefix">On 2017-03-29 15:00, Erik Joelsson
        wrote:<br>
      </div>
      <blockquote
        cite="mid:27f1aaf9-4758-c279-39e0-459287ba9781@oracle.com"
        type="cite">Hello, <br>
        <br>
        The build of freetype used internally at Oracle when building
        OpenJDK builds (for the reference implementation) is very old.
        It was also built using Visual Studio 2010, which makes it
        require msvcr100.dll, while the rest of OpenJDK is built with
        Visual Studio 2013 and subsequently require msvcr120.dll. <br>
        <br>
        I have built new freetype binaries, using Visual Studio 2013,
        from the latest available freetype source, 2.7.1. We have
        verified that the OpenJDK builds using these binaries are
        behaving equally to those with the old binary, except for not
        requiring msvcr100.dll. This patch changes the jib-profiles
        configuration for JDK 9 to use the new freetype binaries. <br>
        <br>
        Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8177135">https://bugs.openjdk.java.net/browse/JDK-8177135</a>
  <br>
        <br>
        Patch: <br>
        <br>
        diff -r c38c6b270ccc common/conf/jib-profiles.js <br>
        --- a/common/conf/jib-profiles.js <br>
        +++ b/common/conf/jib-profiles.js <br>
        @@ -910,7 +910,7 @@ <br>
                         freetype: { <br>
                                 organization: common.organization, <br>
                                 ext: "tar.gz", <br>
        -                       revision: "2.3.4+1.0", <br>
        +                       revision: "2.7.1-v120+1.0", <br>
                                 module: "freetype-" + input.target_platform <br>
                         } <br>
                 }; <br>
        <br>
        /Erik <br>
        <br>
      </blockquote>
      Looks good to me.<br>
      <br>
      /Magnus<br>
    </blockquote>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic