[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review Request: 8177461 Wrong references are used in the javadoc in the jav
From:       Alexander Scherbatiy <alexandr.scherbatiy () oracle ! com>
Date:       2017-03-29 10:40:58
Message-ID: dc7d5c20-0570-ff6f-859f-52baf47b1922 () oracle ! com
[Download RAW message or body]

The fix looks good to me.

Thanks,
Alexandr.

On 23/03/17 18:24, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> In java.desktop module in a various places we use incorrect links.
> Most of them are in the documentation in non-public classes/methods(But=
 there are two places in public API - specdiff is provided)
>
> Common issues:
>   - The method is referenced without #
>   - The method which have some parameters is referenced as =C2=AB#metho=
d()=C2=BB instead of =C2=AB#method=C2=BB or =C2=AB#method(ParameterDescri=
ption)"
>   - The type which is referenced is not imported
>   - The reference to non-existed method/type.
>   - Copy pasted javadoc was removed.
>   - The type was renamed (like AppReOpenedListener to AppReopenedListen=
er)
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8177461
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8177461/webrev=
.00
> Specdiff: http://cr.openjdk.java.net/~serb/8177461/specdiff/overview-su=
mmary.html

[prev in list] [next in list] [prev in thread] [next in thread]